[FIR] FirJavaFacade: do not duplicate record constructor

The fresh version of intellij has all record-related declarations,
so an additional fake constructor leads to errors like
KTIJ-25364 (OVERLOAD_RESOLUTION_AMBIGUITY)

^KTIJ-25366 Fixed
^KTIJ-25364 Fixed
^KTIJ-25368 Fixed
^KTIJ-25370 Fixed

analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/DiagnosticCompilerTestFE10TestdataTestGenerated.java

@@ -33559,6 +33559,18 @@ public class DiagnosticCompilerTestFE10TestdataTestGenerated extends AbstractDia
                     runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecords.kt");
                 }
 
+                @Test
+                @TestMetadata("simpleRecordsDefaultConstructor.kt")
+                public void testSimpleRecordsDefaultConstructor() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsDefaultConstructor.kt");
+                }
+
+                @Test
+                @TestMetadata("simpleRecordsWithSecondaryConstructor.kt")
+                public void testSimpleRecordsWithSecondaryConstructor() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsWithSecondaryConstructor.kt");
+                }
+
                 @Test
                 @TestMetadata("supertypesCheck.kt")
                 public void testSupertypesCheck() throws Exception {

analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/LLFirPreresolvedReversedDiagnosticCompilerFE10TestDataTestGenerated.java

@@ -33559,6 +33559,18 @@ public class LLFirPreresolvedReversedDiagnosticCompilerFE10TestDataTestGenerated
                     runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecords.kt");
                 }
 
+                @Test
+                @TestMetadata("simpleRecordsDefaultConstructor.kt")
+                public void testSimpleRecordsDefaultConstructor() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsDefaultConstructor.kt");
+                }
+
+                @Test
+                @TestMetadata("simpleRecordsWithSecondaryConstructor.kt")
+                public void testSimpleRecordsWithSecondaryConstructor() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsWithSecondaryConstructor.kt");
+                }
+
                 @Test
                 @TestMetadata("supertypesCheck.kt")
                 public void testSupertypesCheck() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirLightTreeOldFrontendDiagnosticsTestGenerated.java

@@ -33559,6 +33559,18 @@ public class FirLightTreeOldFrontendDiagnosticsTestGenerated extends AbstractFir
                     runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecords.kt");
                 }
 
+                @Test
+                @TestMetadata("simpleRecordsDefaultConstructor.kt")
+                public void testSimpleRecordsDefaultConstructor() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsDefaultConstructor.kt");
+                }
+
+                @Test
+                @TestMetadata("simpleRecordsWithSecondaryConstructor.kt")
+                public void testSimpleRecordsWithSecondaryConstructor() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsWithSecondaryConstructor.kt");
+                }
+
                 @Test
                 @TestMetadata("supertypesCheck.kt")
                 public void testSupertypesCheck() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirPsiOldFrontendDiagnosticsTestGenerated.java

@@ -33673,6 +33673,18 @@ public class FirPsiOldFrontendDiagnosticsTestGenerated extends AbstractFirPsiDia
                     runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecords.kt");
                 }
 
+                @Test
+                @TestMetadata("simpleRecordsDefaultConstructor.kt")
+                public void testSimpleRecordsDefaultConstructor() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsDefaultConstructor.kt");
+                }
+
+                @Test
+                @TestMetadata("simpleRecordsWithSecondaryConstructor.kt")
+                public void testSimpleRecordsWithSecondaryConstructor() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsWithSecondaryConstructor.kt");
+                }
+
                 @Test
                 @TestMetadata("supertypesCheck.kt")
                 public void testSupertypesCheck() throws Exception {

compiler/fir/java/src/org/jetbrains/kotlin/fir/java/FirJavaFacade.kt

@@ -5,6 +5,7 @@
 
 package org.jetbrains.kotlin.fir.java
 
+import com.intellij.psi.impl.light.LightRecordCanonicalConstructor
 import org.jetbrains.kotlin.*
 import org.jetbrains.kotlin.builtins.jvm.JavaToKotlinClassMap
 import org.jetbrains.kotlin.descriptors.ClassKind
@@ -320,6 +321,7 @@ abstract class FirJavaFacade(
 
             if (javaClassDeclaredConstructors.isEmpty()
                 && javaClass.classKind == ClassKind.CLASS
+                && !javaClass.isRecord
                 && javaClass.hasDefaultConstructor()
             ) {
                 declarations += convertJavaConstructorToFir(
@@ -441,39 +443,46 @@ abstract class FirJavaFacade(
             }
         }
 
-        destination += buildJavaConstructor {
+        /**
-            source = javaClass.toSourceElement(KtFakeSourceElementKind.ImplicitJavaRecordConstructor)
+         * It is possible that JavaClass already has a synthetic primary constructor ([LightRecordCanonicalConstructor])
-            this.moduleData = moduleData
+         * Such behavior depends on a platform version and psi providers
-            isFromSource = javaClass.isFromSource
+         * (e.g., in IntelliJ plugin Java class can have additional declarations)
+         */
+        if (destination.none { it is FirJavaConstructor && it.isPrimary }) {
+            destination += buildJavaConstructor {
+                source = javaClass.toSourceElement(KtFakeSourceElementKind.ImplicitJavaRecordConstructor)
+                this.moduleData = moduleData
+                isFromSource = javaClass.isFromSource
 
-            val constructorId = CallableId(classId, classId.shortClassName)
+                val constructorId = CallableId(classId, classId.shortClassName)
-            symbol = FirConstructorSymbol(constructorId)
+                symbol = FirConstructorSymbol(constructorId)
-            status = FirResolvedDeclarationStatusImpl(
+                status = FirResolvedDeclarationStatusImpl(
-                Visibilities.Public,
+                    Visibilities.Public,
-                Modality.FINAL,
+                    Modality.FINAL,
-                EffectiveVisibility.Public
+                    EffectiveVisibility.Public
-            )
+                )
-            visibility = Visibilities.Public
+                visibility = Visibilities.Public
-            isPrimary = true
+                isPrimary = true
-            returnTypeRef = classType.toFirResolvedTypeRef()
+                returnTypeRef = classType.toFirResolvedTypeRef()
-            dispatchReceiverType = null
+                dispatchReceiverType = null
-            typeParameters += classTypeParameters.toRefs()
+                typeParameters += classTypeParameters.toRefs()
-            annotationBuilder = { emptyList() }
+                annotationBuilder = { emptyList() }
 
-            javaClass.recordComponents.mapTo(valueParameters) { component ->
+                javaClass.recordComponents.mapTo(valueParameters) { component ->
-                buildJavaValueParameter {
+                    buildJavaValueParameter {
-                    containingFunctionSymbol = this@buildJavaConstructor.symbol
+                        containingFunctionSymbol = this@buildJavaConstructor.symbol
-                    source = component.toSourceElement(KtFakeSourceElementKind.ImplicitRecordConstructorParameter)
+                        source = component.toSourceElement(KtFakeSourceElementKind.ImplicitRecordConstructorParameter)
-                    this.moduleData = moduleData
+                        this.moduleData = moduleData
-                    isFromSource = component.isFromSource
+                        isFromSource = component.isFromSource
-                    returnTypeRef = component.type.toFirJavaTypeRef(session, javaTypeParameterStack)
+                        returnTypeRef = component.type.toFirJavaTypeRef(session, javaTypeParameterStack)
-                    name = component.name
+                        name = component.name
-                    isVararg = component.isVararg
+                        isVararg = component.isVararg
-                    annotationBuilder = { emptyList() }
+                        annotationBuilder = { emptyList() }
+                    }
                 }
+            }.apply {
+                containingClassForStaticMemberAttr = classType.lookupTag
             }
-        }.apply {
-            containingClassForStaticMemberAttr = classType.lookupTag
         }
     }
 
@@ -636,7 +645,7 @@ abstract class FirJavaFacade(
                 hasStableParameterNames = false
             }
             this.visibility = visibility
-            isPrimary = javaConstructor == null
+            isPrimary = javaConstructor == null || source?.psi is LightRecordCanonicalConstructor
             returnTypeRef = buildResolvedTypeRef {
                 type = ownerClassBuilder.buildSelfTypeRef()
             }

compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsDefaultConstructor.kt

@@ -0,0 +1,12 @@
+// FIR_IDENTICAL
+// LANGUAGE: +JvmRecordSupport
+
+// FILE: MyRecord.java
+public record MyRecord(String str) {}
+
+// FILE: main.kt
+
+fun foo() {
+    MyRecord("") // OK
+    MyRecord<!NO_VALUE_FOR_PARAMETER!>()<!> // error
+}

compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsWithSecondaryConstructor.kt

@@ -0,0 +1,16 @@
+// FIR_IDENTICAL
+// LANGUAGE: +JvmRecordSupport
+
+// FILE: MyRecord.java
+public record MyRecord(String string, int number) {
+    public MyRecord(Long number, String string) {
+        this(string, 4)
+    }
+}
+
+// FILE: main.kt
+
+fun foo(mr: MyRecord) {
+    MyRecord("", 1)
+    MyRecord(4L, "")
+}

compiler/tests-common-new/tests-gen/org/jetbrains/kotlin/test/runners/DiagnosticTestGenerated.java

@@ -34517,6 +34517,18 @@ public class DiagnosticTestGenerated extends AbstractDiagnosticTest {
                     runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecords.kt");
                 }
 
+                @Test
+                @TestMetadata("simpleRecordsDefaultConstructor.kt")
+                public void testSimpleRecordsDefaultConstructor() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsDefaultConstructor.kt");
+                }
+
+                @Test
+                @TestMetadata("simpleRecordsWithSecondaryConstructor.kt")
+                public void testSimpleRecordsWithSecondaryConstructor() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/testsWithJava17/jvmRecord/simpleRecordsWithSecondaryConstructor.kt");
+                }
+
                 @Test
                 @TestMetadata("supertypesCheck.kt")
                 public void testSupertypesCheck() throws Exception {