JVM_IR generate range-based loop closer to Java counter loop
KT-48435 KT-48507
This commit is contained in:
+16
-17
@@ -1,5 +1,15 @@
|
||||
// TARGET_BACKEND: JVM_IR
|
||||
// WITH_RUNTIME
|
||||
|
||||
// IMPORTANT!
|
||||
// Please, when your changes cause failures in bytecodeText tests for 'for' loops,
|
||||
// examine the resulting bytecode shape carefully.
|
||||
// Range and progression-based loops generated with Kotlin compiler should be
|
||||
// as close as possible to Java counter loops ('for (int i = a; i < b; ++i) { ... }').
|
||||
// Otherwise it may result in performance regression due to missing HotSpot optimizations.
|
||||
// Run Kotlin compiler benchmarks (https://github.com/Kotlin/kotlin-benchmarks)
|
||||
// with compiler built from your changes if you are not sure.
|
||||
|
||||
fun box(): String {
|
||||
for (i in (1u..8u).reversed() step 2) {
|
||||
}
|
||||
@@ -10,22 +20,6 @@ fun box(): String {
|
||||
// For "step" progressions in JVM IR, a call to getProgressionLastElement() is made to compute the "last" value.
|
||||
// If the step is non-constant, there is a check that it is > 0, and if not, an IllegalArgumentException is thrown. However, when the
|
||||
// step is constant and > 0, this check does not need to be added.
|
||||
//
|
||||
// Expected lowered form of loop:
|
||||
//
|
||||
// // Standard form of loop over progression
|
||||
// val last = getProgressionLastElement(8u, 1u, -2)
|
||||
// var inductionVar = 8u
|
||||
// if (last <= inductionVar) {
|
||||
// // Loop is not empty
|
||||
// do {
|
||||
// val i = inductionVar
|
||||
// inductionVar += -2
|
||||
// // Loop body
|
||||
// } while (i != last)
|
||||
// }
|
||||
//
|
||||
// We can't use "0 reversed" in the regex below because "reversed" is in the test filename.
|
||||
|
||||
// 0 INVOKE.*reversed
|
||||
// 0 iterator
|
||||
@@ -38,7 +32,12 @@ fun box(): String {
|
||||
// 0 NEW java/lang/IllegalArgumentException
|
||||
// 0 ATHROW
|
||||
// 1 IFGT
|
||||
// 1 IF_ICMPNE
|
||||
// 1 IF_ICMPEQ
|
||||
// 2 IF
|
||||
// 0 INVOKESTATIC kotlin/UInt.constructor-impl
|
||||
// 0 INVOKE\w+ kotlin/UInt.(un)?box-impl
|
||||
// 5 ILOAD
|
||||
// 3 ISTORE
|
||||
// 0 IADD
|
||||
// 0 ISUB
|
||||
// 1 IINC
|
||||
|
||||
Reference in New Issue
Block a user