[Gradle, JS] Use dev server not as property in KotlinWebpackConfig

This commit is contained in:
Ilya Goncharov
2024-01-10 12:41:53 +00:00
committed by Space Team
parent fba2f5ea4e
commit b645997dc4
2 changed files with 5 additions and 18 deletions
@@ -244,7 +244,7 @@ constructor(
outputFileName = mainOutputFileName.get(), outputFileName = mainOutputFileName.get(),
configDirectory = configDirectory, configDirectory = configDirectory,
rules = rules, rules = rules,
devServerProperty = devServerProperty, devServer = devServerProperty.orNull,
devtool = devtool, devtool = devtool,
sourceMaps = sourceMaps, sourceMaps = sourceMaps,
resolveFromModulesFirst = resolveFromModulesFirst, resolveFromModulesFirst = resolveFromModulesFirst,
@@ -8,9 +8,7 @@
package org.jetbrains.kotlin.gradle.targets.js.webpack package org.jetbrains.kotlin.gradle.targets.js.webpack
import com.google.gson.GsonBuilder import com.google.gson.GsonBuilder
import org.gradle.api.provider.Property
import org.gradle.api.provider.Provider import org.gradle.api.provider.Provider
import org.gradle.api.tasks.Internal
import org.jetbrains.kotlin.gradle.targets.js.NpmVersions import org.jetbrains.kotlin.gradle.targets.js.NpmVersions
import org.jetbrains.kotlin.gradle.targets.js.RequiredKotlinJsDependency import org.jetbrains.kotlin.gradle.targets.js.RequiredKotlinJsDependency
import org.jetbrains.kotlin.gradle.targets.js.appendConfigsFromDir import org.jetbrains.kotlin.gradle.targets.js.appendConfigsFromDir
@@ -33,7 +31,7 @@ data class KotlinWebpackConfig(
var outputFileName: String? = entry?.name, var outputFileName: String? = entry?.name,
var configDirectory: File? = null, var configDirectory: File? = null,
var reportEvaluatedConfigFile: File? = null, var reportEvaluatedConfigFile: File? = null,
val devServerProperty: Property<DevServer>? = null, var devServer: DevServer? = null,
var watchOptions: WatchOptions? = null, var watchOptions: WatchOptions? = null,
var experiments: MutableSet<String> = mutableSetOf(), var experiments: MutableSet<String> = mutableSetOf(),
override val rules: KotlinWebpackRulesContainer, override val rules: KotlinWebpackRulesContainer,
@@ -56,17 +54,6 @@ data class KotlinWebpackConfig(
val progressReporterPathFilterInput: String? val progressReporterPathFilterInput: String?
get() = npmProjectDir?.get()?.let { npmProjectDir -> progressReporterPathFilter?.relativeOrAbsolute(npmProjectDir) } get() = npmProjectDir?.get()?.let { npmProjectDir -> progressReporterPathFilter?.relativeOrAbsolute(npmProjectDir) }
@get:Internal
@Deprecated(
"This property is deprecated and will be removed in future. Use devServerProperty instead",
replaceWith = ReplaceWith("devServerProperty")
)
var devServer: DevServer?
get() = devServerProperty?.get()
set(value) {
devServerProperty?.set(value)
}
fun getRequiredDependencies(versions: NpmVersions) = fun getRequiredDependencies(versions: NpmVersions) =
mutableSetOf<RequiredKotlinJsDependency>().also { mutableSetOf<RequiredKotlinJsDependency>().also {
it.add( it.add(
@@ -82,7 +69,7 @@ data class KotlinWebpackConfig(
) )
} }
if (devServerProperty != null && devServerProperty!!.isPresent) { if (devServer != null) {
it.add( it.add(
versions.webpackDevServer versions.webpackDevServer
) )
@@ -189,10 +176,10 @@ data class KotlinWebpackConfig(
} }
private fun Appendable.appendDevServer() { private fun Appendable.appendDevServer() {
if (devServerProperty != null && devServerProperty!!.isPresent) { if (devServer != null) {
appendLine("// dev server") appendLine("// dev server")
appendLine("config.devServer = ${json(devServerProperty!!.get())};") appendLine("config.devServer = ${json(devServer!!)};")
appendLine() appendLine()
} }