azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IR] Deduplicate StringConcatenationLowering in K/N

Browse Source 
The common lowering is updated based on
fac1cf189c
This commit is contained in:
Sergej Jaskiewicz
2021-10-22 14:48:46 +03:00
committed by Space
parent c92e34ca9f
commit b27b202c28
3 changed files with 39 additions and 158 deletions
Download Patch File Download Diff File Expand all files Collapse all files
kotlin-native/backend.native/compiler/ir/backend.native/src/org/jetbrains/kotlin/backend/konan/KonanLoweringPhases.kt
+1 -1
View File
@@ -2,6 +2,7 @@ package org.jetbrains.kotlin.backend.konan
import org.jetbrains.kotlin.backend.common.*
import org.jetbrains.kotlin.backend.common.lower.*
import org.jetbrains.kotlin.backend.common.lower.StringConcatenationLowering
import org.jetbrains.kotlin.backend.common.lower.inline.FunctionInlining
import org.jetbrains.kotlin.backend.common.lower.inline.LocalClassesExtractionFromInlineFunctionsLowering
import org.jetbrains.kotlin.backend.common.lower.inline.LocalClassesInInlineFunctionsLowering
@@ -14,7 +15,6 @@ import org.jetbrains.kotlin.backend.konan.ir.FunctionsWithoutBoundCheckGenerator
import org.jetbrains.kotlin.backend.konan.lower.*
import org.jetbrains.kotlin.backend.konan.lower.FinallyBlocksLowering
import org.jetbrains.kotlin.backend.konan.lower.InitializersLowering
import org.jetbrains.kotlin.backend.konan.lower.StringConcatenationLowering
import org.jetbrains.kotlin.backend.konan.optimizations.KonanBCEForLoopBodyTransformer
import org.jetbrains.kotlin.ir.declarations.IrFile
import org.jetbrains.kotlin.ir.declarations.IrModuleFragment
kotlin-native/backend.native/compiler/ir/backend.native/src/org/jetbrains/kotlin/backend/konan/lower/StringConcatenationLowering.kt
-114
View File
@@ -1,114 +0,0 @@
package org.jetbrains.kotlin.backend.konan.lower
import org.jetbrains.kotlin.backend.common.FileLoweringPass
import org.jetbrains.kotlin.backend.common.atMostOne
import org.jetbrains.kotlin.backend.common.lower.IrBuildingTransformer
import org.jetbrains.kotlin.backend.common.lower.at
import org.jetbrains.kotlin.backend.common.lower.irBlock
import org.jetbrains.kotlin.backend.konan.Context
import org.jetbrains.kotlin.ir.builders.*
import org.jetbrains.kotlin.ir.declarations.IrFile
import org.jetbrains.kotlin.ir.declarations.IrSimpleFunction
import org.jetbrains.kotlin.ir.expressions.IrExpression
import org.jetbrains.kotlin.ir.expressions.IrStringConcatenation
import org.jetbrains.kotlin.ir.types.*
import org.jetbrains.kotlin.ir.util.constructors
import org.jetbrains.kotlin.ir.util.functions
import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
import org.jetbrains.kotlin.name.Name
import org.jetbrains.kotlin.util.OperatorNameConventions
/**
* This lowering pass replaces [IrStringConcatenation]s with StringBuilder appends.
*/
internal class StringConcatenationLowering(context: Context) : FileLoweringPass, IrBuildingTransformer(context) {
override fun lower(irFile: IrFile) {
irFile.transformChildrenVoid(this)
}
private val irBuiltIns = context.irBuiltIns
private val symbols = context.ir.symbols
private val typesWithSpecialAppendFunction = irBuiltIns.primitiveIrTypes + irBuiltIns.stringType
private val nameToString = Name.identifier("toString")
private val nameAppend = Name.identifier("append")
private val stringBuilder = context.ir.symbols.stringBuilder.owner
//TODO: calculate and pass string length to the constructor.
private val constructor = stringBuilder.constructors.single {
it.valueParameters.isEmpty()
}
private val toStringFunction = stringBuilder.functions.single {
it.valueParameters.isEmpty() && it.name == nameToString
}
private val defaultAppendFunction = stringBuilder.functions.single {
it.name == nameAppend &&
it.valueParameters.size == 1 &&
it.valueParameters.single().type.isNullableAny()
}
private val appendFunctions: Map<IrType, IrSimpleFunction?> =
typesWithSpecialAppendFunction.map { type ->
type to stringBuilder.functions.toList().atMostOne {
it.name == nameAppend && it.valueParameters.singleOrNull()?.type == type
}
}.toMap()
private fun typeToAppendFunction(type: IrType): IrSimpleFunction {
return appendFunctions[type] ?: defaultAppendFunction
}
override fun visitStringConcatenation(expression: IrStringConcatenation): IrExpression {
expression.transformChildrenVoid(this)
builder.at(expression)
val arguments = expression.arguments
return when {
arguments.isEmpty() -> builder.irString("")
arguments.size == 1 -> {
val argument = arguments[0]
if (argument.type.isNullable())
builder.irCall(symbols.extensionToString).apply {
extensionReceiver = argument
}
else builder.irCall(
irBuiltIns.anyClass.functions
.single { it.owner.name.asString() == "toString" }).apply {
dispatchReceiver = argument
}
}
arguments.size == 2 && arguments[0].type.isStringClassType() ->
if (arguments[0].type.isNullable())
builder.irCall(symbols.stringPlus).apply {
extensionReceiver = arguments[0]
putValueArgument(0, arguments[1])
}
else
builder.irCall(symbols.string.functions
.single { it.owner.name == OperatorNameConventions.PLUS }).apply {
dispatchReceiver = arguments[0]
putValueArgument(0, arguments[1])
}
else -> builder.irBlock(expression) {
val stringBuilderImpl = createTmpVariable(irCall(constructor))
expression.arguments.forEach { arg ->
val appendFunction = typeToAppendFunction(arg.type)
+irCall(appendFunction).apply {
dispatchReceiver = irGet(stringBuilderImpl)
putValueArgument(0, arg)
}
}
+irCall(toStringFunction).apply {
dispatchReceiver = irGet(stringBuilderImpl)
}
}
}
}
}