Convert to primary constructor preserves accessors #KT-17996 Fixed

idea/src/org/jetbrains/kotlin/idea/intentions/ConvertSecondaryConstructorToPrimaryIntention.kt

@@ -128,7 +128,9 @@ class ConvertSecondaryConstructorToPrimaryIntention : SelfTargetingRangeIntentio
             if (parameterDescriptor != null && propertyDescriptor != null) {
                 val property = DescriptorToSourceUtils.descriptorToDeclaration(propertyDescriptor) as? KtProperty
                 if (property != null) {
-                    if (propertyDescriptor.name == parameterDescriptor.name && propertyDescriptor.type == parameterDescriptor.type) {
+                    if (propertyDescriptor.name == parameterDescriptor.name &&
+                        propertyDescriptor.type == parameterDescriptor.type &&
+                        propertyDescriptor.accessors.all { it.isDefault }) {
                         propertyCommentSaver = CommentSaver(property)
                         val valOrVar = if (property.isVar) factory.createVarKeyword() else factory.createValKeyword()
                         newParameter.addBefore(valOrVar, newParameter.nameIdentifier)

idea/testData/intentions/convertSecondaryConstructorToPrimary/propertyWithGetter.kt

@@ -0,0 +1,14 @@
+fun log(s: String) {
+}
+
+class A {
+    var x: String
+        get() {
+            log(field)
+            return field
+        }
+
+    <caret>constructor(x: String) {
+        this.x = x
+    }
+}

idea/testData/intentions/convertSecondaryConstructorToPrimary/propertyWithGetter.kt.after

@@ -0,0 +1,11 @@
+fun log(s: String) {
+}
+
+class A(x: String) {
+    var x: String = x
+        get() {
+            log(field)
+            return field
+        }
+
+}

idea/testData/intentions/convertSecondaryConstructorToPrimary/propertyWithSetter.kt

@@ -0,0 +1,14 @@
+fun log(s: String) {
+}
+
+class A {
+    var x: String
+        set(value) {
+            log(value)
+            field = value
+        }
+
+    <caret>constructor(x: String) {
+        this.x = x
+    }
+}

idea/testData/intentions/convertSecondaryConstructorToPrimary/propertyWithSetter.kt.after

@@ -0,0 +1,11 @@
+fun log(s: String) {
+}
+
+class A(x: String) {
+    var x: String = x
+        set(value) {
+            log(value)
+            field = value
+        }
+
+}

idea/tests/org/jetbrains/kotlin/idea/intentions/IntentionTestGenerated.java

@@ -5867,6 +5867,18 @@ public class IntentionTestGenerated extends AbstractIntentionTest {
             doTest(fileName);
         }
 
+        @TestMetadata("propertyWithGetter.kt")
+        public void testPropertyWithGetter() throws Exception {
+            String fileName = KotlinTestUtils.navigationMetadata("idea/testData/intentions/convertSecondaryConstructorToPrimary/propertyWithGetter.kt");
+            doTest(fileName);
+        }
+
+        @TestMetadata("propertyWithSetter.kt")
+        public void testPropertyWithSetter() throws Exception {
+            String fileName = KotlinTestUtils.navigationMetadata("idea/testData/intentions/convertSecondaryConstructorToPrimary/propertyWithSetter.kt");
+            doTest(fileName);
+        }
+
         @TestMetadata("protectedConstructor.kt")
         public void testProtectedConstructor() throws Exception {
             String fileName = KotlinTestUtils.navigationMetadata("idea/testData/intentions/convertSecondaryConstructorToPrimary/protectedConstructor.kt");