KT-23931 Avoid infinite loop into RedundantGotoMethodTransformer

- Follow-up of 9fb0f59813 to avoid
infinite loop during redundant goto otpimization.

Fix of https://youtrack.jetbrains.com/issue/KT-23931

compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/RedundantGotoMethodTransformer.kt

@@ -82,17 +82,28 @@ class RedundantGotoMethodTransformer : MethodTransformer() {
 
     private fun rewriteLabelIfNeeded(
         jumpInsn: JumpInsnNode,
-        labelsToReplace: HashMap<LabelNode, JumpInsnNode>
+        labelsToReplace: Map<LabelNode, JumpInsnNode>
     ) {
-        val lastTargetLabel = getLastTargetJumpInsn(jumpInsn, labelsToReplace).label
+        val lastJumpInsn = getLastTargetJumpInsn(jumpInsn, labelsToReplace, mutableListOf())
-        if (lastTargetLabel != jumpInsn.label) {
+        if (lastJumpInsn != null && lastJumpInsn != jumpInsn) {
             // Do not remove the old label because it can be used to define a local variable range.
-            jumpInsn.label = lastTargetLabel
+            jumpInsn.label = lastJumpInsn.label
         }
     }
 
-    private fun getLastTargetJumpInsn(jumpInsn: JumpInsnNode, labelsToReplace: HashMap<LabelNode, JumpInsnNode>): JumpInsnNode {
+    private fun getLastTargetJumpInsn(
-        labelsToReplace[jumpInsn.label]?.let { return getLastTargetJumpInsn(it, labelsToReplace) }
+        jumpInsn: JumpInsnNode,
+        labelsToReplace: Map<LabelNode, JumpInsnNode>,
+        alreadyVisited: MutableList<JumpInsnNode>
+    ): JumpInsnNode? {
+        labelsToReplace[jumpInsn.label]?.let {
+            if (alreadyVisited.contains(it)) {
+                // Cycle detected, do no apply goto optimization
+                return null
+            }
+            alreadyVisited.add(it)
+            return getLastTargetJumpInsn(it, labelsToReplace, alreadyVisited)
+        }
         return jumpInsn
     }
 }

compiler/testData/codegen/bytecodeText/controlStructures/kt17110.kt

@@ -12,10 +12,9 @@ fun test(x: Int, y: Int): String {
     return result
 }
 
-fun box(): String {
+fun infiniteLoop() {
-    if (test(9, 10) != "c")
+    while(true) {}
-        return "Failures"
-    return "OK"
 }
 
-// 2 GOTO L7
+// 2 GOTO L7
+// 1 GOTO L1