FIR: Refactor checkUpperBoundViolated

There just should be a different facades for cases
A<T1, T2> and foo<T1, T2>()

Test data has changed for type alias constructors since previously,
it was working by mistake because of assumption that type alias arguments
are linearly mapped to the type parameters of the corresponding constructors

^KT-50703 Open

compiler/fir/analysis-tests/testData/resolve/diagnostics/upperBoundViolated.kt

@@ -45,7 +45,7 @@ fun <K, L : K> rest() {
 class NumColl<T : Collection<Number>>
 typealias NL<K> = NumColl<List<K>>
 val test7 = NL<Int>()<!UNRESOLVED_REFERENCE!>NumberPhile<!><!SYNTAX!><!>
-val test8 = NL<<!UPPER_BOUND_VIOLATED!>String<!>>()
+val test8 = <!UPPER_BOUND_VIOLATED!>NL<String>()<!>
 
 class NumberPhile<T: Number>(x: T)
 val np1 = NumberPhile(10)