Fix more deprecated configurations and disable fail mode for some tests

This commit is contained in:
Bingran
2020-11-13 18:25:52 +00:00
committed by Sergey Igushkin
parent 858f73124d
commit b0ebb02b6f
16 changed files with 39 additions and 33 deletions
@@ -5,6 +5,7 @@
package org.jetbrains.kotlin.gradle package org.jetbrains.kotlin.gradle
import org.gradle.api.logging.configuration.WarningMode
import org.jetbrains.kotlin.gradle.targets.js.dukat.ExternalsOutputFormat import org.jetbrains.kotlin.gradle.targets.js.dukat.ExternalsOutputFormat
import org.jetbrains.kotlin.gradle.util.modify import org.jetbrains.kotlin.gradle.util.modify
import org.junit.Test import org.junit.Test
@@ -330,7 +331,7 @@ class DukatIntegrationIT : BaseGradleIT() {
project.setupWorkingDir() project.setupWorkingDir()
project.gradleBuildScript().modify(::transformBuildScriptWithPluginsDsl) project.gradleBuildScript().modify(::transformBuildScriptWithPluginsDsl)
project.build("assemble") { project.build("assemble", options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) {
assertSuccessful() assertSuccessful()
} }
} }
@@ -381,7 +382,7 @@ class DukatIntegrationIT : BaseGradleIT() {
} }
val externalSrcs = "build/externals/both-jsIr/src" val externalSrcs = "build/externals/both-jsIr/src"
project.build("assemble") { project.build("assemble", options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) {
assertSuccessful() assertSuccessful()
assertTasksExecuted(":irGenerateExternalsIntegrated") assertTasksExecuted(":irGenerateExternalsIntegrated")
@@ -71,8 +71,8 @@ class IncrementalCompilationJvmMultiProjectIT : BaseIncrementalCompilationMultiP
apply plugin: 'kotlin' apply plugin: 'kotlin'
dependencies { dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib:${"$"}kotlin_version" implementation "org.jetbrains.kotlin:kotlin-stdlib:${"$"}kotlin_version"
compile 'org.codehaus.groovy:groovy-all:2.4.8' implementation 'org.codehaus.groovy:groovy-all:2.4.8'
} }
""".trimIndent() """.trimIndent()
} }
@@ -16,6 +16,7 @@
package org.jetbrains.kotlin.gradle package org.jetbrains.kotlin.gradle
import org.gradle.api.logging.configuration.WarningMode
import org.jetbrains.kotlin.gradle.tasks.USING_JVM_INCREMENTAL_COMPILATION_MESSAGE import org.jetbrains.kotlin.gradle.tasks.USING_JVM_INCREMENTAL_COMPILATION_MESSAGE
import org.jetbrains.kotlin.gradle.util.* import org.jetbrains.kotlin.gradle.util.*
import org.junit.Assert import org.junit.Assert
@@ -30,7 +31,7 @@ abstract class Kapt3BaseIT : BaseGradleIT() {
} }
override fun defaultBuildOptions(): BuildOptions = override fun defaultBuildOptions(): BuildOptions =
super.defaultBuildOptions().copy(kaptOptions = kaptOptions()) super.defaultBuildOptions().copy(kaptOptions = kaptOptions(), warningMode = WarningMode.Summary)
protected open fun kaptOptions(): KaptOptions = protected open fun kaptOptions(): KaptOptions =
KaptOptions(verbose = true, useWorkers = false) KaptOptions(verbose = true, useWorkers = false)
@@ -776,7 +776,7 @@ class KotlinGradleIT : BaseGradleIT() {
setupWorkingDir() setupWorkingDir()
// Add a dependency with an explicit lower Kotlin version that has a kotlin-stdlib transitive dependency: // Add a dependency with an explicit lower Kotlin version that has a kotlin-stdlib transitive dependency:
gradleBuildScript().appendText("\ndependencies { implementation 'org.jetbrains.kotlin:kotlin-reflect:1.2.71' }") gradleBuildScript().appendText("\ndependencies { implementation 'org.jetbrains.kotlin:kotlin-reflect:1.2.71' }")
testResolveAllConfigurations { testResolveAllConfigurations(options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) {
assertSuccessful() assertSuccessful()
assertContains(">> :compileClasspath --> kotlin-reflect-1.2.71.jar") assertContains(">> :compileClasspath --> kotlin-reflect-1.2.71.jar")
// Check that the default newer Kotlin version still wins for 'kotlin-stdlib': // Check that the default newer Kotlin version still wins for 'kotlin-stdlib':
@@ -17,6 +17,7 @@
package org.jetbrains.kotlin.gradle package org.jetbrains.kotlin.gradle
import com.intellij.testFramework.TestDataPath import com.intellij.testFramework.TestDataPath
import org.gradle.api.logging.configuration.WarningMode
import org.jetbrains.kotlin.gradle.internals.KOTLIN_12X_MPP_DEPRECATION_WARNING import org.jetbrains.kotlin.gradle.internals.KOTLIN_12X_MPP_DEPRECATION_WARNING
import org.jetbrains.kotlin.gradle.plugin.EXPECTED_BY_CONFIG_NAME import org.jetbrains.kotlin.gradle.plugin.EXPECTED_BY_CONFIG_NAME
import org.jetbrains.kotlin.gradle.plugin.IMPLEMENT_CONFIG_NAME import org.jetbrains.kotlin.gradle.plugin.IMPLEMENT_CONFIG_NAME
@@ -175,7 +176,7 @@ class MultiplatformGradleIT : BaseGradleIT() {
@Test @Test
fun testMultipleCommonModules(): Unit = with(Project("multiplatformMultipleCommonModules")) { fun testMultipleCommonModules(): Unit = with(Project("multiplatformMultipleCommonModules")) {
build("build") { build("build", options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) {
assertSuccessful() assertSuccessful()
val sourceSets = listOf("", "Test") val sourceSets = listOf("", "Test")
@@ -305,7 +306,7 @@ class MultiplatformGradleIT : BaseGradleIT() {
val customSourceSetCompileTasks = listOf(":lib" to "Common", ":libJs" to "2Js", ":libJvm" to "") val customSourceSetCompileTasks = listOf(":lib" to "Common", ":libJs" to "2Js", ":libJvm" to "")
.map { (module, platform) -> "$module:compile${sourceSetName.capitalize()}Kotlin$platform" } .map { (module, platform) -> "$module:compile${sourceSetName.capitalize()}Kotlin$platform" }
build(*customSourceSetCompileTasks.toTypedArray()) { build(*customSourceSetCompileTasks.toTypedArray(), options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) {
assertSuccessful() assertSuccessful()
assertTasksExecuted(customSourceSetCompileTasks) assertTasksExecuted(customSourceSetCompileTasks)
} }
@@ -44,10 +44,6 @@ class NewMultiplatformIT : BaseGradleIT() {
private fun Project.targetClassesDir(targetName: String, sourceSetName: String = "main") = private fun Project.targetClassesDir(targetName: String, sourceSetName: String = "main") =
classesDir(sourceSet = "$targetName/$sourceSetName") classesDir(sourceSet = "$targetName/$sourceSetName")
override fun defaultBuildOptions(): BuildOptions {
return super.defaultBuildOptions().copy(warningMode = WarningMode.Summary)
}
@Test @Test
fun testLibAndApp() = doTestLibAndApp( fun testLibAndApp() = doTestLibAndApp(
"sample-lib", "sample-lib",
@@ -1280,7 +1276,7 @@ class NewMultiplatformIT : BaseGradleIT() {
@Test @Test
fun testJsDceInMpp() = with(Project("new-mpp-js-dce", gradleVersion)) { fun testJsDceInMpp() = with(Project("new-mpp-js-dce", gradleVersion)) {
build("runRhino") { build("runRhino", options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) {
assertSuccessful() assertSuccessful()
assertTasksExecuted(":mainProject:runDceNodeJsKotlin") assertTasksExecuted(":mainProject:runDceNodeJsKotlin")
@@ -1365,7 +1361,7 @@ class NewMultiplatformIT : BaseGradleIT() {
fun testDependenciesDsl() = with(transformProjectWithPluginsDsl("newMppDependenciesDsl")) { fun testDependenciesDsl() = with(transformProjectWithPluginsDsl("newMppDependenciesDsl")) {
val originalBuildscriptContent = gradleBuildScript("app").readText() val originalBuildscriptContent = gradleBuildScript("app").readText()
fun testDependencies() = testResolveAllConfigurations("app") { fun testDependencies() = testResolveAllConfigurations("app", options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) {
assertContains(">> :app:testNonTransitiveStringNotationApiDependenciesMetadata --> junit-4.12.jar") assertContains(">> :app:testNonTransitiveStringNotationApiDependenciesMetadata --> junit-4.12.jar")
assertEquals( assertEquals(
1, 1,
@@ -1399,7 +1395,7 @@ class NewMultiplatformIT : BaseGradleIT() {
@Test @Test
fun testMultipleTargetsSamePlatform() = with(Project("newMppMultipleTargetsSamePlatform", gradleVersion)) { fun testMultipleTargetsSamePlatform() = with(Project("newMppMultipleTargetsSamePlatform", gradleVersion)) {
testResolveAllConfigurations("app") { testResolveAllConfigurations("app", options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) {
assertContains(">> :app:junitCompileClasspath --> lib-junit.jar") assertContains(">> :app:junitCompileClasspath --> lib-junit.jar")
assertContains(">> :app:junitCompileClasspath --> junit-4.12.jar") assertContains(">> :app:junitCompileClasspath --> junit-4.12.jar")
@@ -1489,7 +1485,7 @@ class NewMultiplatformIT : BaseGradleIT() {
val groupDir = "build/repo/com/example/" val groupDir = "build/repo/com/example/"
build(":mpp-lib:publish") { build(":mpp-lib:publish", options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) {
assertSuccessful() assertSuccessful()
assertFileExists(groupDir + "mpp-lib") assertFileExists(groupDir + "mpp-lib")
assertFileExists(groupDir + "mpp-lib-myjvm") assertFileExists(groupDir + "mpp-lib-myjvm")
@@ -1506,7 +1502,7 @@ class NewMultiplatformIT : BaseGradleIT() {
add("-Pkotlin.mpp.keepMppDependenciesIntactInPoms=true") add("-Pkotlin.mpp.keepMppDependenciesIntactInPoms=true")
}.toTypedArray() }.toTypedArray()
build(*params) { build(*params, options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) {
assertSuccessful() assertSuccessful()
if (legacyPublishing) { if (legacyPublishing) {
assertTasksExecuted(":jvm-app:uploadArchives") assertTasksExecuted(":jvm-app:uploadArchives")
@@ -1,5 +1,6 @@
package org.jetbrains.kotlin.gradle package org.jetbrains.kotlin.gradle
import org.gradle.api.logging.configuration.WarningMode
import org.jetbrains.kotlin.gradle.util.modify import org.jetbrains.kotlin.gradle.util.modify
import org.junit.Test import org.junit.Test
import java.io.File import java.io.File
@@ -7,6 +8,10 @@ import kotlin.test.assertTrue
class SimpleKotlinGradleIT : BaseGradleIT() { class SimpleKotlinGradleIT : BaseGradleIT() {
override fun defaultBuildOptions(): BuildOptions {
return super.defaultBuildOptions().copy(warningMode = WarningMode.Summary)
}
@Test @Test
fun testSimpleCompile() { fun testSimpleCompile() {
val project = Project("simpleProject") val project = Project("simpleProject")
@@ -5,6 +5,7 @@
package org.jetbrains.kotlin.gradle package org.jetbrains.kotlin.gradle
import org.gradle.api.logging.configuration.WarningMode
import org.jetbrains.kotlin.gradle.util.AGPVersion import org.jetbrains.kotlin.gradle.util.AGPVersion
import org.jetbrains.kotlin.gradle.util.checkBytecodeContains import org.jetbrains.kotlin.gradle.util.checkBytecodeContains
import org.jetbrains.kotlin.gradle.util.modify import org.jetbrains.kotlin.gradle.util.modify
@@ -14,6 +15,11 @@ import java.io.File
import kotlin.test.assertTrue import kotlin.test.assertTrue
class SubpluginsIT : BaseGradleIT() { class SubpluginsIT : BaseGradleIT() {
override fun defaultBuildOptions(): BuildOptions {
return super.defaultBuildOptions().copy(warningMode = WarningMode.Summary)
}
@Test @Test
fun testGradleSubplugin() { fun testGradleSubplugin() {
val project = Project("kotlinGradleSubplugin") val project = Project("kotlinGradleSubplugin")
@@ -6,7 +6,6 @@
package org.jetbrains.kotlin.gradle.native package org.jetbrains.kotlin.gradle.native
import com.intellij.testFramework.TestDataFile import com.intellij.testFramework.TestDataFile
import org.gradle.api.logging.configuration.WarningMode
import org.jdom.input.SAXBuilder import org.jdom.input.SAXBuilder
import org.jetbrains.kotlin.gradle.BaseGradleIT import org.jetbrains.kotlin.gradle.BaseGradleIT
import org.jetbrains.kotlin.gradle.GradleVersionRequired import org.jetbrains.kotlin.gradle.GradleVersionRequired
@@ -94,10 +93,6 @@ class GeneralNativeIT : BaseGradleIT() {
override val defaultGradleVersion: GradleVersionRequired override val defaultGradleVersion: GradleVersionRequired
get() = GradleVersionRequired.FOR_MPP_SUPPORT get() = GradleVersionRequired.FOR_MPP_SUPPORT
override fun defaultBuildOptions(): BuildOptions {
return super.defaultBuildOptions().copy(warningMode = WarningMode.Summary)
}
@Test @Test
fun testParallelExecutionSmoke(): Unit = with(transformNativeTestProjectWithPluginDsl("native-parallel")) { fun testParallelExecutionSmoke(): Unit = with(transformNativeTestProjectWithPluginDsl("native-parallel")) {
// Check that the K/N compiler can be started in-process in parallel. // Check that the K/N compiler can be started in-process in parallel.
@@ -17,6 +17,7 @@ fun BaseGradleIT.Project.testResolveAllConfigurations(
subproject: String? = null, subproject: String? = null,
skipSetup: Boolean = false, skipSetup: Boolean = false,
excludePredicate: String = "false", excludePredicate: String = "false",
options: BaseGradleIT.BuildOptions = testCase.defaultBuildOptions(),
withUnresolvedConfigurationNames: BaseGradleIT.CompiledProject.(List<String>) -> Unit = { assertTrue("Unresolved configurations: $it") { it.isEmpty() } } withUnresolvedConfigurationNames: BaseGradleIT.CompiledProject.(List<String>) -> Unit = { assertTrue("Unresolved configurations: $it") { it.isEmpty() } }
) = with(testCase) { ) = with(testCase) {
@@ -32,7 +33,7 @@ fun BaseGradleIT.Project.testResolveAllConfigurations(
} }
} }
build(RESOLVE_ALL_CONFIGURATIONS_TASK_NAME, options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) { build(RESOLVE_ALL_CONFIGURATIONS_TASK_NAME, options = options) {
assertSuccessful() assertSuccessful()
assertTasksExecuted(":${subproject?.let { "$it:" }.orEmpty()}$RESOLVE_ALL_CONFIGURATIONS_TASK_NAME") assertTasksExecuted(":${subproject?.let { "$it:" }.orEmpty()}$RESOLVE_ALL_CONFIGURATIONS_TASK_NAME")
val unresolvedConfigurations = unresolvedConfigurationRegex.findAll(output).map { it.groupValues[1] }.toList() val unresolvedConfigurations = unresolvedConfigurationRegex.findAll(output).map { it.groupValues[1] }.toList()
@@ -1,6 +1,6 @@
apply plugin: 'kotlin' apply plugin: 'kotlin'
dependencies { dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
compile project(':lib') implementation project(':lib')
} }
@@ -1,5 +1,5 @@
apply plugin: 'kotlin' apply plugin: 'kotlin'
dependencies { dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
} }
@@ -16,7 +16,7 @@ repositories {
} }
dependencies { dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
} }
task('exit') { task('exit') {
@@ -17,5 +17,5 @@ repositories {
} }
dependencies { dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
} }
@@ -13,8 +13,8 @@ repositories {
} }
dependencies { dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8" implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8"
testCompile "junit:junit:4.12" testImplementation "junit:junit:4.12"
} }
afterEvaluate { afterEvaluate {
@@ -1,7 +1,7 @@
dependencies { dependencies {
compile 'com.google.guava:guava:12.0' implementation 'com.google.guava:guava:12.0'
testCompile 'org.testng:testng:6.8' testImplementation 'org.testng:testng:6.8'
compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
} }
test { test {