fixes after review

This commit is contained in:
Ilya Chernikov
2016-06-24 14:33:48 -07:00
committed by Pavel V. Talanov
parent 5a77d2e92b
commit b0bff64cff
9 changed files with 76 additions and 89 deletions
+1 -1
View File
@@ -14,6 +14,6 @@
<orderEntry type="module" module-name="light-classes" />
<orderEntry type="module" module-name="frontend.java" />
<orderEntry type="module" module-name="util" />
<orderEntry type="library" name="gradle-and-groovy-plugin" level="project" />
<orderEntry type="library" scope="PROVIDED" name="gradle-and-groovy-plugin" level="project" />
</component>
</module>
@@ -114,7 +114,7 @@ class KotlinScriptConfigurationManager(
}
private fun reloadScriptDefinitions() {
(makeScriptDefsFromTemplateProviderExtensions(project /* TODO: add logging here */) +
(makeScriptDefsFromTemplateProviderExtensions(project, { ep, ex -> /* TODO: add logging here */ }) +
loadScriptConfigsFromProjectRoot(File(project.basePath ?: "")).map { KotlinConfigurableScriptDefinition(it, kotlinEnvVars) }).let {
if (it.isNotEmpty()) {
scriptDefinitionProvider.setScriptDefinitions(it + StandardScriptDefinition)
@@ -35,7 +35,7 @@ class GradleScriptTemplateProvider(project: Project, gim: GradleInstallationMana
gradleLibsPath?.listFiles { file -> file.extension == "jar" && depLibsPrefixes.any { file.name.startsWith(it) } }
?.map { it.canonicalPath }
?: emptyList()
override val environment: Map<String, Any?>? = kotlin.collections.mapOf("gradleHome" to gradleHome)
override val environment: Map<String, Any?>? = mapOf("gradleHome" to gradleHome)
companion object {
private val depLibsPrefixes = listOf("gradle-script-kotlin", "gradle-core")