azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

KT-36068 Remove redundant commitAllDocuments calls

Browse Source 
- Those calls seem to be redundant since the platform already
commits all documents before invoking any intention
- Also those calls are getting in the way of `Preview Intention` action
by requiring write action, which is not granted by the platform at
the moment
This commit is contained in:
Roman Golyshev
2020-03-24 22:07:27 +03:00
committed by Roman Golyshev
parent 576948eded
commit b0bd39e715
2 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/idea-analysis/src/org/jetbrains/kotlin/idea/inspections/IntentionBasedInspection.kt
-1
View File
@@ -169,7 +169,6 @@ abstract class IntentionBasedInspection<TElement : PsiElement> private construct
} }
override fun invoke(project: Project, editor: Editor?, file: PsiFile?) { override fun invoke(project: Project, editor: Editor?, file: PsiFile?) {
PsiDocumentManager.getInstance(project).commitAllDocuments()
applyFix() applyFix()
} }
idea/idea-analysis/src/org/jetbrains/kotlin/idea/intentions/SelfTargetingIntention.kt
-1
View File
@@ -94,7 +94,6 @@ abstract class SelfTargetingIntention<TElement : PsiElement>(
final override fun invoke(project: Project, editor: Editor?, file: PsiFile) { final override fun invoke(project: Project, editor: Editor?, file: PsiFile) {
editor ?: return editor ?: return
PsiDocumentManager.getInstance(project).commitAllDocuments()
val target = getTarget(editor, file) ?: return val target = getTarget(editor, file) ?: return
if (!FileModificationService.getInstance().preparePsiElementForWrite(target)) return if (!FileModificationService.getInstance().preparePsiElementForWrite(target)) return
applyTo(target, editor) applyTo(target, editor)