code cleanup: j2k module

This commit is contained in:
Dmitry Jemerov
2015-07-21 14:40:11 +02:00
parent e05c20b5c0
commit af722c8acd
8 changed files with 12 additions and 14 deletions
@@ -32,11 +32,11 @@ import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
import org.jetbrains.kotlin.psi.psiUtil.isExtensionDeclaration import org.jetbrains.kotlin.psi.psiUtil.isExtensionDeclaration
import org.jetbrains.kotlin.resolve.jvm.JvmPrimitiveType import org.jetbrains.kotlin.resolve.jvm.JvmPrimitiveType
trait ExpressionConverter { interface ExpressionConverter {
fun convertExpression(expression: PsiExpression, codeConverter: CodeConverter): Expression fun convertExpression(expression: PsiExpression, codeConverter: CodeConverter): Expression
} }
trait SpecialExpressionConverter { interface SpecialExpressionConverter {
fun convertExpression(expression: PsiExpression, codeConverter: CodeConverter): Expression? fun convertExpression(expression: PsiExpression, codeConverter: CodeConverter): Expression?
} }
@@ -252,7 +252,7 @@ class ForConverter(
if (indices == null) return null if (indices == null) return null
return if (reversed) return if (reversed)
MethodCallExpression.build(indices!!.assignNoPrototype(), "reversed", listOf(), listOf(), false) MethodCallExpression.build(indices.assignNoPrototype(), "reversed", listOf(), listOf(), false)
else else
indices indices
} }
@@ -36,13 +36,11 @@ import org.jetbrains.kotlin.j2k.usageProcessing.UsageProcessing
import org.jetbrains.kotlin.name.FqName import org.jetbrains.kotlin.name.FqName
import org.jetbrains.kotlin.psi.* import org.jetbrains.kotlin.psi.*
import org.jetbrains.kotlin.psi.psiUtil.isAncestor import org.jetbrains.kotlin.psi.psiUtil.isAncestor
import org.jetbrains.kotlin.psi.psiUtil.parents
import org.jetbrains.kotlin.psi.psiUtil.parentsWithSelf import org.jetbrains.kotlin.psi.psiUtil.parentsWithSelf
import org.jetbrains.kotlin.resolve.BindingContext import org.jetbrains.kotlin.resolve.BindingContext
import java.util.ArrayList import java.util.ArrayList
import java.util.Comparator import java.util.Comparator
import java.util.LinkedHashMap import java.util.LinkedHashMap
import kotlin.properties.Delegates
public interface PostProcessor { public interface PostProcessor {
public fun analyzeFile(file: JetFile, range: TextRange?): BindingContext public fun analyzeFile(file: JetFile, range: TextRange?): BindingContext
@@ -178,7 +176,7 @@ public class JavaToKotlinConverter(
val file: PsiFile, val file: PsiFile,
val processings: Collection<UsageProcessing> val processings: Collection<UsageProcessing>
) { ) {
val depth: Int by Delegates.lazy { target.parentsWithSelf.takeWhile { it !is PsiFile }.count() } val depth: Int by lazy { target.parentsWithSelf.takeWhile { it !is PsiFile }.count() }
} }
private fun buildExternalCodeProcessing( private fun buildExternalCodeProcessing(
@@ -27,7 +27,7 @@ import com.intellij.psi.search.searches.ReferencesSearch
import org.jetbrains.kotlin.idea.JetLanguage import org.jetbrains.kotlin.idea.JetLanguage
import java.util.ArrayList import java.util.ArrayList
public trait ReferenceSearcher { public interface ReferenceSearcher {
fun findLocalUsages(element: PsiElement, scope: PsiElement): Collection<PsiReference> fun findLocalUsages(element: PsiElement, scope: PsiElement): Collection<PsiReference>
fun hasInheritors(`class`: PsiClass): Boolean fun hasInheritors(`class`: PsiClass): Boolean
fun hasOverrides(method: PsiMethod): Boolean fun hasOverrides(method: PsiMethod): Boolean
@@ -19,7 +19,7 @@ package org.jetbrains.kotlin.j2k
import org.jetbrains.kotlin.psi.JetDeclaration import org.jetbrains.kotlin.psi.JetDeclaration
import org.jetbrains.kotlin.descriptors.DeclarationDescriptor import org.jetbrains.kotlin.descriptors.DeclarationDescriptor
public trait ResolverForConverter { public interface ResolverForConverter {
public fun resolveToDescriptor(declaration: JetDeclaration): DeclarationDescriptor? public fun resolveToDescriptor(declaration: JetDeclaration): DeclarationDescriptor?
} }
@@ -20,11 +20,11 @@ import com.intellij.psi.*
import org.jetbrains.kotlin.j2k.ast.* import org.jetbrains.kotlin.j2k.ast.*
import java.util.ArrayList import java.util.ArrayList
trait StatementConverter { interface StatementConverter {
fun convertStatement(statement: PsiStatement, codeConverter: CodeConverter): Statement fun convertStatement(statement: PsiStatement, codeConverter: CodeConverter): Statement
} }
trait SpecialStatementConverter { interface SpecialStatementConverter {
fun convertStatement(statement: PsiStatement, codeConverter: CodeConverter): Statement? fun convertStatement(statement: PsiStatement, codeConverter: CodeConverter): Statement?
} }
@@ -22,20 +22,20 @@ import org.jetbrains.kotlin.j2k.CodeConverter
import org.jetbrains.kotlin.j2k.SpecialExpressionConverter import org.jetbrains.kotlin.j2k.SpecialExpressionConverter
import org.jetbrains.kotlin.j2k.ast.Expression import org.jetbrains.kotlin.j2k.ast.Expression
trait UsageProcessing { interface UsageProcessing {
val targetElement: PsiElement val targetElement: PsiElement
val convertedCodeProcessor: ConvertedCodeProcessor? val convertedCodeProcessor: ConvertedCodeProcessor?
val javaCodeProcessor: ExternalCodeProcessor? val javaCodeProcessor: ExternalCodeProcessor?
val kotlinCodeProcessor: ExternalCodeProcessor? val kotlinCodeProcessor: ExternalCodeProcessor?
} }
trait ConvertedCodeProcessor { interface ConvertedCodeProcessor {
fun convertVariableUsage(expression: PsiReferenceExpression, codeConverter: CodeConverter): Expression? = null fun convertVariableUsage(expression: PsiReferenceExpression, codeConverter: CodeConverter): Expression? = null
fun convertMethodUsage(methodCall: PsiMethodCallExpression, codeConverter: CodeConverter): Expression? = null fun convertMethodUsage(methodCall: PsiMethodCallExpression, codeConverter: CodeConverter): Expression? = null
} }
trait ExternalCodeProcessor { interface ExternalCodeProcessor {
fun processUsage(reference: PsiReference): Array<PsiReference>? fun processUsage(reference: PsiReference): Array<PsiReference>?
} }
@@ -112,7 +112,7 @@ public abstract class AbstractJavaToKotlinConverterForWebDemoTest : TestCase() {
} }
} }
} }
classLoader = classLoader?.getParent() classLoader = classLoader.getParent()
} }
return null return null
} }