Rename FQNAMES -> FQ_NAMES

This commit is contained in:
Alexander Udalov
2014-04-23 22:41:04 +04:00
parent 525709bced
commit af421f53da
36 changed files with 60 additions and 61 deletions
-1
View File
@@ -2,7 +2,6 @@
<dictionary name="Nikolay.Krasko"> <dictionary name="Nikolay.Krasko">
<words> <words>
<w>accessors</w> <w>accessors</w>
<w>fqnames</w>
<w>goto</w> <w>goto</w>
<w>kdoc</w> <w>kdoc</w>
<w>memoized</w> <w>memoized</w>
@@ -3555,9 +3555,9 @@ The "returned" value of try expression with no finally is either the last expres
v.ifnonnull(nonnull); v.ifnonnull(nonnull);
JetType leftType = bindingContext.get(BindingContext.EXPRESSION_TYPE, left); JetType leftType = bindingContext.get(BindingContext.EXPRESSION_TYPE, left);
assert leftType != null; assert leftType != null;
throwNewException("kotlin/TypeCastException", DescriptorRenderer.FQNAMES_IN_TYPES.renderType(leftType) + throwNewException("kotlin/TypeCastException", DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(leftType) +
" cannot be cast to " + " cannot be cast to " +
DescriptorRenderer.FQNAMES_IN_TYPES.renderType(rightType)); DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(rightType));
v.mark(nonnull); v.mark(nonnull);
} }
} }
@@ -97,7 +97,7 @@ public abstract class ElementAlternativeSignatureData {
else { else {
throw new AlternativeSignatureMismatchException( throw new AlternativeSignatureMismatchException(
"Return type in alternative signature is missing, while in real signature it is '%s'", "Return type in alternative signature is missing, while in real signature it is '%s'",
DescriptorRenderer.FQNAMES_IN_TYPES.renderType(originalType)); DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(originalType));
} }
} }
@@ -74,7 +74,7 @@ public class TypeTransformingVisitor extends JetVisitor<JetType, Void> {
public JetType visitNullableType(@NotNull JetNullableType nullableType, Void aVoid) { public JetType visitNullableType(@NotNull JetNullableType nullableType, Void aVoid) {
if (!originalType.isNullable() && typeUsage != TYPE_ARGUMENT) { if (!originalType.isNullable() && typeUsage != TYPE_ARGUMENT) {
throw new AlternativeSignatureMismatchException("Auto type '%s' is not-null, while type in alternative signature is nullable: '%s'", throw new AlternativeSignatureMismatchException("Auto type '%s' is not-null, while type in alternative signature is nullable: '%s'",
DescriptorRenderer.FQNAMES_IN_TYPES.renderType(originalType), nullableType.getText()); DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(originalType), nullableType.getText());
} }
JetTypeElement innerType = nullableType.getInnerType(); JetTypeElement innerType = nullableType.getInnerType();
assert innerType != null : "Syntax error: " + nullableType.getText(); assert innerType != null : "Syntax error: " + nullableType.getText();
@@ -134,7 +134,7 @@ public class TypeTransformingVisitor extends JetVisitor<JetType, Void> {
if (arguments.size() != type.getTypeArgumentsAsTypes().size()) { if (arguments.size() != type.getTypeArgumentsAsTypes().size()) {
throw new AlternativeSignatureMismatchException("'%s' type in method signature has %d type arguments, while '%s' in alternative signature has %d of them", throw new AlternativeSignatureMismatchException("'%s' type in method signature has %d type arguments, while '%s' in alternative signature has %d of them",
DescriptorRenderer.FQNAMES_IN_TYPES.renderType(originalType), arguments.size(), type.getText(), DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(originalType), arguments.size(), type.getText(),
type.getTypeArgumentsAsTypes().size()); type.getTypeArgumentsAsTypes().size());
} }
@@ -150,7 +150,8 @@ public class DefaultErrorMessages {
MAP.put(DATA_CLASS_OVERRIDE_CONFLICT, "Function ''{0}'' generated for the data class conflicts with member of supertype ''{1}''", NAME, NAME); MAP.put(DATA_CLASS_OVERRIDE_CONFLICT, "Function ''{0}'' generated for the data class conflicts with member of supertype ''{1}''", NAME, NAME);
MAP.put(CANNOT_OVERRIDE_INVISIBLE_MEMBER, "''{0}'' has no access to ''{1}'', so it cannot override it", FQNAMES_IN_TYPES, FQNAMES_IN_TYPES); MAP.put(CANNOT_OVERRIDE_INVISIBLE_MEMBER, "''{0}'' has no access to ''{1}'', so it cannot override it", FQ_NAMES_IN_TYPES,
FQ_NAMES_IN_TYPES);
MAP.put(CANNOT_INFER_VISIBILITY, "Cannot infer visibility. Please specify it explicitly"); MAP.put(CANNOT_INFER_VISIBILITY, "Cannot infer visibility. Please specify it explicitly");
MAP.put(ENUM_ENTRY_SHOULD_BE_INITIALIZED, "Missing delegation specifier ''{0}''", NAME); MAP.put(ENUM_ENTRY_SHOULD_BE_INITIALIZED, "Missing delegation specifier ''{0}''", NAME);
@@ -162,7 +163,7 @@ public class DefaultErrorMessages {
MAP.put(UNUSED_PARAMETER, "Parameter ''{0}'' is never used", NAME); MAP.put(UNUSED_PARAMETER, "Parameter ''{0}'' is never used", NAME);
MAP.put(ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE, "Variable ''{0}'' is assigned but never accessed", NAME); MAP.put(ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE, "Variable ''{0}'' is assigned but never accessed", NAME);
MAP.put(VARIABLE_WITH_REDUNDANT_INITIALIZER, "Variable ''{0}'' initializer is redundant", NAME); MAP.put(VARIABLE_WITH_REDUNDANT_INITIALIZER, "Variable ''{0}'' initializer is redundant", NAME);
MAP.put(UNUSED_VALUE, "The value ''{0}'' assigned to ''{1}'' is never used", ELEMENT_TEXT, FQNAMES_IN_TYPES); MAP.put(UNUSED_VALUE, "The value ''{0}'' assigned to ''{1}'' is never used", ELEMENT_TEXT, FQ_NAMES_IN_TYPES);
MAP.put(UNUSED_CHANGED_VALUE, "The value changed at ''{0}'' is never used", ELEMENT_TEXT); MAP.put(UNUSED_CHANGED_VALUE, "The value changed at ''{0}'' is never used", ELEMENT_TEXT);
MAP.put(UNUSED_EXPRESSION, "The expression is unused"); MAP.put(UNUSED_EXPRESSION, "The expression is unused");
MAP.put(UNUSED_FUNCTION_LITERAL, "The function literal is unused. If you mean block, you can use 'run { ... }'"); MAP.put(UNUSED_FUNCTION_LITERAL, "The function literal is unused. If you mean block, you can use 'run { ... }'");
@@ -284,7 +285,7 @@ public class DefaultErrorMessages {
MAP.put(CONFLICTING_UPPER_BOUNDS, "Upper bounds of {0} have empty intersection", NAME); MAP.put(CONFLICTING_UPPER_BOUNDS, "Upper bounds of {0} have empty intersection", NAME);
MAP.put(CONFLICTING_CLASS_OBJECT_UPPER_BOUNDS, "Class object upper bounds of {0} have empty intersection", NAME); MAP.put(CONFLICTING_CLASS_OBJECT_UPPER_BOUNDS, "Class object upper bounds of {0} have empty intersection", NAME);
MAP.put(TOO_MANY_ARGUMENTS, "Too many arguments for {0}", FQNAMES_IN_TYPES); MAP.put(TOO_MANY_ARGUMENTS, "Too many arguments for {0}", FQ_NAMES_IN_TYPES);
MAP.put(CONSTANT_EXPECTED_TYPE_MISMATCH, "An {0} literal does not conform to the expected type {1}", STRING, RENDER_TYPE); MAP.put(CONSTANT_EXPECTED_TYPE_MISMATCH, "An {0} literal does not conform to the expected type {1}", STRING, RENDER_TYPE);
MAP.put(INTEGER_OVERFLOW, "This operation has led to an overflow"); MAP.put(INTEGER_OVERFLOW, "This operation has led to an overflow");
@@ -375,18 +376,18 @@ public class DefaultErrorMessages {
MAP.put(CANNOT_CHANGE_ACCESS_PRIVILEGE, "Cannot change access privilege ''{0}'' for ''{1}'' in ''{2}''", TO_STRING, NAME, NAME); MAP.put(CANNOT_CHANGE_ACCESS_PRIVILEGE, "Cannot change access privilege ''{0}'' for ''{1}'' in ''{2}''", TO_STRING, NAME, NAME);
MAP.put(RETURN_TYPE_MISMATCH_ON_OVERRIDE, "Return type of ''{0}'' is not a subtype of the return type of overridden member {1}", MAP.put(RETURN_TYPE_MISMATCH_ON_OVERRIDE, "Return type of ''{0}'' is not a subtype of the return type of overridden member {1}",
NAME, FQNAMES_IN_TYPES); NAME, FQ_NAMES_IN_TYPES);
MAP.put(PROPERTY_TYPE_MISMATCH_ON_OVERRIDE, "Type of ''{0}'' doesn't match to the type of overridden var-property {1}", MAP.put(PROPERTY_TYPE_MISMATCH_ON_OVERRIDE, "Type of ''{0}'' doesn't match to the type of overridden var-property {1}",
NAME, FQNAMES_IN_TYPES); NAME, FQ_NAMES_IN_TYPES);
MAP.put(VAR_OVERRIDDEN_BY_VAL, "Var-property {0} cannot be overridden by val-property {1}", FQNAMES_IN_TYPES, FQNAMES_IN_TYPES); MAP.put(VAR_OVERRIDDEN_BY_VAL, "Var-property {0} cannot be overridden by val-property {1}", FQ_NAMES_IN_TYPES, FQ_NAMES_IN_TYPES);
MAP.put(ABSTRACT_MEMBER_NOT_IMPLEMENTED, "{0} must be declared abstract or implement abstract member {1}", RENDER_CLASS_OR_OBJECT, MAP.put(ABSTRACT_MEMBER_NOT_IMPLEMENTED, "{0} must be declared abstract or implement abstract member {1}", RENDER_CLASS_OR_OBJECT,
FQNAMES_IN_TYPES); FQ_NAMES_IN_TYPES);
MAP.put(MANY_IMPL_MEMBER_NOT_IMPLEMENTED, "{0} must override {1} because it inherits many implementations of it", MAP.put(MANY_IMPL_MEMBER_NOT_IMPLEMENTED, "{0} must override {1} because it inherits many implementations of it",
RENDER_CLASS_OR_OBJECT, FQNAMES_IN_TYPES); RENDER_CLASS_OR_OBJECT, FQ_NAMES_IN_TYPES);
MAP.put(CONFLICTING_OVERLOADS, "''{0}'' is already defined in {1}", COMPACT_WITH_MODIFIERS, STRING); MAP.put(CONFLICTING_OVERLOADS, "''{0}'' is already defined in {1}", COMPACT_WITH_MODIFIERS, STRING);
@@ -458,15 +459,15 @@ public class DefaultErrorMessages {
String multipleDefaultsMessage = "More than one overridden descriptor declares a default value for ''{0}''. " + String multipleDefaultsMessage = "More than one overridden descriptor declares a default value for ''{0}''. " +
"As the compiler can not make sure these values agree, this is not allowed."; "As the compiler can not make sure these values agree, this is not allowed.";
MAP.put(MULTIPLE_DEFAULTS_INHERITED_FROM_SUPERTYPES, multipleDefaultsMessage, FQNAMES_IN_TYPES); MAP.put(MULTIPLE_DEFAULTS_INHERITED_FROM_SUPERTYPES, multipleDefaultsMessage, FQ_NAMES_IN_TYPES);
MAP.put(MULTIPLE_DEFAULTS_INHERITED_FROM_SUPERTYPES_WHEN_NO_EXPLICIT_OVERRIDE, multipleDefaultsMessage, FQNAMES_IN_TYPES); MAP.put(MULTIPLE_DEFAULTS_INHERITED_FROM_SUPERTYPES_WHEN_NO_EXPLICIT_OVERRIDE, multipleDefaultsMessage, FQ_NAMES_IN_TYPES);
MAP.put(PARAMETER_NAME_CHANGED_ON_OVERRIDE, "The corresponding parameter in the supertype ''{0}'' is named ''{1}''. " + MAP.put(PARAMETER_NAME_CHANGED_ON_OVERRIDE, "The corresponding parameter in the supertype ''{0}'' is named ''{1}''. " +
"This may cause problems when calling this function with named arguments.", NAME, NAME); "This may cause problems when calling this function with named arguments.", NAME, NAME);
MAP.put(DIFFERENT_NAMES_FOR_THE_SAME_PARAMETER_IN_SUPERTYPES, MAP.put(DIFFERENT_NAMES_FOR_THE_SAME_PARAMETER_IN_SUPERTYPES,
"Names of the parameter #{1} conflict in the following members of supertypes: ''{0}''. " + "Names of the parameter #{1} conflict in the following members of supertypes: ''{0}''. " +
"This may cause problems when calling this function with named arguments.", commaSeparated(FQNAMES_IN_TYPES), TO_STRING); "This may cause problems when calling this function with named arguments.", commaSeparated(FQ_NAMES_IN_TYPES), TO_STRING);
MAP.put(AMBIGUOUS_ANONYMOUS_TYPE_INFERRED, "Right-hand side has anonymous type. Please specify type explicitly", TO_STRING); MAP.put(AMBIGUOUS_ANONYMOUS_TYPE_INFERRED, "Right-hand side has anonymous type. Please specify type explicitly", TO_STRING);
@@ -120,7 +120,7 @@ public class Renderers {
@NotNull @NotNull
@Override @Override
public String render(@NotNull JetType type) { public String render(@NotNull JetType type) {
return DescriptorRenderer.FQNAMES_IN_TYPES.renderType(type); return DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(type);
} }
}; };
@@ -131,7 +131,7 @@ public class Renderers {
public String render(@NotNull Collection<? extends ResolvedCall<?>> argument) { public String render(@NotNull Collection<? extends ResolvedCall<?>> argument) {
StringBuilder stringBuilder = new StringBuilder("\n"); StringBuilder stringBuilder = new StringBuilder("\n");
for (ResolvedCall<?> call : argument) { for (ResolvedCall<?> call : argument) {
stringBuilder.append(DescriptorRenderer.FQNAMES_IN_TYPES.render(call.getResultingDescriptor())).append("\n"); stringBuilder.append(DescriptorRenderer.FQ_NAMES_IN_TYPES.render(call.getResultingDescriptor())).append("\n");
} }
return stringBuilder.toString(); return stringBuilder.toString();
} }
@@ -302,7 +302,7 @@ public class DeclarationResolver {
for (DeclarationDescriptor declarationDescriptor : descriptors) { for (DeclarationDescriptor declarationDescriptor : descriptors) {
for (PsiElement declaration : getDeclarationsByDescriptor(declarationDescriptor)) { for (PsiElement declaration : getDeclarationsByDescriptor(declarationDescriptor)) {
assert declaration != null : "Null declaration for descriptor: " + declarationDescriptor + " " + assert declaration != null : "Null declaration for descriptor: " + declarationDescriptor + " " +
(declarationDescriptor != null ? DescriptorRenderer.FQNAMES_IN_TYPES.render(declarationDescriptor) : ""); (declarationDescriptor != null ? DescriptorRenderer.FQ_NAMES_IN_TYPES.render(declarationDescriptor) : "");
trace.report(REDECLARATION.on(declaration, declarationDescriptor.getName().asString())); trace.report(REDECLARATION.on(declaration, declarationDescriptor.getName().asString()));
} }
} }
@@ -111,7 +111,7 @@ public class ForLoopConventionsChecker {
if (iteratorResolutionResults.isAmbiguity()) { if (iteratorResolutionResults.isAmbiguity()) {
// StringBuffer stringBuffer = new StringBuffer("Method 'iterator()' is ambiguous for this expression: "); // StringBuffer stringBuffer = new StringBuffer("Method 'iterator()' is ambiguous for this expression: ");
// for (FunctionDescriptor functionDescriptor : iteratorResolutionResults.getResultingCalls()) { // for (FunctionDescriptor functionDescriptor : iteratorResolutionResults.getResultingCalls()) {
// stringBuffer.append(DescriptorRendererImpl.FQNAMES_IN_TYPES.render(functionDescriptor)).append(" "); // stringBuffer.append(DescriptorRenderer.FQ_NAMES_IN_TYPES.render(functionDescriptor)).append(" ");
// } // }
// errorMessage = stringBuffer.toString(); // errorMessage = stringBuffer.toString();
context.trace.report(ITERATOR_AMBIGUITY.on(loopRangeExpression, iteratorResolutionResults.getResultingCalls())); context.trace.report(ITERATOR_AMBIGUITY.on(loopRangeExpression, iteratorResolutionResults.getResultingCalls()));
@@ -149,7 +149,7 @@ public abstract class AbstractSdkAnnotationsValidityTest extends UsefulTestCase
private Void visitDeclaration(@NotNull DeclarationDescriptor descriptor) { private Void visitDeclaration(@NotNull DeclarationDescriptor descriptor) {
List<String> errors = bindingContext.get(JavaBindingContext.LOAD_FROM_JAVA_SIGNATURE_ERRORS, descriptor); List<String> errors = bindingContext.get(JavaBindingContext.LOAD_FROM_JAVA_SIGNATURE_ERRORS, descriptor);
if (errors != null) { if (errors != null) {
this.errors.put(DescriptorRenderer.FQNAMES_IN_TYPES.render(descriptor), errors); this.errors.put(DescriptorRenderer.FQ_NAMES_IN_TYPES.render(descriptor), errors);
} }
return null; return null;
} }
@@ -47,7 +47,7 @@ public class ExpectedLoadErrorsUtil {
for (DeclarationDescriptor descriptor : ContainerUtil.union(expectedErrors.keySet(), actualErrors.keySet())) { for (DeclarationDescriptor descriptor : ContainerUtil.union(expectedErrors.keySet(), actualErrors.keySet())) {
List<String> actual = actualErrors.get(descriptor); List<String> actual = actualErrors.get(descriptor);
List<String> expected = expectedErrors.get(descriptor); List<String> expected = expectedErrors.get(descriptor);
String rendered = DescriptorRenderer.FQNAMES_IN_TYPES.render(descriptor); String rendered = DescriptorRenderer.FQ_NAMES_IN_TYPES.render(descriptor);
assertNotNull("Unexpected load error(s):\n" + actual + "\ncontainer:" + rendered, expected); assertNotNull("Unexpected load error(s):\n" + actual + "\ncontainer:" + rendered, expected);
assertNotNull("Missing load error(s):\n" + expected + "\ncontainer:" + rendered, actual); assertNotNull("Missing load error(s):\n" + expected + "\ncontainer:" + rendered, actual);
@@ -154,7 +154,7 @@ public abstract class AbstractLazyResolveDescriptorRendererTest extends KotlinTe
if (renderedDescriptors.length() != 0) { if (renderedDescriptors.length() != 0) {
renderedDescriptors.append("\n"); renderedDescriptors.append("\n");
} }
renderedDescriptors.append(DescriptorRenderer.FQNAMES_IN_TYPES.render(descriptor)); renderedDescriptors.append(DescriptorRenderer.FQ_NAMES_IN_TYPES.render(descriptor));
} }
Document document = new DocumentImpl(psiFile.getText()); Document document = new DocumentImpl(psiFile.getText());
@@ -120,7 +120,7 @@ public class DescriptorRendererTest extends JetLiteFixture {
if (renderedDescriptors.length() != 0) { if (renderedDescriptors.length() != 0) {
renderedDescriptors.append("\n"); renderedDescriptors.append("\n");
} }
renderedDescriptors.append(DescriptorRenderer.FQNAMES_IN_TYPES.render(descriptor)); renderedDescriptors.append(DescriptorRenderer.FQ_NAMES_IN_TYPES.render(descriptor));
} }
Document document = new DocumentImpl(psiFile.getText()); Document document = new DocumentImpl(psiFile.getText());
@@ -367,6 +367,6 @@ public abstract class ExpectedResolveData {
@NotNull @NotNull
private static String renderNullableDescriptor(@Nullable DeclarationDescriptor d) { private static String renderNullableDescriptor(@Nullable DeclarationDescriptor d) {
return d == null ? "<null>" : DescriptorRenderer.FQNAMES_IN_TYPES.render(d); return d == null ? "<null>" : DescriptorRenderer.FQ_NAMES_IN_TYPES.render(d);
} }
} }
@@ -176,6 +176,6 @@ class LazyJavaAnnotationDescriptor(
override fun toString(): String { override fun toString(): String {
return DescriptorRenderer.FQNAMES_IN_TYPES.renderAnnotation(this) return DescriptorRenderer.FQ_NAMES_IN_TYPES.renderAnnotation(this)
} }
} }
@@ -58,6 +58,6 @@ public class AnnotationDescriptorImpl implements AnnotationDescriptor {
@Override @Override
public String toString() { public String toString() {
return DescriptorRenderer.FQNAMES_IN_TYPES.renderAnnotation(this); return DescriptorRenderer.FQ_NAMES_IN_TYPES.renderAnnotation(this);
} }
} }
@@ -194,7 +194,7 @@ public class TypeParameterDescriptorImpl extends DeclarationDescriptorNonRootImp
@Override @Override
public String toString() { public String toString() {
try { try {
return DescriptorRenderer.FQNAMES_IN_TYPES.render(this); return DescriptorRenderer.FQ_NAMES_IN_TYPES.render(this);
} catch (Exception e) { } catch (Exception e) {
return this.getClass().getName() + "@" + System.identityHashCode(this); return this.getClass().getName() + "@" + System.identityHashCode(this);
} }
@@ -54,7 +54,7 @@ public interface DescriptorRenderer extends Renderer<DeclarationDescriptor> {
.setModifiers() .setModifiers()
.setStartFromName(true).build(); .setStartFromName(true).build();
DescriptorRenderer FQNAMES_IN_TYPES = new DescriptorRendererBuilder().build(); DescriptorRenderer FQ_NAMES_IN_TYPES = new DescriptorRendererBuilder().build();
DescriptorRenderer SHORT_NAMES_IN_TYPES = new DescriptorRendererBuilder().setShortNames(true).build(); DescriptorRenderer SHORT_NAMES_IN_TYPES = new DescriptorRendererBuilder().setShortNames(true).build();
@@ -37,7 +37,7 @@ public class JetFunctionPsiElementCellRenderer extends DefaultPsiElementCellRend
SimpleFunctionDescriptor fd = SimpleFunctionDescriptor fd =
bindingContext.get(BindingContext.FUNCTION, function); bindingContext.get(BindingContext.FUNCTION, function);
assert fd != null; assert fd != null;
return DescriptorRenderer.FQNAMES_IN_TYPES.render(fd); return DescriptorRenderer.FQ_NAMES_IN_TYPES.render(fd);
} }
return super.getElementText(element); return super.getElementText(element);
} }
@@ -301,7 +301,7 @@ public object ShortenReferences {
} }
} }
private fun DeclarationDescriptor.asString() = DescriptorRenderer.FQNAMES_IN_TYPES.render(this) private fun DeclarationDescriptor.asString() = DescriptorRenderer.FQ_NAMES_IN_TYPES.render(this)
//TODO: do we need this "IfNeeded" check? //TODO: do we need this "IfNeeded" check?
private fun addImportIfNeeded(descriptor: DeclarationDescriptor, file: JetFile) { private fun addImportIfNeeded(descriptor: DeclarationDescriptor, file: JetFile) {
@@ -131,7 +131,7 @@ public class MoveDeclarationsOutHelper {
typeString = typeRef.getText(); typeString = typeRef.getText();
} }
else if (!propertyType.isError()) { else if (!propertyType.isError()) {
typeString = DescriptorRenderer.FQNAMES_IN_TYPES.renderType(propertyType); typeString = DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(propertyType);
} }
return JetPsiFactory.createProperty(property.getProject(), property.getName(), typeString, property.isVar(), initializer); return JetPsiFactory.createProperty(property.getProject(), property.getName(), typeString, property.isVar(), initializer);
@@ -146,7 +146,7 @@ public final class DescriptorLookupConverter {
InsertHandler<LookupElement> handler = getDefaultInsertHandler(descriptor); InsertHandler<LookupElement> handler = getDefaultInsertHandler(descriptor);
assert handler != null: assert handler != null:
"Special kotlin handler is expected for function: " + declaration.getText() + "Special kotlin handler is expected for function: " + declaration.getText() +
" and descriptor: " + DescriptorRenderer.FQNAMES_IN_TYPES.render(descriptor); " and descriptor: " + DescriptorRenderer.FQ_NAMES_IN_TYPES.render(descriptor);
return new JavaMethodCallElementWithCustomHandler(declaration).setInsertHandler(handler); return new JavaMethodCallElementWithCustomHandler(declaration).setInsertHandler(handler);
} }
@@ -75,7 +75,7 @@ public class KotlinTypeHierarchyProvider extends JavaTypeHierarchyProvider {
if (functionDescriptor != null) { if (functionDescriptor != null) {
JetType type = functionDescriptor.getReturnType(); JetType type = functionDescriptor.getReturnType();
if (type != null) { if (type != null) {
String returnTypeText = DescriptorRenderer.FQNAMES_IN_TYPES.renderType(type); String returnTypeText = DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(type);
if (returnTypeText.equals(functionName)) { if (returnTypeText.equals(functionName)) {
Collection<JetClassOrObject> classOrObjects = Collection<JetClassOrObject> classOrObjects =
JetClassShortNameIndex.getInstance().get(functionName, project, GlobalSearchScope.allScope(project)); JetClassShortNameIndex.getInstance().get(functionName, project, GlobalSearchScope.allScope(project));
@@ -262,8 +262,8 @@ public class DeprecatedAnnotationVisitor extends AfterAnalysisHighlightingVisito
return "val " + descriptor.getName(); return "val " + descriptor.getName();
} }
else if (descriptor instanceof FunctionDescriptor) { else if (descriptor instanceof FunctionDescriptor) {
return "fun " + descriptor.getName() + DescriptorRenderer.FQNAMES_IN_TYPES.renderFunctionParameters((FunctionDescriptor) descriptor); return "fun " + descriptor.getName() + DescriptorRenderer.FQ_NAMES_IN_TYPES.renderFunctionParameters((FunctionDescriptor) descriptor);
} }
return DescriptorRenderer.FQNAMES_IN_TYPES.render(descriptor); return DescriptorRenderer.FQ_NAMES_IN_TYPES.render(descriptor);
} }
} }
@@ -317,7 +317,7 @@ public class JetLineMarkerProvider implements LineMarkerProvider {
else { else {
JBPopup popup = NavigationUtil.getPsiElementPopup(PsiUtilCore.toPsiElementArray(list), JBPopup popup = NavigationUtil.getPsiElementPopup(PsiUtilCore.toPsiElementArray(list),
new JetFunctionPsiElementCellRenderer(bindingContext), new JetFunctionPsiElementCellRenderer(bindingContext),
DescriptorRenderer.FQNAMES_IN_TYPES.render(descriptor)); DescriptorRenderer.FQ_NAMES_IN_TYPES.render(descriptor));
if (event != null) { if (event != null) {
popup.show(new RelativePoint(event)); popup.show(new RelativePoint(event));
} }
@@ -68,7 +68,7 @@ class VariablesHighlightingVisitor extends AfterAnalysisHighlightingVisitor {
public void visitExpression(@NotNull JetExpression expression) { public void visitExpression(@NotNull JetExpression expression) {
JetType autoCast = bindingContext.get(AUTOCAST, expression); JetType autoCast = bindingContext.get(AUTOCAST, expression);
if (autoCast != null) { if (autoCast != null) {
holder.createInfoAnnotation(expression, "Automatically cast to " + DescriptorRenderer.FQNAMES_IN_TYPES.renderType(autoCast)).setTextAttributes( holder.createInfoAnnotation(expression, "Automatically cast to " + DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(autoCast)).setTextAttributes(
JetHighlightingColors.AUTO_CASTED_VALUE); JetHighlightingColors.AUTO_CASTED_VALUE);
} }
super.visitExpression(expression); super.visitExpression(expression);
@@ -51,7 +51,7 @@ public class InsertExplicitTypeArguments : JetSelfTargetingIntention<JetCallExpr
val typeArgs = types.map { val typeArgs = types.map {
assert(args[it] != null, "there is a null in the type arguments to transform") assert(args[it] != null, "there is a null in the type arguments to transform")
val typeToCompute = DescriptorRenderer.FQNAMES_IN_TYPES.renderType(args[it]!!); val typeToCompute = DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(args[it]!!);
val computedTypeRef = JetPsiFactory.createType(element.getProject(), typeToCompute) val computedTypeRef = JetPsiFactory.createType(element.getProject(), typeToCompute)
ShortenReferences.process(computedTypeRef) ShortenReferences.process(computedTypeRef)
computedTypeRef.getText() computedTypeRef.getText()
@@ -235,7 +235,7 @@ public class SpecifyTypeExplicitlyAction extends PsiElementBaseIntentionAction {
@Override @Override
protected String getResult(JetType element) { protected String getResult(JetType element) {
return DescriptorRenderer.FQNAMES_IN_TYPES.renderType(element); return DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(element);
} }
}; };
@@ -115,7 +115,7 @@ public class DeclarationUtils {
JetType inferredType = getPropertyTypeIfNeeded(property); JetType inferredType = getPropertyTypeIfNeeded(property);
String typeStr = inferredType != null String typeStr = inferredType != null
? DescriptorRenderer.FQNAMES_IN_TYPES.renderType(inferredType) ? DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(inferredType)
: JetPsiUtil.getNullableText(property.getTypeRef()); : JetPsiUtil.getNullableText(property.getTypeRef());
//noinspection ConstantConditions //noinspection ConstantConditions
@@ -149,7 +149,7 @@ public class MemberMatching {
return true; return true;
} }
if (declarationReceiver != null && descriptorReceiver != null) { if (declarationReceiver != null && descriptorReceiver != null) {
return declarationReceiver.getText().equals(DescriptorRenderer.FQNAMES_IN_TYPES.renderType(descriptorReceiver.getType())); return declarationReceiver.getText().equals(DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(descriptorReceiver.getType()));
} }
return false; return false;
} }
@@ -178,7 +178,7 @@ public class MemberMatching {
JetType typeToRender = varargInDeclaration ? descriptorParameter.getVarargElementType() : descriptorParameter.getType(); JetType typeToRender = varargInDeclaration ? descriptorParameter.getVarargElementType() : descriptorParameter.getType();
assert typeToRender != null; assert typeToRender != null;
String descriptorParameterText = DescriptorRenderer.FQNAMES_IN_TYPES.renderType(typeToRender); String descriptorParameterText = DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(typeToRender);
if (!declarationTypeText.equals(descriptorParameterText)) { if (!declarationTypeText.equals(descriptorParameterText)) {
return false; return false;
} }
@@ -227,12 +227,12 @@ public class MemberMatching {
descriptor.getUpperBounds(), new Function<JetType, String>() { descriptor.getUpperBounds(), new Function<JetType, String>() {
@Override @Override
public String fun(JetType type) { public String fun(JetType type) {
return DescriptorRenderer.FQNAMES_IN_TYPES.renderType(type); return DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(type);
} }
})); }));
Set<String> decompiledUpperBounds = decompiledParameterToBounds.get(descriptor.getName()).isEmpty() Set<String> decompiledUpperBounds = decompiledParameterToBounds.get(descriptor.getName()).isEmpty()
? Sets.newHashSet(DescriptorRenderer.FQNAMES_IN_TYPES.renderType(KotlinBuiltIns.getInstance().getDefaultBound())) ? Sets.newHashSet(DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(KotlinBuiltIns.getInstance().getDefaultBound()))
: Sets.newHashSet(decompiledParameterToBounds.get(descriptor.getName())); : Sets.newHashSet(decompiledParameterToBounds.get(descriptor.getName()));
if (!descriptorUpperBounds.equals(decompiledUpperBounds)) { if (!descriptorUpperBounds.equals(decompiledUpperBounds)) {
return false; return false;
@@ -62,10 +62,10 @@ public class MapPlatformClassToKotlinFix extends JetIntentionAction<JetReference
@NotNull @NotNull
@Override @Override
public String getText() { public String getText() {
String platformClassQualifiedName = DescriptorRenderer.FQNAMES_IN_TYPES.renderType(platformClass.getDefaultType()); String platformClassQualifiedName = DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(platformClass.getDefaultType());
return possibleClasses.size() == 1 return possibleClasses.size() == 1
? JetBundle.message("map.platform.class.to.kotlin", platformClassQualifiedName, ? JetBundle.message("map.platform.class.to.kotlin", platformClassQualifiedName,
DescriptorRenderer.FQNAMES_IN_TYPES.renderType(possibleClasses.iterator().next().getDefaultType())) DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(possibleClasses.iterator().next().getDefaultType()))
: JetBundle.message("map.platform.class.to.kotlin.multiple", platformClassQualifiedName); : JetBundle.message("map.platform.class.to.kotlin.multiple", platformClassQualifiedName);
} }
@@ -137,5 +137,5 @@ class ExtractionData(
private fun compareDescriptors(d1: DeclarationDescriptor?, d2: DeclarationDescriptor?): Boolean { private fun compareDescriptors(d1: DeclarationDescriptor?, d2: DeclarationDescriptor?): Boolean {
return d1 == d2 || return d1 == d2 ||
(d1 != null && d2 != null && (d1 != null && d2 != null &&
DescriptorRenderer.FQNAMES_IN_TYPES.render(d1) == DescriptorRenderer.FQNAMES_IN_TYPES.render(d2)) DescriptorRenderer.FQ_NAMES_IN_TYPES.render(d1) == DescriptorRenderer.FQ_NAMES_IN_TYPES.render(d2))
} }
@@ -516,7 +516,7 @@ fun ExtractionDescriptor.validate(): ExtractionDescriptorWithConflicts {
fun ExtractionDescriptor.getFunctionText( fun ExtractionDescriptor.getFunctionText(
withBody: Boolean = true, withBody: Boolean = true,
descriptorRenderer: DescriptorRenderer = DescriptorRenderer.FQNAMES_IN_TYPES descriptorRenderer: DescriptorRenderer = DescriptorRenderer.FQ_NAMES_IN_TYPES
): String { ): String {
return FunctionBuilder().let { builder -> return FunctionBuilder().let { builder ->
builder.modifier(visibility) builder.modifier(visibility)
@@ -237,7 +237,7 @@ public class KotlinInlineValHandler extends InlineActionHandler {
return StringUtil.join(fun.getValueParameters(), new Function<ValueParameterDescriptor, String>() { return StringUtil.join(fun.getValueParameters(), new Function<ValueParameterDescriptor, String>() {
@Override @Override
public String fun(ValueParameterDescriptor descriptor) { public String fun(ValueParameterDescriptor descriptor) {
return descriptor.getName() + ": " + DescriptorRenderer.FQNAMES_IN_TYPES.renderType(descriptor.getType()); return descriptor.getName() + ": " + DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(descriptor.getType());
} }
}, ", "); }, ", ");
} }
@@ -358,7 +358,7 @@ public class KotlinInlineValHandler extends InlineActionHandler {
return StringUtil.join(typeArguments, new Function<JetType, String>() { return StringUtil.join(typeArguments, new Function<JetType, String>() {
@Override @Override
public String fun(JetType type) { public String fun(JetType type) {
return DescriptorRenderer.FQNAMES_IN_TYPES.renderType(type); return DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(type);
} }
}, ", "); }, ", ");
} }
@@ -34,7 +34,6 @@ import com.intellij.refactoring.introduce.inplace.OccurrencesChooser;
import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable; import org.jetbrains.annotations.Nullable;
import org.jetbrains.jet.di.InjectorForMacros; import org.jetbrains.jet.di.InjectorForMacros;
import org.jetbrains.jet.lang.descriptors.DeclarationDescriptor;
import org.jetbrains.jet.lang.psi.*; import org.jetbrains.jet.lang.psi.*;
import org.jetbrains.jet.lang.resolve.BindingContext; import org.jetbrains.jet.lang.resolve.BindingContext;
import org.jetbrains.jet.lang.resolve.BindingTraceContext; import org.jetbrains.jet.lang.resolve.BindingTraceContext;
@@ -251,7 +250,7 @@ public class KotlinIntroduceVariableHandler extends KotlinIntroduceHandlerBase {
public void run() { public void run() {
String variableText = "val " + suggestedNames[0]; String variableText = "val " + suggestedNames[0];
if (noTypeInference) { if (noTypeInference) {
variableText += ": " + DescriptorRenderer.FQNAMES_IN_TYPES.renderType(expressionType); variableText += ": " + DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(expressionType);
} }
variableText += " = "; variableText += " = ";
if (expression instanceof JetParenthesizedExpression) { if (expression instanceof JetParenthesizedExpression) {
@@ -187,7 +187,7 @@ public class BuiltInsReferenceResolver extends AbstractProjectComponent {
JetScope memberScope = getMemberScope(containingDeclaration); JetScope memberScope = getMemberScope(containingDeclaration);
if (memberScope == null) return null; if (memberScope == null) return null;
String renderedOriginal = DescriptorRenderer.FQNAMES_IN_TYPES.render(originalDescriptor); String renderedOriginal = DescriptorRenderer.FQ_NAMES_IN_TYPES.render(originalDescriptor);
Collection<? extends DeclarationDescriptor> descriptors; Collection<? extends DeclarationDescriptor> descriptors;
if (originalDescriptor instanceof ConstructorDescriptor && containingDeclaration instanceof ClassDescriptor) { if (originalDescriptor instanceof ConstructorDescriptor && containingDeclaration instanceof ClassDescriptor) {
descriptors = ((ClassDescriptor) containingDeclaration).getConstructors(); descriptors = ((ClassDescriptor) containingDeclaration).getConstructors();
@@ -196,7 +196,7 @@ public class BuiltInsReferenceResolver extends AbstractProjectComponent {
descriptors = memberScope.getAllDescriptors(); descriptors = memberScope.getAllDescriptors();
} }
for (DeclarationDescriptor member : descriptors) { for (DeclarationDescriptor member : descriptors) {
if (renderedOriginal.equals(DescriptorRenderer.FQNAMES_IN_TYPES.render(member))) { if (renderedOriginal.equals(DescriptorRenderer.FQ_NAMES_IN_TYPES.render(member))) {
return member; return member;
} }
} }
@@ -191,7 +191,7 @@ public class JetStructureViewElement implements StructureViewTreeElement {
FunctionDescriptor functionDescriptor = (FunctionDescriptor) descriptor; FunctionDescriptor functionDescriptor = (FunctionDescriptor) descriptor;
ReceiverParameterDescriptor receiver = functionDescriptor.getReceiverParameter(); ReceiverParameterDescriptor receiver = functionDescriptor.getReceiverParameter();
if (receiver != null) { if (receiver != null) {
textBuilder.append(DescriptorRenderer.FQNAMES_IN_TYPES.renderType(receiver.getType())).append("."); textBuilder.append(DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(receiver.getType())).append(".");
} }
textBuilder.append(functionDescriptor.getName()); textBuilder.append(functionDescriptor.getName());
@@ -202,7 +202,7 @@ public class JetStructureViewElement implements StructureViewTreeElement {
@Override @Override
public String fun(ValueParameterDescriptor valueParameterDescriptor) { public String fun(ValueParameterDescriptor valueParameterDescriptor) {
return valueParameterDescriptor.getName() + ":" + return valueParameterDescriptor.getName() + ":" +
DescriptorRenderer.FQNAMES_IN_TYPES.renderType(valueParameterDescriptor.getType()); DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(valueParameterDescriptor.getType());
} }
}, },
","); ",");
@@ -211,13 +211,13 @@ public class JetStructureViewElement implements StructureViewTreeElement {
JetType returnType = functionDescriptor.getReturnType(); JetType returnType = functionDescriptor.getReturnType();
assert returnType != null; assert returnType != null;
textBuilder.append(":").append(DescriptorRenderer.FQNAMES_IN_TYPES.renderType(returnType)); textBuilder.append(":").append(DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(returnType));
} }
else if (descriptor instanceof VariableDescriptor) { else if (descriptor instanceof VariableDescriptor) {
JetType outType = ((VariableDescriptor) descriptor).getType(); JetType outType = ((VariableDescriptor) descriptor).getType();
textBuilder = new StringBuilder(descriptor.getName().asString()); textBuilder = new StringBuilder(descriptor.getName().asString());
textBuilder.append(":").append(DescriptorRenderer.FQNAMES_IN_TYPES.renderType(outType)); textBuilder.append(":").append(DescriptorRenderer.FQ_NAMES_IN_TYPES.renderType(outType));
} }
else if (descriptor instanceof ClassDescriptor) { else if (descriptor instanceof ClassDescriptor) {
textBuilder = new StringBuilder(descriptor.getName().asString()); textBuilder = new StringBuilder(descriptor.getName().asString());
@@ -227,7 +227,7 @@ public class JetStructureViewElement implements StructureViewTreeElement {
.append(")"); .append(")");
} }
else { else {
return DescriptorRenderer.FQNAMES_IN_TYPES.render(descriptor); return DescriptorRenderer.FQ_NAMES_IN_TYPES.render(descriptor);
} }
return textBuilder.toString(); return textBuilder.toString();