From af17a4e961248b5c3c0f68837149e7d4bb1b7061 Mon Sep 17 00:00:00 2001
From: Mikhail Glukhikh <mikhail.glukhikh@jetbrains.com>
Date: Thu, 9 Aug 2018 14:55:09 +0300
Subject: [PATCH] For each parameter unused: do not report with explicit
 parameter

In this case we are duplicating compiler warning.
Related to KT-22068
---
 .../idea/inspections/ForEachParameterNotUsedInspection.kt | 1 +
 .../forEachParameterNotUsed/inspectionData/expected.xml   | 8 --------
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/idea/src/org/jetbrains/kotlin/idea/inspections/ForEachParameterNotUsedInspection.kt b/idea/src/org/jetbrains/kotlin/idea/inspections/ForEachParameterNotUsedInspection.kt
index 3235928fd98..e9c88361439 100644
--- a/idea/src/org/jetbrains/kotlin/idea/inspections/ForEachParameterNotUsedInspection.kt
+++ b/idea/src/org/jetbrains/kotlin/idea/inspections/ForEachParameterNotUsedInspection.kt
@@ -34,6 +34,7 @@ class ForEachParameterNotUsedInspection : AbstractKotlinInspection() {
             when (it.getCallableDescriptor()?.fqNameOrNull()) {
                 COLLECTIONS_FOREACH_FQNAME, SEQUENCES_FOREACH_FQNAME -> {
                     val lambda = it.lambdaArguments.singleOrNull()?.getLambdaExpression() ?: return@callExpressionVisitor
+                    if (lambda.functionLiteral.arrow != null) return@callExpressionVisitor
                     val descriptor = lambda.analyze()[BindingContext.FUNCTION, lambda.functionLiteral] ?: return@callExpressionVisitor
                     val iterableParameter = descriptor.valueParameters.singleOrNull() ?: return@callExpressionVisitor
 
diff --git a/idea/testData/inspections/forEachParameterNotUsed/inspectionData/expected.xml b/idea/testData/inspections/forEachParameterNotUsed/inspectionData/expected.xml
index 4d2af48e66b..0c061acb50f 100644
--- a/idea/testData/inspections/forEachParameterNotUsed/inspectionData/expected.xml
+++ b/idea/testData/inspections/forEachParameterNotUsed/inspectionData/expected.xml
@@ -7,14 +7,6 @@
     <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Iterated elements are not used in forEach</problem_class>
     <description>Loop parameter 'it' is unused</description>
   </problem>
-  <problem>
-    <file>test.kt</file>
-    <line>4</line>
-    <module>light_idea_test_case</module>
-    <entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
-    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Iterated elements are not used in forEach</problem_class>
-    <description>Loop parameter 'item' is unused</description>
-  </problem>
   <problem>
     <file>test.kt</file>
     <line>7</line>