JS: replace noImpl with definedExternally in tests

js/js.translator/testData/box/native/castToNativeClassChecked.kt

@@ -4,7 +4,7 @@
 }
 
 @native class A(x: String)  {
-    fun foo(): String = noImpl
+    fun foo(): String = definedExternally
 }
 
 fun createObject(): Any = A("fail: CCE not thrown")

js/js.translator/testData/box/native/castToNativeInterface.kt

@@ -4,7 +4,7 @@
 }
 
 @native class A(x: String) : I {
-    override fun foo(): String = noImpl
+    override fun foo(): String = definedExternally
 }
 
 fun createObject(): Any = A("OK")

js/js.translator/testData/box/native/castToTypeParamBoundedByNativeInterface.kt

@@ -10,7 +10,7 @@ interface J {
 @native abstract class B() : I
 
 @native class A(x: String) : B() {
-    override fun foo(): String = noImpl
+    override fun foo(): String = definedExternally
 }
 
 fun createObject(): Any = A("OK")

js/js.translator/testData/box/native/class.kt

@@ -1,8 +1,8 @@
 package foo
 
 external class A(b: Int) {
-    fun g(): Int = noImpl
-    fun m(): Int = noImpl
+    fun g(): Int = definedExternally
+    fun m(): Int = definedExternally
 }
 
 

js/js.translator/testData/box/native/classObject.kt

@@ -5,7 +5,7 @@ external class A(c: Int) {
 
     companion object {
         val g: Int
-        val c: String = noImpl
+        val c: String = definedExternally
     }
 }
 

js/js.translator/testData/box/native/inheritanceFromNativeClass.kt

@@ -3,13 +3,13 @@ package foo
 internal external open class A(a: Int) {
     val a: Int
 
-    fun g(): Int = noImpl
-    fun m(): Int = noImpl
+    fun g(): Int = definedExternally
+    fun m(): Int = definedExternally
 
-    public open fun foo(i: Int): String = noImpl
-    public fun boo(i: Int): String = noImpl
+    public open fun foo(i: Int): String = definedExternally
+    public fun boo(i: Int): String = definedExternally
     @JsName("bar")
-    open fun baz(i: Int): String = noImpl
+    open fun baz(i: Int): String = definedExternally
 }
 
 internal class B(val b: Int) : A(b / 2) {

js/js.translator/testData/box/native/kt2209.kt

@@ -12,7 +12,7 @@ external interface LastError {
     val message: String
 }
 
-external val chrome: Chrome = noImpl
+external val chrome: Chrome = definedExternally
 
 fun box(): String {
     val lastError = chrome.extension.lastError?.message

js/js.translator/testData/box/native/nativeClassAsReifiedTypeArgument.kt

@@ -7,7 +7,7 @@ inline fun <reified T : Any> log(x: T) {
 }
 
 @native class C {
-    override fun toString() = noImpl
+    override fun toString() = definedExternally
 }
 
 fun box(): String {

js/js.translator/testData/box/native/nativeGetterAndNativeSetter.kt

@@ -3,34 +3,34 @@ package foo
 @JsName("Object")
 external class JsObject {
     @nativeGetter
-    operator fun get(a: String): Any? = noImpl
+    operator fun get(a: String): Any? = definedExternally
 
     @nativeSetter
-    operator fun set(a: String, v: Any?): Unit = noImpl
+    operator fun set(a: String, v: Any?): Unit = definedExternally
 
     @nativeGetter
-    fun take(a: Int): Any? = noImpl
+    fun take(a: Int): Any? = definedExternally
 
     @nativeSetter
-    fun put(a: Int, v: Any?): Unit = noImpl
+    fun put(a: Int, v: Any?): Unit = definedExternally
 }
 
 @nativeGetter
-operator fun JsObject.get(a: Int): Any? = noImpl
+operator fun JsObject.get(a: Int): Any? = definedExternally
 
 @nativeSetter
-operator fun JsObject.set(a: Int, v: Any?): Unit = noImpl
+operator fun JsObject.set(a: Int, v: Any?): Unit = definedExternally
 
 @nativeGetter
-fun JsObject.take(a: String): Any? = noImpl
+fun JsObject.take(a: String): Any? = definedExternally
 
 @nativeSetter
-fun JsObject.put(a: String, v: Any?): Unit = noImpl
+fun JsObject.put(a: String, v: Any?): Unit = definedExternally
 
 
 object t{}
 
-external fun getTestObject(): JsObject = noImpl
+external fun getTestObject(): JsObject = definedExternally
 
 fun test(obj: JsObject, key: String, oldValue: Any?, newValue: Any) {
     assertEquals(oldValue, obj[key])

js/js.translator/testData/box/native/nativeInvoke.kt

@@ -2,17 +2,17 @@ package foo
 
 external class Function(vararg argsAndCode: String) {
     @nativeInvoke
-    operator fun invoke(a: Any?): Any? = noImpl
+    operator fun invoke(a: Any?): Any? = definedExternally
 
     @nativeInvoke
-    fun baz(a: Any?, b: Any?): Any? = noImpl
+    fun baz(a: Any?, b: Any?): Any? = definedExternally
 }
 
 @nativeInvoke
-operator fun Function.invoke(a: Any?, b: Any?): Any? = noImpl
+operator fun Function.invoke(a: Any?, b: Any?): Any? = definedExternally
 
 @nativeInvoke
-fun Function.bar(a: Any?, b: Any?): Any? = noImpl
+fun Function.bar(a: Any?, b: Any?): Any? = definedExternally
 
 object t{}
 

js/js.translator/testData/box/native/nestedElements.kt

@@ -82,33 +82,33 @@ fun box(): String {
 
 external object Object {
     object Object {
-        val a: String = noImpl
-        var b: String = noImpl
-        fun test(): Int = noImpl
+        val a: String = definedExternally
+        var b: String = definedExternally
+        fun test(): Int = definedExternally
 
         @JsName("AnotherClass")
         class Class(a: String) {
             val a: String
-            var b: String = noImpl
-            fun test(): Int = noImpl
+            var b: String = definedExternally
+            fun test(): Int = definedExternally
 
             companion object {
-                val a: String = noImpl
-                var b: String = noImpl
-                fun test(): Int = noImpl
+                val a: String = definedExternally
+                var b: String = definedExternally
+                fun test(): Int = definedExternally
             }
         }
     }
 
     class Class(a: String) {
         val a: String
-        var b: String = noImpl
-        fun test(): Int = noImpl
+        var b: String = definedExternally
+        fun test(): Int = definedExternally
 
         companion object {
-            val a: String = noImpl
-            var b: String = noImpl
-            fun test(): Int = noImpl
+            val a: String = definedExternally
+            var b: String = definedExternally
+            fun test(): Int = definedExternally
         }
     }
 
@@ -118,34 +118,34 @@ external object Object {
         fun test(): Int
 
         companion object {
-            val a: String = noImpl
-            var b: String = noImpl
-            fun test(): Int = noImpl
+            val a: String = definedExternally
+            var b: String = definedExternally
+            fun test(): Int = definedExternally
         }
     }
 
-    val a: Trait = noImpl
-    var b: String = noImpl
-    fun test(): Int = noImpl
+    val a: Trait = definedExternally
+    var b: String = definedExternally
+    fun test(): Int = definedExternally
 }
 
 @JsName("SomeClass")
 external class Class {
     object Object {
-        val a: String = noImpl
-        var b: String = noImpl
-        fun test(): Int = noImpl
+        val a: String = definedExternally
+        var b: String = definedExternally
+        fun test(): Int = definedExternally
     }
 
     class Class(a: String) {
         val a: String
-        var b: String = noImpl
-        fun test(): Int = noImpl
+        var b: String = definedExternally
+        fun test(): Int = definedExternally
 
         companion object {
-            val a: String = noImpl
-            var b: String = noImpl
-            fun test(): Int = noImpl
+            val a: String = definedExternally
+            var b: String = definedExternally
+            fun test(): Int = definedExternally
         }
     }
 
@@ -155,37 +155,37 @@ external class Class {
         fun test(): Int
 
         companion object {
-            val a: String = noImpl
-            var b: String = noImpl
-            fun test(): Int = noImpl
+            val a: String = definedExternally
+            var b: String = definedExternally
+            fun test(): Int = definedExternally
         }
     }
 
     companion object {
         @JsName("aaa")
-        val a: Trait = noImpl
-        var b: String = noImpl
-        fun test(): Int = noImpl
+        val a: Trait = definedExternally
+        var b: String = definedExternally
+        fun test(): Int = definedExternally
     }
 }
 
 external interface Trait {
     @JsName("SomeObject")
     object Object {
-        val a: String = noImpl
-        var b: String = noImpl
-        fun test(): Int = noImpl
+        val a: String = definedExternally
+        var b: String = definedExternally
+        fun test(): Int = definedExternally
     }
 
     class Class(a: String) {
         val a: String
-        var b: String = noImpl
-        fun test(): Int = noImpl
+        var b: String = definedExternally
+        fun test(): Int = definedExternally
 
         companion object {
-            val a: String = noImpl
-            var b: String = noImpl
-            fun test(): Int = noImpl
+            val a: String = definedExternally
+            var b: String = definedExternally
+            fun test(): Int = definedExternally
         }
     }
 
@@ -196,15 +196,15 @@ external interface Trait {
         fun test(): Int
 
         companion object {
-            val a: String = noImpl
-            var b: String = noImpl
-            fun test(): Int = noImpl
+            val a: String = definedExternally
+            var b: String = definedExternally
+            fun test(): Int = definedExternally
         }
     }
 
     companion object {
-        val a: Trait = noImpl
-        var b: String = noImpl
-        fun test(): Int = noImpl
+        val a: Trait = definedExternally
+        var b: String = definedExternally
+        fun test(): Int = definedExternally
     }
 }

js/js.translator/testData/box/native/overrideNativeOverloadedFunction.kt

@@ -1,7 +1,7 @@
 external open class A {
-    open fun f(x: Int): String = noImpl
+    open fun f(x: Int): String = definedExternally
 
-    open fun f(x: String): String = noImpl
+    open fun f(x: String): String = definedExternally
 }
 
 class B : A() {

js/js.translator/testData/box/native/passExtLambdaFromNative.kt

@@ -9,7 +9,7 @@ internal class B {
 }
 
 
-internal external fun nativeBox(b: B): String = noImpl
+internal external fun nativeBox(b: B): String = definedExternally
 
 fun box(): String {
     val r = nativeBox(B())

js/js.translator/testData/box/native/passExtLambdaToNative.kt

@@ -4,7 +4,7 @@ external class A(v: String) {
     val v: String
 }
 
-external fun bar(a: A, extLambda: A.(Int, String) -> String): String = noImpl
+external fun bar(a: A, extLambda: A.(Int, String) -> String): String = definedExternally
 
 fun box(): String {
     val a = A("test")

js/js.translator/testData/box/native/passMemberOrExtFromNative.kt

@@ -3,7 +3,7 @@ package foo
 external class A(v: String) {
     val v: String
 
-    fun m(i:Int, s:String): String = noImpl
+    fun m(i:Int, s:String): String = definedExternally
 }
 
 fun bar(a: A, extLambda: A.(Int, String) -> String): String = a.(extLambda)(4, "boo")

js/js.translator/testData/box/native/passMemberOrExtToNative.kt

@@ -8,7 +8,7 @@ class B(v: String): A(v) {
     override fun m(i:Int, s:String): String = "B.m ${this.v} $i $s"
 }
 
-external fun bar(a: A, extLambda: A.(Int, String) -> String): String = noImpl
+external fun bar(a: A, extLambda: A.(Int, String) -> String): String = definedExternally
 
 fun A.topLevelExt(i:Int, s:String): String = "A::topLevelExt ${this.v} $i $s"
 

js/js.translator/testData/box/native/passTopLevelFunctionFromNative.kt

@@ -1,6 +1,6 @@
 package foo
 
-external fun nativeFun(i:Int, s:String): String = noImpl
+external fun nativeFun(i:Int, s:String): String = definedExternally
 
 fun bar(funRef: (Int, String) -> String): String = funRef(4, "boo")
 

js/js.translator/testData/box/native/passTopLevelOrLocalFunctionToNative.kt

@@ -1,6 +1,6 @@
 package foo
 
-external fun run(i:Int, s:String, funRef: (Int, String) -> String): String = noImpl
+external fun run(i:Int, s:String, funRef: (Int, String) -> String): String = definedExternally
 
 fun funTopLevel(i:Int, s:String): String = "funTopLevel $i $s"
 

js/js.translator/testData/box/native/print.kt

@@ -22,7 +22,7 @@ val EXPECTED_NEWLINE_FOR_EACH = """Hello
 
 """
 
-external var buffer: String = noImpl
+external var buffer: String = definedExternally
 
 fun test(expected: String, initCode: String, getResult: () -> String) {
     buffer = ""

js/js.translator/testData/box/native/simple.kt

@@ -1,5 +1,5 @@
 package foo
 
-external fun returnFalse(): Boolean = noImpl
+external fun returnFalse(): Boolean = definedExternally
 
 fun box() = if (!returnFalse()) "OK" else "fail"

js/js.translator/testData/box/native/simpleUndefined.kt

@@ -1,6 +1,6 @@
 package foo
 
-external val c: Any? = noImpl
+external val c: Any? = definedExternally
 
 fun box(): String {
     if (c != null) return "fail1"

js/js.translator/testData/box/native/vararg.kt

@@ -1,12 +1,12 @@
 package foo
 
-external fun paramCount(vararg a: Int): Int = noImpl
+external fun paramCount(vararg a: Int): Int = definedExternally
 
 @JsName("paramCount")
-external fun anotherParamCount(vararg a: Int): Int = noImpl
+external fun anotherParamCount(vararg a: Int): Int = definedExternally
 
 @JsName("paramCount")
-external fun <T> genericParamCount(vararg a: T): Int = noImpl
+external fun <T> genericParamCount(vararg a: T): Int = definedExternally
 
 // test spread operator
 fun count(vararg a: Int) = paramCount(*a)
@@ -14,19 +14,19 @@ fun count(vararg a: Int) = paramCount(*a)
 // test spread operator
 fun anotherCount(vararg a: Int) = anotherParamCount(*a)
 
-external fun test3(bar: Bar, dummy: Int, vararg args: Int): Boolean = noImpl
+external fun test3(bar: Bar, dummy: Int, vararg args: Int): Boolean = definedExternally
 
-external class Bar(size: Int, order: Int = noImpl) {
+external class Bar(size: Int, order: Int = definedExternally) {
     val size: Int
-    fun test(order: Int, dummy: Int, vararg args: Int): Boolean = noImpl
+    fun test(order: Int, dummy: Int, vararg args: Int): Boolean = definedExternally
     companion object {
-        fun startNewTest(): Boolean = noImpl
-        var hasOrderProblem: Boolean = noImpl
+        fun startNewTest(): Boolean = definedExternally
+        var hasOrderProblem: Boolean = definedExternally
     }
 }
 
 external object obj {
-    fun test(size: Int, vararg args: Int): Boolean = noImpl
+    fun test(size: Int, vararg args: Int): Boolean = definedExternally
 }
 
 fun spreadInMethodCall(size: Int, vararg args: Int) = Bar(size).test(0, 1, *args)
@@ -35,7 +35,7 @@ fun spreadInObjectMethodCall(size: Int, vararg args: Int) = obj.test(size, *args
 
 fun spreadInPackageMethodCall(size: Int, vararg args: Int) = test3(Bar(size), 1, *args)
 
-external fun testNativeVarargWithFunLit(vararg args: Int, f: (a: IntArray) -> Boolean): Boolean = noImpl
+external fun testNativeVarargWithFunLit(vararg args: Int, f: (a: IntArray) -> Boolean): Boolean = definedExternally
 
 fun testSpreadOperatorWithSafeCall(a: Bar?, expected: Boolean?, vararg args: Int): Boolean {
     return a?.test(0, 1, *args) == expected
@@ -50,11 +50,11 @@ fun testCallOrder(vararg args: Int) =
         Bar(args.size, 0).test(1, 1, *args) && Bar(args.size, 2).test(3, 1, *args) &&
         !Bar.hasOrderProblem
 
-external fun sumOfParameters(x: Int, y: Int, vararg a: Int): Int = noImpl
+external fun sumOfParameters(x: Int, y: Int, vararg a: Int): Int = definedExternally
 
-external fun sumFunValuesOnParameters(x: Int, y: Int, vararg a: Int, f: (Int) -> Int): Int = noImpl
+external fun sumFunValuesOnParameters(x: Int, y: Int, vararg a: Int, f: (Int) -> Int): Int = definedExternally
 
-external fun <T> idArrayVarArg(vararg a: Array<T>): Array<T> = noImpl
+external fun <T> idArrayVarArg(vararg a: Array<T>): Array<T> = definedExternally
 
 fun box(): String {
     if (paramCount() != 0)