azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[K/N] Fix OS file handles leak in DependencyProcessor

Browse Source 
Merge-request: KT-MR-12705
Merged-by: Vladimir Sukharev <Vladimir.Sukharev@jetbrains.com>
This commit is contained in:
Vladimir Sukharev
2023-10-26 20:03:34 +00:00
committed by Space Team
parent f82c3c3bf7
commit aebbdeaf92
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
native/utils/src/org/jetbrains/kotlin/konan/util/DependencyProcessor.kt
+9 -7
View File
@@ -295,14 +295,16 @@ class DependencyProcessor(
if (remoteDependencies.isEmpty()) { return } if (remoteDependencies.isEmpty()) { return }
synchronized(lock) { synchronized(lock) {
RandomAccessFile(lockFile, "rw").channel.lock().use { RandomAccessFile(lockFile, "rw").use {
remoteDependencies.forEach { (dependency, candidate) -> it.channel.lock().use {
val baseUrl = when (candidate) { remoteDependencies.forEach { (dependency, candidate) ->
DependencySource.Remote.Public -> dependenciesUrl val baseUrl = when (candidate) {
DependencySource.Remote.Internal -> InternalServer.url DependencySource.Remote.Public -> dependenciesUrl
DependencySource.Remote.Internal -> InternalServer.url
}
// TODO: consider using different caches for different remotes.
downloadDependency(dependency, baseUrl)
} }
// TODO: consider using different caches for different remotes.
downloadDependency(dependency, baseUrl)
} }
} }
} }