"Remove redundant let" inspection: do not report for long call chains #KT-26289 Fixed

idea/testData/inspectionsLocal/replaceSingleLineLet/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.intentions.ReplaceSingleLineLetInspection

idea/testData/inspectionsLocal/replaceSingleLineLet/callChain.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }.filter { it > 2 }.let<caret> { println(it) }
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/callChain.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    println(list.filter { it > 1 }.filter { it > 2 })
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/callChain2.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }.filter { it > 2 }
+        .let<caret> { println(it) }
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/callChain2.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    println(list.filter { it > 1 }.filter { it > 2 })
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/callChain3.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }.filter { it > 2 }.let<caret> {
+        println(it)
+    }
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/callChain3.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    println(list.filter { it > 1 }.filter { it > 2 })
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/callChainWithLineBreak.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }
+        .filter { it > 2 }
+        .let<caret> { println(it) }
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/longCallChain.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }.filter { it > 2 }.filter { it > 3 }.let<caret> { println(it) }
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/noReceiver.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun String.test(): Int {
+    return let<caret> {
+        it.length
+    }
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/noReceiver.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun String.test(): Int {
+    return length
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/simple.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun test(s: String?): Int? {
+    return s?.let<caret> {
+        it.length
+    }
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/simple.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun test(s: String?): Int? {
+    return s?.length
+}