Minor: remove unused parameter

This commit is contained in:
Pavel V. Talanov
2015-05-14 13:47:22 +03:00
parent 257b8f31e7
commit ade898775c
7 changed files with 18 additions and 18 deletions
@@ -34,8 +34,7 @@ public class ImportDirectiveProcessor(
importDirective: JetImportDirective, importDirective: JetImportDirective,
moduleDescriptor: ModuleDescriptor, moduleDescriptor: ModuleDescriptor,
trace: BindingTrace, trace: BindingTrace,
lookupMode: QualifiedExpressionResolver.LookupMode, lookupMode: QualifiedExpressionResolver.LookupMode
allowClassesFromDefaultPackage: Boolean
): JetScope { ): JetScope {
if (importDirective.isAbsoluteInRootPackage()) { if (importDirective.isAbsoluteInRootPackage()) {
trace.report(Errors.UNSUPPORTED.on(importDirective, "TypeHierarchyResolver")) // TODO trace.report(Errors.UNSUPPORTED.on(importDirective, "TypeHierarchyResolver")) // TODO
@@ -76,10 +76,9 @@ public class QualifiedExpressionResolver {
@NotNull JetImportDirective importDirective, @NotNull JetImportDirective importDirective,
@NotNull ModuleDescriptor moduleDescriptor, @NotNull ModuleDescriptor moduleDescriptor,
@NotNull BindingTrace trace, @NotNull BindingTrace trace,
@NotNull LookupMode lookupMode, @NotNull LookupMode lookupMode
boolean allowClassesFromDefaultPackage
) { ) {
return importDirectiveProcessor.processImportReference(importDirective, moduleDescriptor, trace, lookupMode, allowClassesFromDefaultPackage); return importDirectiveProcessor.processImportReference(importDirective, moduleDescriptor, trace, lookupMode);
} }
@NotNull @NotNull
@@ -76,10 +76,10 @@ class LazyFileScope private constructor(
val packageFragment = resolveSession.getPackageFragment(file.getPackageFqName()) val packageFragment = resolveSession.getPackageFragment(file.getPackageFqName())
.sure { "Could not find fragment ${file.getPackageFqName()} for file ${file.getName()}" } .sure { "Could not find fragment ${file.getPackageFqName()} for file ${file.getName()}" }
val aliasImportResolver = LazyImportResolver(resolveSession, moduleDescriptor, AliasImportsIndexed(imports), traceForImportResolve, true) val aliasImportResolver = LazyImportResolver(resolveSession, moduleDescriptor, AliasImportsIndexed(imports), traceForImportResolve)
val allUnderImportResolver = LazyImportResolver(resolveSession, moduleDescriptor, AllUnderImportsIndexed(imports), traceForImportResolve, true) val allUnderImportResolver = LazyImportResolver(resolveSession, moduleDescriptor, AllUnderImportsIndexed(imports), traceForImportResolve)
val defaultAliasImportResolver = LazyImportResolver(resolveSession, moduleDescriptor, AliasImportsIndexed(defaultImports), traceForDefaultImportResolve, false) val defaultAliasImportResolver = LazyImportResolver(resolveSession, moduleDescriptor, AliasImportsIndexed(defaultImports), traceForDefaultImportResolve)
val defaultAllUnderImportResolver = LazyImportResolver(resolveSession, moduleDescriptor, AllUnderImportsIndexed(defaultImports), traceForDefaultImportResolve, false) val defaultAllUnderImportResolver = LazyImportResolver(resolveSession, moduleDescriptor, AllUnderImportsIndexed(defaultImports), traceForDefaultImportResolve)
val scopeChain = ArrayList<JetScope>() val scopeChain = ArrayList<JetScope>()
@@ -67,8 +67,7 @@ class LazyImportResolver(
val resolveSession: ResolveSession, val resolveSession: ResolveSession,
val moduleDescriptor: ModuleDescriptor, val moduleDescriptor: ModuleDescriptor,
val indexedImports: IndexedImports, val indexedImports: IndexedImports,
private val traceForImportResolve: BindingTrace, private val traceForImportResolve: BindingTrace
private val includeRootPackageClasses: Boolean
) { ) {
private val importedScopesProvider = resolveSession.getStorageManager().createMemoizedFunction { private val importedScopesProvider = resolveSession.getStorageManager().createMemoizedFunction {
directive: JetImportDirective -> ImportDirectiveResolveCache(directive) directive: JetImportDirective -> ImportDirectiveResolveCache(directive)
@@ -99,7 +98,7 @@ class LazyImportResolver(
try { try {
val resolver = resolveSession.getQualifiedExpressionResolver() val resolver = resolveSession.getQualifiedExpressionResolver()
val directiveImportScope = resolver.processImportReference( val directiveImportScope = resolver.processImportReference(
directive, moduleDescriptor, traceForImportResolve, mode, includeRootPackageClasses) directive, moduleDescriptor, traceForImportResolve, mode)
val descriptors = if (directive.isAllUnder()) emptyList() else directiveImportScope.getAllDescriptors() val descriptors = if (directive.isAllUnder()) emptyList() else directiveImportScope.getAllDescriptors()
if (mode == LookupMode.EVERYTHING) { if (mode == LookupMode.EVERYTHING) {
@@ -35,7 +35,10 @@ import org.jetbrains.kotlin.idea.project.TargetPlatformDetector
import org.jetbrains.kotlin.idea.util.ProjectRootsUtil import org.jetbrains.kotlin.idea.util.ProjectRootsUtil
import org.jetbrains.kotlin.name.FqName import org.jetbrains.kotlin.name.FqName
import org.jetbrains.kotlin.psi.* import org.jetbrains.kotlin.psi.*
import org.jetbrains.kotlin.resolve.* import org.jetbrains.kotlin.resolve.BindingContext
import org.jetbrains.kotlin.resolve.BindingTraceContext
import org.jetbrains.kotlin.resolve.ImportPath
import org.jetbrains.kotlin.resolve.QualifiedExpressionResolver
import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
import org.jetbrains.kotlin.resolve.scopes.JetScope import org.jetbrains.kotlin.resolve.scopes.JetScope
import org.jetbrains.kotlin.utils.keysToMap import org.jetbrains.kotlin.utils.keysToMap
@@ -222,12 +225,12 @@ private class ResolutionFacadeImpl(private val project: Project, private val cac
return cache.getLazyResolveSession(file).getScopeProvider().getFileScope(file) return cache.getLazyResolveSession(file).getScopeProvider().getFileScope(file)
} }
override fun resolveImportReference(moduleDescriptor: ModuleDescriptor, fqName: FqName, isDefaultImport: Boolean): Collection<DeclarationDescriptor> { override fun resolveImportReference(moduleDescriptor: ModuleDescriptor, fqName: FqName): Collection<DeclarationDescriptor> {
val importDirective = JetPsiFactory(project).createImportDirective(ImportPath(fqName, false)) val importDirective = JetPsiFactory(project).createImportDirective(ImportPath(fqName, false))
val resolveSession = cache.getLazyResolveSession(moduleDescriptor) val resolveSession = cache.getLazyResolveSession(moduleDescriptor)
val resolver = resolveSession.getQualifiedExpressionResolver() val resolver = resolveSession.getQualifiedExpressionResolver()
return resolver.processImportReference( return resolver.processImportReference(
importDirective, moduleDescriptor, BindingTraceContext(), QualifiedExpressionResolver.LookupMode.EVERYTHING, !isDefaultImport).getAllDescriptors() importDirective, moduleDescriptor, BindingTraceContext(), QualifiedExpressionResolver.LookupMode.EVERYTHING).getAllDescriptors()
} }
override fun <T> get(extension: CacheExtension<T>): T { override fun <T> get(extension: CacheExtension<T>): T {
@@ -38,7 +38,7 @@ public trait ResolutionFacade {
public fun getFileTopLevelScope(file: JetFile): JetScope public fun getFileTopLevelScope(file: JetFile): JetScope
public fun resolveImportReference(moduleDescriptor: ModuleDescriptor, fqName: FqName, isDefaultImport: Boolean = false): Collection<DeclarationDescriptor> public fun resolveImportReference(moduleDescriptor: ModuleDescriptor, fqName: FqName): Collection<DeclarationDescriptor>
public fun findModuleDescriptor(element: JetElement): ModuleDescriptor public fun findModuleDescriptor(element: JetElement): ModuleDescriptor
@@ -34,9 +34,9 @@ public fun JetDeclaration.resolveToDescriptor(): DeclarationDescriptor {
return getResolutionFacade().resolveToDescriptor(this) return getResolutionFacade().resolveToDescriptor(this)
} }
public fun JetFile.resolveImportReference(fqName: FqName, isDefaultImport: Boolean = false): Collection<DeclarationDescriptor> { public fun JetFile.resolveImportReference(fqName: FqName): Collection<DeclarationDescriptor> {
val facade = getResolutionFacade() val facade = getResolutionFacade()
return facade.resolveImportReference(facade.findModuleDescriptor(this), fqName, isDefaultImport) return facade.resolveImportReference(facade.findModuleDescriptor(this), fqName)
} }
//NOTE: the difference between analyze and analyzeFully is 'intentionally' unclear //NOTE: the difference between analyze and analyzeFully is 'intentionally' unclear