azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

IR: add an emptiness check to all unsigned until loops

Browse Source 
Unlike signed integers, a larger unsigned type does not mean a lower
minimum value, so `x - 1` can overflow even if `x` is casted to a larger
type.

 #KT-42186 Fixed
This commit is contained in:
pyos
2020-10-05 15:20:57 +02:00
committed by Alexander Udalov
parent 4a03006162
commit adcbfc7b4c
10 changed files with 283 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/stdlib/test/ranges/RangeIterationTest.kt
+14
View File
@@ -467,12 +467,26 @@ public class RangeIterationTest : RangeIterationTestBase() {
}
@Test fun overflowZeroToMinValue() {
doTest(0.toByte()..MinB step 3, 0, MinB.toInt(), 3, listOf())
doTest(0.toShort()..MinS step 3, 0, MinS.toInt(), 3, listOf())
doTest(0..MinI step 3, 0, MinI, 3, listOf())
doTest(0L..MinL step 3, 0, MinL, 3L, listOf())
doTest(0.toByte() until MinB step 3, 0, MinB.toInt() - 1, 3, listOf())
doTest(0.toShort() until MinS step 3, 0, MinS.toInt() - 1, 3, listOf())
doTest(0 until MinI step 3, 1, 0, 3, listOf())
doTest(0L until MinL step 3, 1L, 0L, 3L, listOf())
// 1u as used as a start since min value is 0u for unsigned types
doTest(1u.toUByte()..MinUB step 3, 1u, MinUB.toUInt(), 3, listOf())
doTest(1u.toUShort()..MinUS step 3, 1u, MinUS.toUInt(), 3, listOf())
doTest(1u..MinUI step 3, 1u, MinUI, 3, listOf())
doTest(1uL..MinUL step 3, 1u, MinUL, 3L, listOf())
doTest(1u.toUByte() until MinUB step 3, MaxUI, MinUI, 3, listOf())
doTest(1u.toUShort() until MinUS step 3, MaxUI, MinUI, 3, listOf())
doTest(1u until MinUI step 3, MaxUI, MinUI, 3, listOf())
doTest(1uL until MinUL step 3, MaxUL, MinUL, 3L, listOf())
}
@Test fun progressionDownToMinValue() {