Refactoring: make "replace call with binary operator" an inspection

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.conventionNameCalls.ReplaceCallWithBinaryOperatorInspection

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/divSanityTest.kt

@@ -0,0 +1,8 @@
+// FIX: Replace with '/' operator
+fun test() {
+    class Test {
+        operator fun div(a: Int): Test = Test()
+    }
+    val test = Test()
+    test.<caret>div(1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/divSanityTest.kt.after

@@ -0,0 +1,8 @@
+// FIX: Replace with '/' operator
+fun test() {
+    class Test {
+        operator fun div(a: Int): Test = Test()
+    }
+    val test = Test()
+    test / 1
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/equals.kt

@@ -0,0 +1,3 @@
+// FIX: Replace with '==' operator
+
+val x = 2.<caret>equals(2)

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/equals.kt.after

@@ -0,0 +1,3 @@
+// FIX: Replace with '==' operator
+
+val x = 2 == 2

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/equalsCompareTo.kt

@@ -0,0 +1,3 @@
+// PROBLEM: none
+
+val x = 2.compareTo<caret>(2) == 0

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/equalsExtensionFunction.kt

@@ -0,0 +1,11 @@
+// PROBLEM: none
+
+class Foo
+
+fun Foo?.equals(other: Foo?) = true
+
+fun bar(f1: Foo?, f2: Foo?) {
+    if (f1.equals<caret>(f2)) {
+
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/extensionFunction.kt

@@ -0,0 +1,6 @@
+fun test() {
+    class Test()
+    operator fun Test.div(a: Int): Test = Test()
+    val test = Test()
+    test.<caret>div(1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/extensionFunction.kt.after

@@ -0,0 +1,6 @@
+fun test() {
+    class Test()
+    operator fun Test.div(a: Int): Test = Test()
+    val test = Test()
+    test / 1
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/functionLiteralArgument.kt

@@ -0,0 +1,9 @@
+fun test() {
+    class Test {
+        operator fun plus(fn: () -> Test): Test = fn()
+    }
+    val test = Test()
+    test.pl<caret>us {
+        Test()
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/functionLiteralArgument.kt.after

@@ -0,0 +1,9 @@
+fun test() {
+    class Test {
+        operator fun plus(fn: () -> Test): Test = fn()
+    }
+    val test = Test()
+    test + {
+        Test()
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/greater.kt

@@ -0,0 +1,3 @@
+// FIX: Replace with '>' operator
+
+val x = 3.compare<caret>To(2) > 0

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/greater.kt.after

@@ -0,0 +1,3 @@
+// FIX: Replace with '>' operator
+
+val x = 3 > 2

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/lessEquals.kt

@@ -0,0 +1,3 @@
+// FIX: Replace with '<=' operator
+
+val x = 0 >= 4.compare<caret>To(5)

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/lessEquals.kt.after

@@ -0,0 +1,3 @@
+// FIX: Replace with '<=' operator
+
+val x = 4 <= 5

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/minusSanityTest.kt

@@ -0,0 +1,8 @@
+// FIX: Replace with '-' operator
+fun test() {
+    class Test {
+        operator fun minus(a: Int): Test = Test()
+    }
+    val test = Test()
+    test.min<caret>us(1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/minusSanityTest.kt.after

@@ -0,0 +1,8 @@
+// FIX: Replace with '-' operator
+fun test() {
+    class Test {
+        operator fun minus(a: Int): Test = Test()
+    }
+    val test = Test()
+    test - 1
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/missingDefaultArgument.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// ERROR: 'operator' modifier is inapplicable on this function: must have a single value parameter
+fun test() {
+    class Test{
+        operator fun plus(a: Int=1, b: Int=2) : Int = 0
+    }
+    val test = Test()
+    test.p<caret>lus(b=3)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/modSanityTest.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+
+fun test() {
+    class Test {
+        operator fun mod(a: Int): Test = Test()
+    }
+    val test = Test()
+    test.<caret>mod(1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/multipleArguments.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// ERROR: 'operator' modifier is inapplicable on this function: must have a single value parameter
+fun test() {
+    class Test {
+        operator fun plus(a: Int, b: Int): Test = Test()
+    }
+    val test = Test()
+    test.pl<caret>us(1, 2)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEquals.kt

@@ -0,0 +1,3 @@
+// FIX: Replace with '!=' operator
+
+val x = !2.eq<caret>uals(3)

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEquals.kt.after

@@ -0,0 +1,3 @@
+// FIX: Replace with '!=' operator
+
+val x = 2 != 3

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEqualsBrackets.kt

@@ -0,0 +1,3 @@
+// FIX: Replace with '!=' operator
+
+val x = !(2.<caret>equals(3))

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEqualsBrackets.kt.after

@@ -0,0 +1,3 @@
+// FIX: Replace with '!=' operator
+
+val x = 2 != 3

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEqualsBracketsComplex.kt

@@ -0,0 +1,3 @@
+// FIX: Replace with '==' operator
+
+val x = !(2.equ<caret>als(3) && 4.equals(5))

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEqualsBracketsComplex.kt.after

@@ -0,0 +1,3 @@
+// FIX: Replace with '==' operator
+
+val x = !(2 == 3 && 4.equals(5))

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/plusSanityTest.kt

@@ -0,0 +1,8 @@
+// FIX: Replace with '+' operator
+fun test() {
+    class Test {
+        operator fun plus(a: Int): Test = Test()
+    }
+    val test = Test()
+    test.pl<caret>us(1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/plusSanityTest.kt.after

@@ -0,0 +1,8 @@
+// FIX: Replace with '+' operator
+fun test() {
+    class Test {
+        operator fun plus(a: Int): Test = Test()
+    }
+    val test = Test()
+    test + 1
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/qualifier.kt

@@ -0,0 +1,9 @@
+class C {
+    companion object {
+        operator fun plus(s: String): C = C()
+    }
+}
+
+fun foo() {
+    C.<caret>plus("x")
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/qualifier.kt.after

@@ -0,0 +1,9 @@
+class C {
+    companion object {
+        operator fun plus(s: String): C = C()
+    }
+}
+
+fun foo() {
+    C + "x"
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/rangeToSanityTest.kt

@@ -0,0 +1,8 @@
+// FIX: Replace with '..' operator
+fun test() {
+    class Test {
+        operator fun rangeTo(a: Int): Test = Test()
+    }
+    val test = Test()
+    test.range<caret>To(1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/rangeToSanityTest.kt.after

@@ -0,0 +1,8 @@
+// FIX: Replace with '..' operator
+fun test() {
+    class Test {
+        operator fun rangeTo(a: Int): Test = Test()
+    }
+    val test = Test()
+    test..1
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/remSanityTest.kt

@@ -0,0 +1,9 @@
+// FIX: Replace with '%' operator
+
+fun test() {
+    class Test {
+        operator fun rem(a: Int): Test = Test()
+    }
+    val test = Test()
+    test.<caret>rem(1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/remSanityTest.kt.after

@@ -0,0 +1,9 @@
+// FIX: Replace with '%' operator
+
+fun test() {
+    class Test {
+        operator fun rem(a: Int): Test = Test()
+    }
+    val test = Test()
+    test % 1
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/safeCompareTo.kt

@@ -0,0 +1,5 @@
+// PROBLEM: none
+// ERROR: Operator call corresponds to a dot-qualified call 'nullable?.compareTo(1).compareTo(0)' which is not allowed on a nullable receiver 'nullable?.compareTo(1)'.
+
+val nullable: Int? = null
+val x = nullable?.compareTo<caret>(1) >= 0

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/super.kt

@@ -0,0 +1,11 @@
+// PROBLEM: none
+
+open class Base {
+    open operator fun plus(s: String) = ""
+}
+
+class C : Base() {
+    override fun plus(s: String): String {
+        return super.<caret>plus(s)
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/timesSanityTest.kt

@@ -0,0 +1,8 @@
+// FIX: Replace with '*' operator
+fun test() {
+    class Test {
+        operator fun times(a: Int): Test = Test()
+    }
+    val test = Test()
+    test.time<caret>s(1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/timesSanityTest.kt.after

@@ -0,0 +1,8 @@
+// FIX: Replace with '*' operator
+fun test() {
+    class Test {
+        operator fun times(a: Int): Test = Test()
+    }
+    val test = Test()
+    test * 1
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/typeArguments.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+fun test() {
+    class Test {
+        operator fun <T> div(a: Test): T? = a as? T
+    }
+    val test = Test()
+    test.div<caret><Int>(Test())
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/unacceptableVararg1.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// ERROR: 'operator' modifier is inapplicable on this function: must have a single value parameter
+fun test() {
+    class Test{
+        operator fun plus(vararg b: Int, c: Int = 0): Int = 0
+    }
+    val test = Test()
+    test.plus<caret>(c=5)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/unacceptableVararg2.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// ERROR: 'operator' modifier is inapplicable on this function: must have a single value parameter
+fun test() {
+    class Test{
+        operator fun plus(vararg b: Int, c: Int = 0): Int = 0
+    }
+    val test = Test()
+    test.plus<caret>(0, 1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/validNamedArgument.kt

@@ -0,0 +1,7 @@
+fun test() {
+    class Test {
+        operator fun plus(a: Int): Test = Test()
+    }
+    val test = Test()
+    test.pl<caret>us(a=1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/validNamedArgument.kt.after

@@ -0,0 +1,7 @@
+fun test() {
+    class Test {
+        operator fun plus(a: Int): Test = Test()
+    }
+    val test = Test()
+    test + 1
+}