From ac8b39cbde2ad2a0f41716952270b659f4bf3cdd Mon Sep 17 00:00:00 2001
From: Nikolay Lunyak <nikolay.lunyak@jetbrains.com>
Date: Tue, 9 Jan 2024 12:27:45 +0200
Subject: [PATCH] [FIR JS] Remove weird source picking in FirJsExternalChecker

Otherwise, these tests fail due to
misplaced diagnostics in LT:
- `testExtensionFunctionArgumentOrReturnType`
- `testInlineClassAsParameterOrReturnType_allowed_kt`
- `testInlineClassAsParameterOrReturnType_kt`
---
 .../js/checkers/declaration/FirJsExternalChecker.kt        | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/compiler/fir/checkers/checkers.js/src/org/jetbrains/kotlin/fir/analysis/js/checkers/declaration/FirJsExternalChecker.kt b/compiler/fir/checkers/checkers.js/src/org/jetbrains/kotlin/fir/analysis/js/checkers/declaration/FirJsExternalChecker.kt
index 25eed49b447..80de3c130b9 100644
--- a/compiler/fir/checkers/checkers.js/src/org/jetbrains/kotlin/fir/analysis/js/checkers/declaration/FirJsExternalChecker.kt
+++ b/compiler/fir/checkers/checkers.js/src/org/jetbrains/kotlin/fir/analysis/js/checkers/declaration/FirJsExternalChecker.kt
@@ -88,12 +88,7 @@ object FirJsExternalChecker : FirWebCommonExternalChecker() {
             }
 
             for (parameter in declaration.valueParameters) {
-                val ktParam = if (parameter.source?.psi is KtParameter) {
-                    parameter.source
-                } else {
-                    declaration.source
-                }
-
+                val ktParam = parameter.source
                 if (ktParam?.allowsReporting != true) {
                     continue
                 }