azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve wording; mark inspection as cleanup tool

Browse Source
This commit is contained in:
Dmitry Jemerov
2017-12-08 12:31:09 +01:00
parent 0e2bdf8995
commit ab619c5655
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/resources/inspectionDescriptions/SortModifiers.html
+2 -1
View File
@@ -1,5 +1,6 @@
<html> <html>
<body> <body>
This inspection reports to sort the modifiers in canonical order This inspection reports modifiers which have a different order from the one recommended in the style guide,
and offers to reorder them.
</body> </body>
</html> </html>
idea/src/META-INF/plugin.xml
+2 -1
View File
@@ -2703,12 +2703,13 @@
<localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.SortModifiersInspection" <localInspection implementationClass="org.jetbrains.kotlin.idea.inspections.SortModifiersInspection"
displayName="Sort modifiers" displayName="Non-canonical modifier order"
groupPath="Kotlin" groupPath="Kotlin"
groupName="Style issues" groupName="Style issues"
enabledByDefault="true" enabledByDefault="true"
level="WEAK WARNING" level="WEAK WARNING"
language="kotlin" language="kotlin"
cleanupTool="true"
/> />
<referenceImporter implementation="org.jetbrains.kotlin.idea.quickfix.KotlinReferenceImporter"/> <referenceImporter implementation="org.jetbrains.kotlin.idea.quickfix.KotlinReferenceImporter"/>
idea/src/org/jetbrains/kotlin/idea/inspections/SortModifiersInspection.kt
+2 -2
View File
@@ -26,7 +26,7 @@ import org.jetbrains.kotlin.psi.KtVisitorVoid
import org.jetbrains.kotlin.psi.addRemoveModifier.sortModifiers import org.jetbrains.kotlin.psi.addRemoveModifier.sortModifiers
import org.jetbrains.kotlin.psi.psiUtil.allChildren import org.jetbrains.kotlin.psi.psiUtil.allChildren
class SortModifiersInspection : AbstractKotlinInspection() { class SortModifiersInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor { override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
return object : KtVisitorVoid() { return object : KtVisitorVoid() {
@@ -40,7 +40,7 @@ class SortModifiersInspection : AbstractKotlinInspection() {
if (modifiers == sortedModifiers) return if (modifiers == sortedModifiers) return
holder.registerProblem(list, holder.registerProblem(list,
"Sort modifiers", "Non-canonical modifiers order",
ProblemHighlightType.WEAK_WARNING, ProblemHighlightType.WEAK_WARNING,
SortModifiersFix(sortedModifiers) SortModifiersFix(sortedModifiers)
) )