azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor: Replace a number of trivial Guava usages with constructor calls and kotlin-stdlib function calls

Browse Source
This commit is contained in:
Yan Zhulanow
2018-06-01 18:03:19 +03:00
parent 61ffde54fd
commit ab5614eaac
44 changed files with 100 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/frontend/src/org/jetbrains/kotlin/checkers/DebugInfoUtil.java
+2 -2
View File
@@ -16,7 +16,6 @@
package org.jetbrains.kotlin.checkers;
import com.google.common.collect.Maps;
import com.intellij.psi.PsiElement;
import com.intellij.psi.tree.IElementType;
import com.intellij.psi.tree.TokenSet;
@@ -42,6 +41,7 @@ import org.jetbrains.kotlin.types.KotlinType;
import org.jetbrains.kotlin.util.slicedMap.WritableSlice;
import java.util.Collection;
import java.util.HashMap;
import java.util.Map;
import static org.jetbrains.kotlin.lexer.KtTokens.*;
@@ -72,7 +72,7 @@ public class DebugInfoUtil {
@NotNull BindingContext bindingContext,
@NotNull DebugInfoReporter debugInfoReporter
) {
Map<KtReferenceExpression, DiagnosticFactory<?>> markedWithErrorElements = Maps.newHashMap();
Map<KtReferenceExpression, DiagnosticFactory<?>> markedWithErrorElements = new HashMap<>();
for (Diagnostic diagnostic : bindingContext.getDiagnostics()) {
DiagnosticFactory<?> factory = diagnostic.getFactory();
if (Errors.UNRESOLVED_REFERENCE_DIAGNOSTICS.contains(diagnostic.getFactory())) {
compiler/frontend/src/org/jetbrains/kotlin/diagnostics/rendering/Renderers.kt
+1 -2
View File
@@ -17,7 +17,6 @@
package org.jetbrains.kotlin.diagnostics.rendering
import com.google.common.collect.Lists
import com.google.common.collect.Sets
import com.intellij.openapi.diagnostic.Logger
import com.intellij.openapi.util.text.StringUtil
import com.intellij.psi.PsiElement
@@ -252,7 +251,7 @@ object Renderers {
for (substitutedDescriptor in substitutedDescriptors) {
val receiverType = DescriptorUtils.getReceiverParameterType(substitutedDescriptor.extensionReceiverParameter)
val errorPositions = Sets.newHashSet<ConstraintPosition>()
val errorPositions = hashSetOf<ConstraintPosition>()
val parameterTypes = Lists.newArrayList<KotlinType>()
for (valueParameterDescriptor in substitutedDescriptor.valueParameters) {
parameterTypes.add(valueParameterDescriptor.type)
compiler/frontend/src/org/jetbrains/kotlin/resolve/BodyResolver.java
+4 -5
View File
@@ -17,7 +17,6 @@
package org.jetbrains.kotlin.resolve;
import com.google.common.collect.Maps;
import com.google.common.collect.Sets;
import com.intellij.openapi.project.Project;
import com.intellij.psi.PsiElement;
import com.intellij.util.containers.Queue;
@@ -133,7 +132,7 @@ public class BodyResolver {
resolveSecondaryConstructorBody(c.getOuterDataFlowInfo(), trace, entry.getKey(), entry.getValue(), declaringScope);
}
if (c.getSecondaryConstructors().isEmpty()) return;
Set<ConstructorDescriptor> visitedConstructors = Sets.newHashSet();
Set<ConstructorDescriptor> visitedConstructors = new HashSet<>();
for (Map.Entry<KtSecondaryConstructor, ClassConstructorDescriptor> entry : c.getSecondaryConstructors().entrySet()) {
checkCyclicConstructorDelegationCall(entry.getValue(), visitedConstructors);
}
@@ -191,7 +190,7 @@ public class BodyResolver {
// if visit constructor that is already in current chain
// such constructor is on cycle
Set<ConstructorDescriptor> visitedInCurrentChain = Sets.newHashSet();
Set<ConstructorDescriptor> visitedInCurrentChain = new HashSet<>();
ConstructorDescriptor currentConstructorDescriptor = constructorDescriptor;
while (true) {
visitedInCurrentChain.add(currentConstructorDescriptor);
@@ -520,7 +519,7 @@ public class BodyResolver {
@NotNull KtClassOrObject ktClassOrObject
) {
Set<TypeConstructor> allowedFinalSupertypes = getAllowedFinalSupertypes(supertypeOwner, supertypes, ktClassOrObject);
Set<TypeConstructor> typeConstructors = Sets.newHashSet();
Set<TypeConstructor> typeConstructors = new HashSet<>();
boolean classAppeared = false;
for (Map.Entry<KtTypeReference, KotlinType> entry : supertypes.entrySet()) {
KtTypeReference typeReference = entry.getKey();
@@ -737,7 +736,7 @@ public class BodyResolver {
private void resolvePropertyDeclarationBodies(@NotNull BodiesResolveContext c) {
// Member properties
Set<KtProperty> processed = Sets.newHashSet();
Set<KtProperty> processed = new HashSet<>();
for (Map.Entry<KtClassOrObject, ClassDescriptorWithResolutionScopes> entry : c.getDeclaredClasses().entrySet()) {
if (!(entry.getKey() instanceof KtClass)) continue;
KtClass ktClass = (KtClass) entry.getKey();
compiler/frontend/src/org/jetbrains/kotlin/resolve/DescriptorResolver.java
+1 -2
View File
@@ -17,7 +17,6 @@
package org.jetbrains.kotlin.resolve;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import com.intellij.openapi.project.Project;
import com.intellij.psi.PsiElement;
import kotlin.Pair;
@@ -504,7 +503,7 @@ public class DescriptorResolver {
List<UpperBoundCheckRequest> upperBoundCheckRequests = Lists.newArrayList();
List<KtTypeParameter> typeParameters = declaration.getTypeParameters();
Map<Name, TypeParameterDescriptorImpl> parameterByName = Maps.newHashMap();
Map<Name, TypeParameterDescriptorImpl> parameterByName = new HashMap<>();
for (int i = 0; i < typeParameters.size(); i++) {
KtTypeParameter ktTypeParameter = typeParameters.get(i);
TypeParameterDescriptorImpl typeParameterDescriptor = parameters.get(i);
compiler/frontend/src/org/jetbrains/kotlin/resolve/ModifiersChecker.java
+2 -2
View File
@@ -5,7 +5,6 @@
package org.jetbrains.kotlin.resolve;
import com.google.common.collect.Maps;
import com.intellij.psi.PsiElement;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
@@ -22,6 +21,7 @@ import org.jetbrains.kotlin.psi.*;
import org.jetbrains.kotlin.resolve.checkers.*;
import java.util.Collection;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
@@ -253,7 +253,7 @@ public class ModifiersChecker {
@NotNull KtModifierList modifierList,
@NotNull Collection<KtModifierKeywordToken> possibleModifiers
) {
Map<KtModifierKeywordToken, PsiElement> tokens = Maps.newHashMap();
Map<KtModifierKeywordToken, PsiElement> tokens = new HashMap<>();
for (KtModifierKeywordToken modifier : possibleModifiers) {
if (modifierList.hasModifier(modifier)) {
tokens.put(modifier, modifierList.getModifier(modifier));
compiler/frontend/src/org/jetbrains/kotlin/resolve/OverrideResolver.kt
+1 -1
View File
@@ -866,7 +866,7 @@ class OverrideResolver(
declaringClass: ClassDescriptor
): CallableMemberDescriptor? {
for (supertype in declaringClass.typeConstructor.supertypes) {
val all = Sets.newLinkedHashSet<CallableMemberDescriptor>()
val all = linkedSetOf<CallableMemberDescriptor>()
all.addAll(supertype.memberScope.getContributedFunctions(declared.name, NoLookupLocation.WHEN_CHECK_OVERRIDES))
all.addAll(supertype.memberScope.getContributedVariables(declared.name, NoLookupLocation.WHEN_CHECK_OVERRIDES))
for (fromSuper in all) {
compiler/frontend/src/org/jetbrains/kotlin/resolve/TopDownAnalysisContext.java
+2 -5
View File
@@ -28,10 +28,7 @@ import org.jetbrains.kotlin.resolve.lazy.descriptors.LazyScriptDescriptor;
import org.jetbrains.kotlin.resolve.scopes.LexicalScope;
import java.io.PrintStream;
import java.util.Collection;
import java.util.LinkedHashSet;
import java.util.Map;
import java.util.Set;
import java.util.*;
public class TopDownAnalysisContext implements BodiesResolveContext {
@@ -44,7 +41,7 @@ public class TopDownAnalysisContext implements BodiesResolveContext {
private final Map<KtNamedFunction, SimpleFunctionDescriptor> functions = Maps.newLinkedHashMap();
private final Map<KtProperty, PropertyDescriptor> properties = Maps.newLinkedHashMap();
private final Map<KtParameter, PropertyDescriptor> primaryConstructorParameterProperties = Maps.newHashMap();
private final Map<KtParameter, PropertyDescriptor> primaryConstructorParameterProperties = new HashMap<>();
private final Map<KtTypeAlias, TypeAliasDescriptor> typeAliases = Maps.newLinkedHashMap();
private final Map<KtDestructuringDeclarationEntry, PropertyDescriptor> destructuringDeclarationEntries = Maps.newLinkedHashMap();
private Map<KtCallableDeclaration, CallableMemberDescriptor> members = null;
compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/ValueArgumentsToParametersMapper.java
+5 -11
View File
@@ -16,8 +16,6 @@
package org.jetbrains.kotlin.resolve.calls;
import com.google.common.collect.Maps;
import com.google.common.collect.Sets;
import com.intellij.psi.impl.source.tree.LeafPsiElement;
import kotlin.collections.CollectionsKt;
import org.jetbrains.annotations.NotNull;
@@ -27,7 +25,6 @@ import org.jetbrains.kotlin.descriptors.*;
import org.jetbrains.kotlin.diagnostics.Diagnostic;
import org.jetbrains.kotlin.name.Name;
import org.jetbrains.kotlin.psi.*;
import org.jetbrains.kotlin.psi.psiUtil.KtPsiUtilKt;
import org.jetbrains.kotlin.psi.psiUtil.ReservedCheckingKt;
import org.jetbrains.kotlin.resolve.OverrideResolver;
import org.jetbrains.kotlin.resolve.calls.callUtil.CallUtilKt;
@@ -35,10 +32,7 @@ import org.jetbrains.kotlin.resolve.calls.components.ArgumentsUtilsKt;
import org.jetbrains.kotlin.resolve.calls.model.*;
import org.jetbrains.kotlin.resolve.calls.tasks.TracingStrategy;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.*;
import static org.jetbrains.kotlin.diagnostics.Errors.*;
import static org.jetbrains.kotlin.diagnostics.Errors.BadNamedArgumentsTarget.*;
@@ -88,8 +82,8 @@ public class ValueArgumentsToParametersMapper {
private final Map<Name,ValueParameterDescriptor> parameterByName;
private Map<Name,ValueParameterDescriptor> parameterByNameInOverriddenMethods;
private final Map<ValueParameterDescriptor, VarargValueArgument> varargs = Maps.newHashMap();
private final Set<ValueParameterDescriptor> usedParameters = Sets.newHashSet();
private final Map<ValueParameterDescriptor, VarargValueArgument> varargs = new HashMap<>();
private final Set<ValueParameterDescriptor> usedParameters = new HashSet<>();
private Status status = OK;
private Processor(@NotNull Call call, @NotNull MutableResolvedCall<D> candidateCall, @NotNull TracingStrategy tracing) {
@@ -98,7 +92,7 @@ public class ValueArgumentsToParametersMapper {
this.candidateCall = candidateCall;
this.parameters = candidateCall.getCandidateDescriptor().getValueParameters();
this.parameterByName = Maps.newHashMap();
this.parameterByName = new HashMap<>();
for (ValueParameterDescriptor valueParameter : parameters) {
parameterByName.put(valueParameter.getName(), valueParameter);
}
@@ -107,7 +101,7 @@ public class ValueArgumentsToParametersMapper {
@Nullable
private ValueParameterDescriptor getParameterByNameInOverriddenMethods(Name name) {
if (parameterByNameInOverriddenMethods == null) {
parameterByNameInOverriddenMethods = Maps.newHashMap();
parameterByNameInOverriddenMethods = new HashMap<>();
for (ValueParameterDescriptor valueParameter : parameters) {
for (ValueParameterDescriptor parameterDescriptor : valueParameter.getOverriddenDescriptors()) {
parameterByNameInOverriddenMethods.put(parameterDescriptor.getName(), valueParameter);
compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/model/ResolvedCallImpl.java
+3 -4
View File
@@ -16,7 +16,6 @@
package org.jetbrains.kotlin.resolve.calls.model;
import com.google.common.collect.Maps;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.util.SmartList;
import kotlin.Unit;
@@ -132,17 +131,17 @@ public class ResolvedCallImpl<D extends CallableDescriptor> implements MutableRe
@NotNull
private static Map<ValueParameterDescriptor, ResolvedValueArgument> createValueArgumentsMap(CallableDescriptor descriptor) {
return descriptor.getValueParameters().isEmpty() ? Collections.emptyMap() : Maps.newLinkedHashMap();
return descriptor.getValueParameters().isEmpty() ? Collections.emptyMap() : new LinkedHashMap<>();
}
@NotNull
private static Map<ValueArgument, ArgumentMatchImpl> createArgumentsToParameterMap(CallableDescriptor descriptor) {
return descriptor.getValueParameters().isEmpty() ? Collections.emptyMap() : Maps.newHashMap();
return descriptor.getValueParameters().isEmpty() ? Collections.emptyMap() : new HashMap<>();
}
@NotNull
private static Map<TypeParameterDescriptor, KotlinType> createTypeArgumentsMap(CallableDescriptor descriptor) {
return descriptor.getTypeParameters().isEmpty() ? Collections.emptyMap() : Maps.newLinkedHashMap();
return descriptor.getTypeParameters().isEmpty() ? Collections.emptyMap() : new LinkedHashMap<>();
}
@Override
compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/results/ResolutionResultsHandler.java
+6 -7
View File
@@ -16,7 +16,6 @@
package org.jetbrains.kotlin.resolve.calls.results;
import com.google.common.collect.Sets;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.kotlin.builtins.KotlinBuiltIns;
import org.jetbrains.kotlin.config.LanguageFeature;
@@ -56,10 +55,10 @@ public class ResolutionResultsHandler {
@NotNull Collection<MutableResolvedCall<D>> candidates,
@NotNull LanguageVersionSettings languageVersionSettings
) {
Set<MutableResolvedCall<D>> successfulCandidates = Sets.newLinkedHashSet();
Set<MutableResolvedCall<D>> failedCandidates = Sets.newLinkedHashSet();
Set<MutableResolvedCall<D>> incompleteCandidates = Sets.newLinkedHashSet();
Set<MutableResolvedCall<D>> candidatesWithWrongReceiver = Sets.newLinkedHashSet();
Set<MutableResolvedCall<D>> successfulCandidates = new LinkedHashSet<>();
Set<MutableResolvedCall<D>> failedCandidates = new LinkedHashSet<>();
Set<MutableResolvedCall<D>> incompleteCandidates = new LinkedHashSet<>();
Set<MutableResolvedCall<D>> candidatesWithWrongReceiver = new LinkedHashSet<>();
for (MutableResolvedCall<D> candidateCall : candidates) {
ResolutionStatus status = candidateCall.getStatus();
assert status != UNKNOWN_STATUS : "No resolution for " + candidateCall.getCandidateDescriptor();
@@ -102,7 +101,7 @@ public class ResolutionResultsHandler {
@NotNull CheckArgumentTypesMode checkArgumentsMode,
@NotNull LanguageVersionSettings languageVersionSettings
) {
Set<MutableResolvedCall<D>> successfulAndIncomplete = Sets.newLinkedHashSet();
Set<MutableResolvedCall<D>> successfulAndIncomplete = new LinkedHashSet<>();
successfulAndIncomplete.addAll(successfulCandidates);
successfulAndIncomplete.addAll(incompleteCandidates);
OverloadResolutionResultsImpl<D> results = chooseAndReportMaximallySpecific(
@@ -148,7 +147,7 @@ public class ResolutionResultsHandler {
}
for (EnumSet<ResolutionStatus> severityLevel : SEVERITY_LEVELS) {
Set<MutableResolvedCall<D>> thisLevel = Sets.newLinkedHashSet();
Set<MutableResolvedCall<D>> thisLevel = new LinkedHashSet<>();
for (MutableResolvedCall<D> candidate : failedCandidates) {
if (severityLevel.contains(candidate.getStatus())) {
thisLevel.add(candidate);
compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/tasks/AbstractTracingStrategy.java
+2 -2
View File
@@ -16,7 +16,6 @@
package org.jetbrains.kotlin.resolve.calls.tasks;
import com.google.common.collect.Sets;
import com.intellij.lang.ASTNode;
import com.intellij.psi.PsiElement;
import org.jetbrains.annotations.NotNull;
@@ -45,6 +44,7 @@ import org.jetbrains.kotlin.types.Variance;
import org.jetbrains.kotlin.types.expressions.OperatorConventions;
import java.util.Collection;
import java.util.HashSet;
import static org.jetbrains.kotlin.diagnostics.Errors.*;
import static org.jetbrains.kotlin.resolve.BindingContext.AMBIGUOUS_REFERENCE_TARGET;
@@ -64,7 +64,7 @@ public abstract class AbstractTracingStrategy implements TracingStrategy {
@Override
public <D extends CallableDescriptor> void recordAmbiguity(@NotNull BindingTrace trace, @NotNull Collection<? extends ResolvedCall<D>> candidates) {
Collection<D> descriptors = Sets.newHashSet();
Collection<D> descriptors = new HashSet<>();
for (ResolvedCall<D> candidate : candidates) {
descriptors.add(candidate.getCandidateDescriptor());
}
compiler/frontend/src/org/jetbrains/kotlin/resolve/lazy/declarations/AbstractPsiBasedDeclarationProvider.kt
+1 -2
View File
@@ -17,7 +17,6 @@
package org.jetbrains.kotlin.resolve.lazy.declarations
import com.google.common.collect.ArrayListMultimap
import com.google.common.collect.Sets
import org.jetbrains.kotlin.name.Name
import org.jetbrains.kotlin.psi.*
import org.jetbrains.kotlin.psi.psiUtil.safeNameForLazyResolve
@@ -38,7 +37,7 @@ abstract class AbstractPsiBasedDeclarationProvider(storageManager: StorageManage
val classesAndObjects = ArrayListMultimap.create<Name, KtClassLikeInfo>() // order matters here
val typeAliases = ArrayListMultimap.create<Name, KtTypeAlias>()
val destructuringDeclarationsEntries = ArrayListMultimap.create<Name, KtDestructuringDeclarationEntry>()
val names = Sets.newHashSet<Name>()
val names = hashSetOf<Name>()
fun putToIndex(declaration: KtDeclaration) {
if (declaration is KtAnonymousInitializer || declaration is KtSecondaryConstructor) return
compiler/frontend/src/org/jetbrains/kotlin/resolve/lazy/declarations/FileBasedDeclarationProviderFactory.java
+2 -2
View File
@@ -18,7 +18,6 @@ package org.jetbrains.kotlin.resolve.lazy.declarations;
import com.google.common.collect.LinkedHashMultimap;
import com.google.common.collect.Multimap;
import com.google.common.collect.Sets;
import kotlin.collections.CollectionsKt;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
@@ -29,13 +28,14 @@ import org.jetbrains.kotlin.storage.NotNullLazyValue;
import org.jetbrains.kotlin.storage.StorageManager;
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
public class FileBasedDeclarationProviderFactory extends AbstractDeclarationProviderFactory {
private static class Index {
private final Multimap<FqName, KtFile> filesByPackage = LinkedHashMultimap.create();
private final Set<FqName> declaredPackages = Sets.newHashSet();
private final Set<FqName> declaredPackages = new HashSet<>();
}
private final StorageManager storageManager;
compiler/frontend/src/org/jetbrains/kotlin/resolve/lazy/descriptors/AbstractLazyMemberScope.kt
+2 -3
View File
@@ -16,7 +16,6 @@
package org.jetbrains.kotlin.resolve.lazy.descriptors
import com.google.common.collect.Sets
import org.jetbrains.kotlin.descriptors.*
import org.jetbrains.kotlin.incremental.components.LookupLocation
import org.jetbrains.kotlin.lexer.KtTokens
@@ -55,7 +54,7 @@ protected constructor(
storageManager.createMemoizedFunction { doGetTypeAliases(it) }
private fun doGetClasses(name: Name): List<ClassDescriptor> {
val result = Sets.newLinkedHashSet<ClassDescriptor>()
val result = linkedSetOf<ClassDescriptor>()
declarationProvider.getClassOrObjectDeclarations(name).mapTo(result) {
if (it is KtScriptInfo)
LazyScriptDescriptor(c as ResolveSession, thisDescriptor, name, it)
@@ -92,7 +91,7 @@ protected constructor(
}
private fun doGetFunctions(name: Name): Collection<SimpleFunctionDescriptor> {
val result = Sets.newLinkedHashSet<SimpleFunctionDescriptor>()
val result = linkedSetOf<SimpleFunctionDescriptor>()
val declarations = declarationProvider.getFunctionDeclarations(name)
for (functionDeclaration in declarations) {
compiler/frontend/src/org/jetbrains/kotlin/types/SubstitutionUtils.java
+3 -3
View File
@@ -17,13 +17,13 @@
package org.jetbrains.kotlin.types;
import com.google.common.collect.LinkedHashMultimap;
import com.google.common.collect.Maps;
import com.google.common.collect.Multimap;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.jetbrains.kotlin.builtins.KotlinBuiltIns;
import org.jetbrains.kotlin.descriptors.TypeParameterDescriptor;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
@@ -36,7 +36,7 @@ public class SubstitutionUtils {
*/
@NotNull
public static TypeSubstitutor buildDeepSubstitutor(@NotNull KotlinType type) {
Map<TypeConstructor, TypeProjection> substitution = Maps.newHashMap();
Map<TypeConstructor, TypeProjection> substitution = new HashMap<>();
TypeSubstitutor typeSubstitutor = TypeSubstitutor.create(substitution);
// we use the mutability of the map here
fillInDeepSubstitutor(type, typeSubstitutor, substitution, null);
@@ -59,7 +59,7 @@ public class SubstitutionUtils {
@NotNull
public static Multimap<TypeParameterDescriptor, TypeProjection> buildDeepSubstitutionMultimap(@NotNull KotlinType type) {
Multimap<TypeParameterDescriptor, TypeProjection> fullSubstitution = LinkedHashMultimap.create();
Map<TypeConstructor, TypeProjection> substitution = Maps.newHashMap();
Map<TypeConstructor, TypeProjection> substitution = new HashMap<>();
TypeSubstitutor typeSubstitutor = TypeSubstitutor.create(substitution);
// we use the mutability of the map here
fillInDeepSubstitutor(type, typeSubstitutor, substitution, fullSubstitution);
compiler/frontend/src/org/jetbrains/kotlin/types/TypeUnifier.java
+4 -3
View File
@@ -17,9 +17,10 @@
package org.jetbrains.kotlin.types;
import com.google.common.collect.Maps;
import com.google.common.collect.Sets;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.kotlin.utils.CollectionsKt;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
@@ -138,8 +139,8 @@ public class TypeUnifier {
private static class UnificationResultImpl implements UnificationResult {
private boolean success = true;
private final Map<TypeConstructor, TypeProjection> substitution = Maps.newHashMapWithExpectedSize(1);
private final Set<TypeConstructor> failedVariables = Sets.newHashSetWithExpectedSize(0);
private final Map<TypeConstructor, TypeProjection> substitution = CollectionsKt.newHashMapWithExpectedSize(1);
private final Set<TypeConstructor> failedVariables = CollectionsKt.newHashSetWithExpectedSize(0);
@Override
public boolean isSuccess() {
compiler/frontend/src/org/jetbrains/kotlin/types/expressions/ControlStructureTypingUtils.java
+2 -3
View File
@@ -18,7 +18,6 @@ package org.jetbrains.kotlin.types.expressions;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import com.intellij.lang.ASTNode;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.util.Ref;
@@ -233,7 +232,7 @@ public class ControlStructureTypingUtils {
@NotNull DataFlowInfo thenInfo,
@NotNull DataFlowInfo elseInfo
) {
Map<ValueArgument, DataFlowInfo> dataFlowInfoForArgumentsMap = Maps.newHashMap();
Map<ValueArgument, DataFlowInfo> dataFlowInfoForArgumentsMap = new HashMap<>();
dataFlowInfoForArgumentsMap.put(callForIf.getValueArguments().get(0), thenInfo);
dataFlowInfoForArgumentsMap.put(callForIf.getValueArguments().get(1), elseInfo);
return createIndependentDataFlowInfoForArgumentsForCall(conditionInfo, dataFlowInfoForArgumentsMap);
@@ -244,7 +243,7 @@ public class ControlStructureTypingUtils {
@NotNull DataFlowInfo subjectDataFlowInfo,
@NotNull List<DataFlowInfo> entryDataFlowInfos
) {
Map<ValueArgument, DataFlowInfo> dataFlowInfoForArgumentsMap = Maps.newHashMap();
Map<ValueArgument, DataFlowInfo> dataFlowInfoForArgumentsMap = new HashMap<>();
int i = 0;
for (ValueArgument argument : callForWhen.getValueArguments()) {
DataFlowInfo entryDataFlowInfo = entryDataFlowInfos.get(i++);
compiler/frontend/src/org/jetbrains/kotlin/types/expressions/ExpressionTypingVisitorForStatements.java
+2 -2
View File
@@ -16,7 +16,6 @@
package org.jetbrains.kotlin.types.expressions;
import com.google.common.collect.Sets;
import com.intellij.psi.tree.IElementType;
import kotlin.Pair;
import org.jetbrains.annotations.NotNull;
@@ -50,6 +49,7 @@ import org.jetbrains.kotlin.types.expressions.typeInfoFactory.TypeInfoFactoryKt;
import org.jetbrains.kotlin.util.OperatorNameConventions;
import java.util.Collection;
import java.util.HashSet;
import static org.jetbrains.kotlin.diagnostics.Errors.*;
import static org.jetbrains.kotlin.psi.KtPsiUtil.deparenthesize;
@@ -260,7 +260,7 @@ public class ExpressionTypingVisitorForStatements extends ExpressionTypingVisito
// Both 'plus()' and 'plusAssign()' available => ambiguity
OverloadResolutionResults<FunctionDescriptor> ambiguityResolutionResults = OverloadResolutionResultsUtil.ambiguity(assignmentOperationDescriptors, binaryOperationDescriptors);
context.trace.report(ASSIGN_OPERATOR_AMBIGUITY.on(operationSign, ambiguityResolutionResults.getResultingCalls()));
Collection<DeclarationDescriptor> descriptors = Sets.newHashSet();
Collection<DeclarationDescriptor> descriptors = new HashSet<>();
for (ResolvedCall<?> resolvedCall : ambiguityResolutionResults.getResultingCalls()) {
descriptors.add(resolvedCall.getResultingDescriptor());
}
compiler/frontend/src/org/jetbrains/kotlin/types/expressions/LabelResolver.kt
+1 -2
View File
@@ -16,7 +16,6 @@
package org.jetbrains.kotlin.types.expressions
import com.google.common.collect.Sets
import com.intellij.psi.PsiElement
import org.jetbrains.kotlin.descriptors.ClassDescriptor
import org.jetbrains.kotlin.descriptors.FunctionDescriptor
@@ -35,7 +34,7 @@ import org.jetbrains.kotlin.resolve.scopes.utils.getDeclarationsByLabel
object LabelResolver {
private fun getElementsByLabelName(labelName: Name, labelExpression: KtSimpleNameExpression): Set<KtElement> {
val elements = Sets.newLinkedHashSet<KtElement>()
val elements = linkedSetOf<KtElement>()
var parent: PsiElement? = labelExpression.parent
while (parent != null) {
val name = getLabelNameIfAny(parent)
compiler/frontend/src/org/jetbrains/kotlin/util/slicedMap/MapSupplier.java
+4 -4
View File
@@ -16,8 +16,8 @@
package org.jetbrains.kotlin.util.slicedMap;
import com.google.common.collect.Maps;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
public interface MapSupplier {
@@ -25,14 +25,14 @@ public interface MapSupplier {
MapSupplier HASH_MAP_SUPPLIER = new MapSupplier() {
@Override
public <K, V> Map<K, V> get() {
return Maps.newHashMap();
return new HashMap<>();
}
};
MapSupplier LINKED_HASH_MAP_SUPPLIER = new MapSupplier() {
@Override
public <K, V> Map<K, V> get() {
return Maps.newLinkedHashMap();
return new LinkedHashMap<>();
}
};
compiler/frontend/src/org/jetbrains/kotlin/util/slicedMap/TrackingSlicedMap.java
+2 -2
View File
@@ -16,16 +16,16 @@
package org.jetbrains.kotlin.util.slicedMap;
import com.google.common.collect.Maps;
import kotlin.jvm.functions.Function3;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.kotlin.utils.Printer;
import java.util.Collection;
import java.util.HashMap;
import java.util.Map;
public class TrackingSlicedMap extends SlicedMapImpl {
private final Map<ReadOnlySlice<?, ?>, SliceWithStackTrace<?, ?>> sliceTranslationMap = Maps.newHashMap();
private final Map<ReadOnlySlice<?, ?>, SliceWithStackTrace<?, ?>> sliceTranslationMap = new HashMap<>();
private final boolean trackWithStackTraces;
public TrackingSlicedMap(boolean trackWithStackTraces) {