Add better quickfix for scope functions #KT-13676 Fixed

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/also.kt

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a.also {
+        it.<caret>length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/also.kt.after

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a?.also {
+        it.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithFake.kt

@@ -0,0 +1,13 @@
+// "Replace scope function with safe (?.) call" "false"
+// WITH_RUNTIME
+// ACTION: Add non-null asserted (!!) call
+// ACTION: Introduce local variable
+// ACTION: Replace with safe (?.) call
+// ACTION: Surround with null check
+// ERROR: Only safe (?.) or non-null asserted (!!.) calls are allowed on a nullable receiver of type String?
+
+fun foo(a: String?, b: String?) {
+    a.apply { ->
+        b<caret>.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithThis.kt

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a.apply {
+        this<caret>.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithThis.kt.after

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a?.apply {
+        this.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithThisAndArrow.kt

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a.apply { ->
+        this<caret>.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithThisAndArrow.kt.after

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a?.apply { ->
+        this.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithThisLabeled.kt

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a.apply {
+        this@apply<caret>.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithThisLabeled.kt.after

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a?.apply {
+        this@apply.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithThisLabeledFake.kt

@@ -0,0 +1,14 @@
+// "Replace scope function with safe (?.) call" "false"
+// WITH_RUNTIME
+// ACTION: Introduce local variable
+// ACTION: Add non-null asserted (!!) call
+// ACTION: Replace with safe (?.) call
+// ERROR: Only safe (?.) or non-null asserted (!!.) calls are allowed on a nullable receiver of type My?
+
+class My(val prop: Int)
+
+fun My?.foo(a: String?) {
+    a.apply {
+        this@foo<caret>.prop
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithoutThis.kt

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a.apply {
+        <caret>length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithoutThis.kt.after

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a?.apply {
+        length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithoutThisMethodCall.kt

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a.apply {
+        <caret>toLowerCase()
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/applyWithoutThisMethodCall.kt.after

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a?.apply {
+        toLowerCase()
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/let.kt

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a.let {
+        it<caret>.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/let.kt.after

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a?.let {
+        it.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/letWithParam.kt

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a.let { s ->
+        s<caret>.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/letWithParam.kt.after

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a?.let { s ->
+        s.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/letWithWrongImplicitThis.kt

@@ -0,0 +1,13 @@
+// "Replace scope function with safe (?.) call" "false"
+// WITH_RUNTIME
+// ACTION: Add non-null asserted (!!) call
+// ACTION: Introduce local variable
+// ACTION: Move lambda argument into parentheses
+// ACTION: Replace with safe (this?.) call
+// ERROR: Only safe (?.) or non-null asserted (!!.) calls are allowed on a nullable receiver of type String?
+
+fun String?.foo(a: String?) {
+    a.let { s ->
+        <caret>length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/letWithWrongParam.kt

@@ -0,0 +1,13 @@
+// "Replace scope function with safe (?.) call" "false"
+// WITH_RUNTIME
+// ACTION: Add non-null asserted (!!) call
+// ACTION: Introduce local variable
+// ACTION: Replace with safe (?.) call
+// ACTION: Surround with null check
+// ERROR: Only safe (?.) or non-null asserted (!!.) calls are allowed on a nullable receiver of type String?
+
+fun foo(a: String?, b: String?) {
+    a.let { s ->
+        b<caret>.length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/notInsideScope.kt

@@ -0,0 +1,10 @@
+// "Replace scope function with safe (?.) call" "false"
+// ACTION: Add non-null asserted (!!) call
+// ACTION: Introduce local variable
+// ACTION: Replace with safe (?.) call
+// ACTION: Surround with null check
+// ERROR: Only safe (?.) or non-null asserted (!!.) calls are allowed on a nullable receiver of type String?
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a<caret>.length
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/run.kt

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a.run {
+        <caret>length
+    }
+}

idea/testData/quickfix/replaceWithSafeCallForScopeFunction/run.kt.after

@@ -0,0 +1,7 @@
+// "Replace scope function with safe (?.) call" "true"
+// WITH_RUNTIME
+fun foo(a: String?) {
+    a?.run {
+        length
+    }
+}