[Analysis API FIR] fix call resolution of non-resolvable elements

analysis/analysis-api-fe10/src/org/jetbrains/kotlin/analysis/api/descriptors/components/KtFe10CallResolver.kt

@@ -145,7 +145,7 @@ internal class KtFe10CallResolver(
         get() = analysisSession.token
 
     override fun resolveCall(psi: KtElement): KtCallInfo? = with(analysisContext.analyze(psi, AnalysisMode.PARTIAL_WITH_DIAGNOSTICS)) {
-        if (psi.isNotResolvable()) return null
+        if (!canBeResolvedAsCall(psi)) return null
 
         val parentBinaryExpression = psi.parentOfType<KtBinaryExpression>()
         val lhs = KtPsiUtil.deparenthesize(parentBinaryExpression?.left)
@@ -177,7 +177,7 @@ internal class KtFe10CallResolver(
 
     override fun collectCallCandidates(psi: KtElement): List<KtCallCandidateInfo> =
         with(analysisContext.analyze(psi, AnalysisMode.PARTIAL_WITH_DIAGNOSTICS)) {
-            if (psi.isNotResolvable()) return emptyList()
+            if (!canBeResolvedAsCall(psi)) return emptyList()
 
             val resolvedKtCallInfo = resolveCall(psi)
             val bestCandidateDescriptors =

analysis/analysis-api-fe10/tests-gen/org/jetbrains/kotlin/analysis/api/fe10/test/cases/generated/cases/components/callResolver/Fe10IdeNormalAnalysisSourceModuleResolveCallTestGenerated.java

@@ -854,6 +854,34 @@ public class Fe10IdeNormalAnalysisSourceModuleResolveCallTestGenerated extends A
         }
     }
 
+    @Nested
+    @TestMetadata("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls")
+    @TestDataPath("$PROJECT_ROOT")
+    public class NonCalls {
+        @Test
+        public void testAllFilesPresentInNonCalls() throws Exception {
+            KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls"), Pattern.compile("^(.+)\\.kt$"), null, true);
+        }
+
+        @Test
+        @TestMetadata("ifExpression.kt")
+        public void testIfExpression() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/ifExpression.kt");
+        }
+
+        @Test
+        @TestMetadata("literalExpression.kt")
+        public void testLiteralExpression() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/literalExpression.kt");
+        }
+
+        @Test
+        @TestMetadata("whenExpression.kt")
+        public void testWhenExpression() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/whenExpression.kt");
+        }
+    }
+
     @Nested
     @TestMetadata("analysis/analysis-api/testData/components/callResolver/resolveCall/withTestCompilerPluginEnabled")
     @TestDataPath("$PROJECT_ROOT")

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/components/KtFirCallResolver.kt

@@ -86,18 +86,20 @@ internal class KtFirCallResolver(
         result
     }
 
-    override fun resolveCall(psi: KtElement): KtCallInfo? = wrapError(psi) {
+    override fun resolveCall(psi: KtElement): KtCallInfo? {
-        val ktCallInfos = getCallInfo(psi) { psiToResolve, resolveCalleeExpressionOfFunctionCall, resolveFragmentOfCall ->
+        return wrapError(psi) {
-            listOfNotNull(
+            val ktCallInfos = getCallInfo(psi) { psiToResolve, resolveCalleeExpressionOfFunctionCall, resolveFragmentOfCall ->
-                toKtCallInfo(
+                listOfNotNull(
-                    psiToResolve,
+                    toKtCallInfo(
-                    resolveCalleeExpressionOfFunctionCall,
+                        psiToResolve,
-                    resolveFragmentOfCall
+                        resolveCalleeExpressionOfFunctionCall,
+                        resolveFragmentOfCall
+                    )
                 )
-            )
+            }
+            check(ktCallInfos.size <= 1) { "Should only return 1 KtCallInfo" }
+            ktCallInfos.singleOrNull()
         }
-        check(ktCallInfos.size <= 1) { "Should only return 1 KtCallInfo" }
-        ktCallInfos.singleOrNull()
     }
 
     private inline fun <T> getCallInfo(
@@ -108,7 +110,7 @@ internal class KtFirCallResolver(
             resolveFragmentOfCall: Boolean
         ) -> List<T>
     ): List<T> {
-        if (psi.isNotResolvable()) return emptyList()
+        if (!canBeResolvedAsCall(psi)) return emptyList()
 
         val containingCallExpressionForCalleeExpression = psi.getContainingCallExpressionForCalleeExpression()
         val containingBinaryExpressionForLhs = psi.getContainingBinaryExpressionForIncompleteLhs()

analysis/analysis-api-fir/tests-gen/org/jetbrains/kotlin/analysis/api/fir/test/cases/generated/cases/components/callResolver/FirIdeNormalAnalysisSourceModuleResolveCallTestGenerated.java

@@ -854,6 +854,34 @@ public class FirIdeNormalAnalysisSourceModuleResolveCallTestGenerated extends Ab
         }
     }
 
+    @Nested
+    @TestMetadata("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls")
+    @TestDataPath("$PROJECT_ROOT")
+    public class NonCalls {
+        @Test
+        public void testAllFilesPresentInNonCalls() throws Exception {
+            KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls"), Pattern.compile("^(.+)\\.kt$"), null, true);
+        }
+
+        @Test
+        @TestMetadata("ifExpression.kt")
+        public void testIfExpression() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/ifExpression.kt");
+        }
+
+        @Test
+        @TestMetadata("literalExpression.kt")
+        public void testLiteralExpression() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/literalExpression.kt");
+        }
+
+        @Test
+        @TestMetadata("whenExpression.kt")
+        public void testWhenExpression() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/whenExpression.kt");
+        }
+    }
+
     @Nested
     @TestMetadata("analysis/analysis-api/testData/components/callResolver/resolveCall/withTestCompilerPluginEnabled")
     @TestDataPath("$PROJECT_ROOT")

analysis/analysis-api-impl-base/src/org/jetbrains/kotlin/analysis/api/impl/base/components/AbstractKtCallResolver.kt

@@ -45,17 +45,19 @@ abstract class AbstractKtCallResolver : KtCallResolver() {
         return KtPsiUtil.deparenthesize(safeQualifiedExpression.receiverExpression) == KtPsiUtil.deparenthesize(this)
     }
 
+    protected fun canBeResolvedAsCall(ktElement: KtElement): Boolean = when (ktElement) {
+        is KtBinaryExpression -> ktElement.operationToken !in nonCallBinaryOperator
+        is KtOperationReferenceExpression -> ktElement.operationSignTokenType !in nonCallBinaryOperator
+        is KtCallElement -> true
+        is KtConstructorCalleeExpression -> true
+        is KtDotQualifiedExpression -> true
+        is KtNameReferenceExpression -> true
+        is KtOperationExpression -> true
+        is KtArrayAccessExpression -> true
+        else -> false
+    }
+
     protected companion object {
         private val nonCallBinaryOperator: Set<KtSingleValueToken> = setOf(KtTokens.ELVIS, KtTokens.EQEQEQ, KtTokens.EXCLEQEQEQ)
-
-        /**
-         * We don't want to resolve the operators from the [AbstractKtCallResolver.nonCallBinaryOperator] list, because it's either
-         * not possible or not desirable.
-         */
-        fun KtElement.isNotResolvable(): Boolean {
-            return this is KtBinaryExpression && operationToken in nonCallBinaryOperator ||
-                    this is KtOperationReferenceExpression && operationSignTokenType in nonCallBinaryOperator
-        }
-
     }
 }

analysis/analysis-api-standalone/tests-gen/org/jetbrains/kotlin/analysis/api/standalone/fir/test/cases/generated/cases/components/callResolver/FirStandaloneNormalAnalysisSourceModuleResolveCallTestGenerated.java

@@ -853,4 +853,32 @@ public class FirStandaloneNormalAnalysisSourceModuleResolveCallTestGenerated ext
             runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/assignments/insidePlusAssignTarget.kt");
         }
     }
+
+    @Nested
+    @TestMetadata("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls")
+    @TestDataPath("$PROJECT_ROOT")
+    public class NonCalls {
+        @Test
+        public void testAllFilesPresentInNonCalls() throws Exception {
+            KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls"), Pattern.compile("^(.+)\\.kt$"), null, true, "withTestCompilerPluginEnabled");
+        }
+
+        @Test
+        @TestMetadata("ifExpression.kt")
+        public void testIfExpression() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/ifExpression.kt");
+        }
+
+        @Test
+        @TestMetadata("literalExpression.kt")
+        public void testLiteralExpression() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/literalExpression.kt");
+        }
+
+        @Test
+        @TestMetadata("whenExpression.kt")
+        public void testWhenExpression() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/whenExpression.kt");
+        }
+    }
 }

analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/ifExpression.kt

@@ -0,0 +1,3 @@
+fun main() {
+    val x = <expr>if (true) 1 else 2</expr>
+}

analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/ifExpression.txt

@@ -0,0 +1 @@
+null

analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/literalExpression.kt

@@ -0,0 +1,3 @@
+fun main() {
+    val x = <expr>1</expr>
+}

analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/literalExpression.txt

@@ -0,0 +1 @@
+null

analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/whenExpression.kt

@@ -0,0 +1,3 @@
+fun main() {
+    val x = <expr>when (true) { else -> 2 }</expr>
+}

analysis/analysis-api/testData/components/callResolver/resolveCall/nonCalls/whenExpression.txt

@@ -0,0 +1 @@
+null

analysis/analysis-api/testData/components/callResolver/resolveCall/unresolvedSuperReference.txt

@@ -1,3 +1,3 @@
 KtErrorCallInfo:
   candidateCalls = []
-  diagnostic = ERROR<OTHER_ERROR: Unknown (other) error>
+  diagnostic = ERROR<null: Erroneous delegated constructor call>