Improved logic of finding conflicts for refactoring actions

idea/idea-core/src/org/jetbrains/kotlin/idea/core/NameValidators.kt

@@ -21,6 +21,8 @@ import org.jetbrains.kotlin.descriptors.DeclarationDescriptor
 import org.jetbrains.kotlin.descriptors.DeclarationDescriptorWithVisibility
 import org.jetbrains.kotlin.idea.caches.resolve.analyze
 import org.jetbrains.kotlin.idea.caches.resolve.getResolutionFacade
+import org.jetbrains.kotlin.idea.util.getAllAccessibleFunctions
+import org.jetbrains.kotlin.idea.util.getAllAccessibleVariables
 import org.jetbrains.kotlin.incremental.components.NoLookupLocation
 import org.jetbrains.kotlin.name.Name
 import org.jetbrains.kotlin.psi.*
@@ -97,10 +99,9 @@ public class NewDeclarationNameValidator(
 
         return when(target) {
             Target.VARIABLES ->
-                getProperties(name, NoLookupLocation.FROM_IDE).any { !it.isExtension && it.isVisible() } ||
+                getAllAccessibleVariables(name).any { !it.isExtension && it.isVisible() }
-                getLocalVariable(name) != null
             Target.FUNCTIONS_AND_CLASSES ->
-                getFunctions(name, NoLookupLocation.FROM_IDE).any { !it.isExtension && it.isVisible() } ||
+                getAllAccessibleFunctions(name).any { !it.isExtension && it.isVisible() } ||
                 getClassifier(name, NoLookupLocation.FROM_IDE)?.let { it.isVisible() } ?: false
         }
     }

idea/testData/refactoring/extractFunction/parameters/extractThis/qualifiedThisAsArgument.kt.after

@@ -9,7 +9,7 @@ class A {
     fun B.foo() = i(this@A, this)
 }
 
-private fun i(a1: A, b: B) = a1.a + b.b
+private fun i(a1: A, b1: B) = a1.a + b1.b
 
 class B {
     val b = 1

idea/testData/refactoring/extractFunction/parameters/misc/addPrefixToBackticks.kt.after

@@ -11,6 +11,6 @@ class Y(val y: Int) {
     }
 }
 
-private fun __dummyTestFun__(x: X, y1: Y) {
+private fun __dummyTestFun__(x1: X, y1: Y) {
-    x.`x`plus y1.y
+    x1.`x`plus y1.y
 }

idea/testData/refactoring/introduceParameter/substituteDoubleReceiver.kt.after

@@ -14,7 +14,7 @@ class A(val a: Int) {
 
 fun test() {
     val t = with(A(1)) {
-        val a = A(2)
+        val a1 = A(2)
-        foo(this.a + a.a)
+        foo(a + a1.a)
     }
 }

idea/testData/refactoring/introduceParameter/substituteExplicitThisInMember.kt.after

@@ -8,13 +8,13 @@ class A(val a: Int) {
 }
 
 fun test() {
-    val a2 = A(1)
+    val a = A(1)
     val a3 = A(2)
-    a2.foo(a2.a + a3.a)
+    a.foo(a.a + a3.a)
     with(A(1)) {
+        val a2 = A(2)
+        foo(this.a + a2.a)
         val a1 = A(2)
-        foo(a + a1.a)
+        this.foo(this.a + a1.a)
-        val a = A(2)
-        this.foo(this.a + a.a)
     }
 }

idea/testData/refactoring/introduceParameter/substituteImplicitThisInMember.kt.after

@@ -8,13 +8,13 @@ class A(val a: Int) {
 }
 
 fun test() {
-    val a2 = A(1)
+    val a = A(1)
     val a3 = A(2)
-    a2.foo(a2.a + a3.a)
+    a.foo(a.a + a3.a)
     with(A(1)) {
+        val a2 = A(2)
+        foo(this.a + a2.a)
         val a1 = A(2)
-        foo(a + a1.a)
+        this.foo(this.a + a1.a)
-        val a = A(2)
-        this.foo(this.a + a.a)
     }
 }

idea/testData/refactoring/introduceVariable/NoExplicitReceivers.kt.after

@@ -1,9 +1,9 @@
 // WITH_RUNTIME
 fun main(args: Array<String>) {
     with(A()) {
-        val prop = prop
+        val prop1 = prop
-        println(prop)
+        println(prop1)
-        println(prop)
+        println(prop1)
     }
 }
 

idea/testData/refactoring/introduceVariable/nonEquivalentReceivers.kt.after

@@ -6,9 +6,9 @@ fun foo(body: A.() -> Unit) {}
 
 fun bar() {
     foo {
-        val value = value
+        val value1 = value
-        print(value)
+        print(value1)
-        print(value)
+        print(value1)
     }
 
     foo {