azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIR CFA: properly visit subgraphs in checkers

Browse Source 
Interpretation: a graph A is a subgraph of B if information available at
nodes of A depends on the paths taken in B. For example, local classes
are subgraphs of a graph in which they are declared, and members of
those classes are subgraphs of the local class itself - because these
members can reference captured values.

Consequences:

 * if graph G is a subgraph of node N, then G is a subgraph of N's
   owner;
 * `ControlFlowAnalysisDiagnosticComponent` will only visit root graphs;
 * `graph.traverse` will ignore subgraph boundaries, as if all subgraphs
   are inlined into one huge root graph;
 * if a control flow checker needs information from a declaration to
   which a graph is attached, it must look at subgraphs explicitly.

For example, consider the `callsInPlace` checker. When a function
has a `callsInPlace` contract and a local declaration, the checker must
visit that local declaration to ensure it does not capture the allegedly
called-in-place argument - hence `graph.traverse` will look at the
nodes. However, the local declaration can also be a function with its
own `callsInPlace` contracts, so the checker should also run for it in
isolation. If that sounds quadratic, that's because unfortunately it is.
This commit is contained in:
pyos
2022-12-09 12:32:46 +01:00
committed by Dmitriy Novozhilov
parent 5180e1f4a4
commit aadea0e26f
35 changed files with 1191 additions and 1325 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/fir/analysis-tests/testData/resolve/smartcasts/smartCastInInit.dot
Vendored
+19 -20
View File
@@ -57,19 +57,29 @@ digraph smartCastInInit_kt {
subgraph cluster_6 {
color=red
17 [label="Enter init block" style="filled" fillcolor=red];
26 [label="Enter class Main" style="filled" fillcolor=red];
27 [label="Part of class initialization"];
subgraph cluster_7 {
color=blue
18 [label="Enter block"];
19 [label="Function call: R|/s|()" style="filled" fillcolor=yellow];
20 [label="Assignment: R|/Main.x|"];
21 [label="Access variable R|/Main.x|"];
22 [label="Smart cast: this@R|/Main|.R|/Main.x|"];
23 [label="Function call: this@R|/Main|.R|/Main.x|.R|/S.foo|()" style="filled" fillcolor=yellow];
24 [label="Exit block"];
17 [label="Enter init block" style="filled" fillcolor=red];
subgraph cluster_8 {
color=blue
18 [label="Enter block"];
19 [label="Function call: R|/s|()" style="filled" fillcolor=yellow];
20 [label="Assignment: R|/Main.x|"];
21 [label="Access variable R|/Main.x|"];
22 [label="Smart cast: this@R|/Main|.R|/Main.x|"];
23 [label="Function call: this@R|/Main|.R|/Main.x|.R|/S.foo|()" style="filled" fillcolor=yellow];
24 [label="Exit block"];
}
25 [label="Exit init block" style="filled" fillcolor=red];
}
25 [label="Exit init block" style="filled" fillcolor=red];
28 [label="Exit class Main" style="filled" fillcolor=red];
}
26 -> {27} [color=green];
27 -> {17} [color=green];
27 -> {28} [style=dotted];
27 -> {17} [style=dashed];
17 -> {18};
18 -> {19};
19 -> {20};
@@ -80,15 +90,4 @@ digraph smartCastInInit_kt {
24 -> {25};
25 -> {28} [color=green];
subgraph cluster_8 {
color=red
26 [label="Enter class Main" style="filled" fillcolor=red];
27 [label="Part of class initialization"];
28 [label="Exit class Main" style="filled" fillcolor=red];
}
26 -> {27} [color=green];
27 -> {17} [color=green];
27 -> {28} [style=dotted];
27 -> {17} [style=dashed];
}