azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

reduce calls to Object.hashCode originating from LabelNormailizationMethodTransformer

Browse Source 
Building on the work in #2403, shaves 1% of compilation time on kotlinx.serialization
by using SmartIdentityTable instead of hashMap in LabelNormailizationMethodTransformer.

Metrics on the prior hashMap use in this code:

| What      | Count |
| --------- | ----- |
| instances | 21530 |
| min       | 0     |
| max       | 174   |
| mean      | 4     |
| stddev    | 8.24  |
| median    | 4     |
| 90p       | 8     |
| 95p       | 15    |
This commit is contained in:
Jeffrey van Gogh
2019-06-24 08:36:13 -07:00
committed by Alexander Udalov
parent 361c468c33
commit a9c8fd903b
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/LabelNormalizationMethodTransformer.kt
+2 -1
View File
@@ -18,6 +18,7 @@ package org.jetbrains.kotlin.codegen.optimization
import org.jetbrains.kotlin.codegen.optimization.common.removeEmptyCatchBlocks import org.jetbrains.kotlin.codegen.optimization.common.removeEmptyCatchBlocks
import org.jetbrains.kotlin.codegen.optimization.transformer.MethodTransformer import org.jetbrains.kotlin.codegen.optimization.transformer.MethodTransformer
import org.jetbrains.kotlin.utils.SmartIdentityTable
import org.jetbrains.org.objectweb.asm.Label import org.jetbrains.org.objectweb.asm.Label
import org.jetbrains.org.objectweb.asm.tree.* import org.jetbrains.org.objectweb.asm.tree.*
import java.lang.IllegalStateException import java.lang.IllegalStateException
@@ -29,7 +30,7 @@ class LabelNormalizationMethodTransformer : MethodTransformer() {
private class TransformerForMethod(val methodNode: MethodNode) { private class TransformerForMethod(val methodNode: MethodNode) {
val instructions = methodNode.instructions val instructions = methodNode.instructions
val newLabelNodes = hashMapOf<Label, LabelNode>() val newLabelNodes = SmartIdentityTable<Label, LabelNode>()
fun transform() { fun transform() {
if (rewriteLabelInstructions()) { if (rewriteLabelInstructions()) {