Add diagnostics for get/set methods of property delegate

compiler/testData/diagnostics/tests/delegatedProperty/delegatedPropertyOverridedInTraitTypeMismatch.kt

@@ -0,0 +1,18 @@
+trait A {
+    val prop: Int
+}
+
+class AImpl: A  {
+    override val <!RETURN_TYPE_MISMATCH_ON_OVERRIDE!>prop<!> by Delegate()
+}
+
+fun foo() {
+    AImpl().prop
+}
+
+class Delegate {
+    fun get(t: Any?, p: String): String {
+        t.equals(p) // to avoid UNUSED_PARAMETER warning
+        return ""
+    }
+}

compiler/testData/diagnostics/tests/delegatedProperty/genericGetter.kt

@@ -0,0 +1,9 @@
+val a: Int by A(1)
+
+class A<T: Any>(i: T) {
+  fun get(t: Any?, p: String): T {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    throw Exception()
+  }
+}
+

compiler/testData/diagnostics/tests/delegatedProperty/getterWithSubtype.kt

@@ -0,0 +1,13 @@
+open class Base
+class Derived: Base()
+
+val a: Base by A()
+
+class A {
+  fun get(t: Any?, p: String): Derived {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    return Derived()
+  }
+}
+
+

compiler/testData/diagnostics/tests/delegatedProperty/incompleteTypeInference.kt

@@ -0,0 +1,14 @@
+class A
+
+class D {
+    val c: Int by <!DELEGATE_SPECIAL_FUNCTION_MISSING!>IncorrectThis<A>()<!>
+}
+
+val cTopLevel: Int by <!DELEGATE_SPECIAL_FUNCTION_MISSING!>IncorrectThis<A>()<!>
+
+class IncorrectThis<T> {
+    fun get<R>(t: Any?, p: String): Int {
+        t.equals(p) // to avoid UNUSED_PARAMETER warning
+        return 1
+    }
+}

compiler/testData/diagnostics/tests/delegatedProperty/missedGetter.kt

@@ -0,0 +1,3 @@
+val a: Int by <!DELEGATE_SPECIAL_FUNCTION_MISSING!>A()<!>
+
+class A

compiler/testData/diagnostics/tests/delegatedProperty/missedSetter.kt

@@ -0,0 +1,8 @@
+var a: Int by <!DELEGATE_SPECIAL_FUNCTION_MISSING!>A()<!>
+
+class A {
+    fun get(t: Any?, p: String): Int {
+      t.equals(p) // to avoid UNUSED_PARAMETER warning
+      return 1
+    }
+}

compiler/testData/diagnostics/tests/delegatedProperty/setterThisTypeMismatch.kt

@@ -0,0 +1,18 @@
+class D {
+  var c: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+}
+
+var cTopLevel: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+
+class A
+
+class Delegate {
+  fun get(t: Any?, p: String): Int {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    return 1
+  }
+  fun set(t: A, p: String, i: Int) {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    i.equals(null)
+  }
+}

compiler/testData/diagnostics/tests/delegatedProperty/setterWithSupertype.kt

@@ -0,0 +1,17 @@
+open class Base
+class Derived: Base()
+
+var a: Derived by A()
+
+class A {
+  fun get(t: Any?, p: String): Derived {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    return Derived()
+  }
+
+  fun set(t: Any?, p: String, i: Base) {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    i.equals(null) // to avoid UNUSED_PARAMETER warning
+  }
+}
+

compiler/testData/diagnostics/tests/delegatedProperty/thisOfAnyType.kt

@@ -0,0 +1,16 @@
+class A {
+  var a: Int by Delegate()
+}
+
+var aTopLevel: Int by Delegate()
+
+class Delegate {
+  fun get(t: Any?, p: String): Int {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    return 1
+  }
+  fun set(t: Any?, p: String, a: Int) {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    a.equals(null)
+  }
+}

compiler/testData/diagnostics/tests/delegatedProperty/thisOfNothingNullableType.kt

@@ -0,0 +1,15 @@
+class A {
+  var a: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE, DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+}
+
+var aTopLevel: Int by Delegate()
+
+class Delegate {
+  fun get(<!UNUSED_PARAMETER!>t<!>: Nothing?, p: String): Int {
+    p.equals(null) // to avoid UNUSED_PARAMETER warning
+    return 1
+  }
+  fun set(<!UNUSED_PARAMETER!>t<!>: Nothing?, p: String, a: Int) {
+    p.equals(a) // to avoid UNUSED_PARAMETER warning
+  }
+}

compiler/testData/diagnostics/tests/delegatedProperty/thisOfNothingType.kt

@@ -0,0 +1,15 @@
+class A {
+  var a: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE, DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+}
+
+var aTopLevel: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE, DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+
+class Delegate {
+  fun get(<!UNUSED_PARAMETER!>t<!>: Nothing, p: String): Int {
+    p.equals(null) // to avoid UNUSED_PARAMETER warning
+    return 1
+  }
+  fun set(<!UNUSED_PARAMETER!>t<!>: Nothing, p: String, a: Int) {
+    p.equals(a) // to avoid UNUSED_PARAMETER warning
+  }
+}

compiler/testData/diagnostics/tests/delegatedProperty/twoGetMethods.kt

@@ -0,0 +1,15 @@
+class A {
+    val c: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+}
+
+class Delegate {
+    fun get(t: Int, p: String): Int {
+        t.equals(p) // to avoid UNUSED_PARAMETER warning
+        return 1
+    }
+
+    fun get(t: String, p: String): Int {
+        t.equals(p) // to avoid UNUSED_PARAMETER warning
+        return 1
+    }
+}

compiler/testData/diagnostics/tests/delegatedProperty/typeMismatchForGetReturnType.kt

@@ -0,0 +1,8 @@
+val c: Int by <!DELEGATE_SPECIAL_FUNCTION_RETURN_TYPE_MISMATCH!>Delegate()<!>
+
+class Delegate {
+  fun get(t: Any?, p: String): String {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    return ""
+  }
+}

compiler/testData/diagnostics/tests/delegatedProperty/typeMismatchForGetWithGeneric.kt

@@ -0,0 +1,20 @@
+class A
+
+class B {
+  val b: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate<A>()<!>
+}
+
+val bTopLevel: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate<A>()<!>
+
+class C {
+  val c: Int by Delegate<C>()
+}
+
+val cTopLevel: Int by Delegate<Nothing?>()
+
+class Delegate<T> {
+  fun get(t: T, p: String): Int {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    return 1
+  }
+}

compiler/testData/diagnostics/tests/delegatedProperty/typeMismatchForSetParameter.kt

@@ -0,0 +1,16 @@
+class A {
+  var a: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+}
+
+var aTopLevel: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+
+class Delegate {
+  fun get(t: Any?, p: String): Int {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    return 1
+  }
+  fun set(t: Any?, p: String, i: String) {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    i.equals(null)
+  }
+}

compiler/testData/diagnostics/tests/delegatedProperty/typeMismatchForThisGetParameter.kt

@@ -0,0 +1,15 @@
+class B {
+  val b: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+}
+
+val bTopLevel: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+
+class A
+
+class Delegate {
+  fun get(t: A, p: String): Int {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    return 1
+  }
+}
+

compiler/testData/diagnostics/tests/delegatedProperty/wrongCountOfParametersInGet.kt

@@ -0,0 +1,12 @@
+class A {
+  val a: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+}
+
+val aTopLevel: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+
+class Delegate {
+  fun get(t: Any?, p: String, a: Int): Int {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    return a
+  }
+}

compiler/testData/diagnostics/tests/delegatedProperty/wrongCountOfParametersInSet.kt

@@ -0,0 +1,17 @@
+class A {
+  var a: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+}
+
+var aTopLevel: Int by <!DELEGATE_SPECIAL_FUNCTION_NONE_APPLICABLE!>Delegate()<!>
+
+class Delegate {
+  fun get(t: Any?, p: String): Int {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    return 1
+  }
+
+  fun set(t: Any?, p: String, a: Int, c: Int) {
+    t.equals(p) // to avoid UNUSED_PARAMETER warning
+    c.equals(a)
+  }
+}

compiler/testData/diagnostics/tests/delegatedProperty/wrongSetterReturnType.kt

@@ -0,0 +1,13 @@
+var b: Int by Delegate()
+
+class Delegate {
+    fun get(t: Any?, p: String): Int {
+      t.equals(p) // to avoid UNUSED_PARAMETER warning
+      return 1
+    }
+
+    fun set(t: Any?, p: String, i: Int): Int {
+      t.equals(p) // to avoid UNUSED_PARAMETER warning
+      return i
+    }
+}