Fix KotlinCodeStyleSettings and IDEKotlinBinaryClassCache.kt 191 compilation

This commit is contained in:
Vladimir Dolzhenko
2019-09-24 22:01:05 +02:00
parent c961de7289
commit a98c610958
3 changed files with 25 additions and 8 deletions
@@ -18,7 +18,6 @@ package org.jetbrains.kotlin.idea.core.formatter;
import com.intellij.application.options.CodeStyle; import com.intellij.application.options.CodeStyle;
import com.intellij.openapi.application.ApplicationManager; import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.components.Service;
import com.intellij.openapi.components.ServiceManager; import com.intellij.openapi.components.ServiceManager;
import com.intellij.openapi.project.Project; import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.InvalidDataException; import com.intellij.openapi.util.InvalidDataException;
@@ -185,8 +184,7 @@ public class KotlinCodeStyleSettings extends CustomCodeStyleSettings {
return ServiceManager.getService(KotlinCodeStyleSettingsHolder.class).defaultSettings; return ServiceManager.getService(KotlinCodeStyleSettingsHolder.class).defaultSettings;
} }
@Service public static final class KotlinCodeStyleSettingsHolder {
private static final class KotlinCodeStyleSettingsHolder {
private final KotlinCodeStyleSettings defaultSettings = new KotlinCodeStyleSettings(new CodeStyleSettings()); private final KotlinCodeStyleSettings defaultSettings = new KotlinCodeStyleSettings(new CodeStyleSettings());
} }
} }
@@ -17,7 +17,6 @@
package org.jetbrains.kotlin.idea.caches package org.jetbrains.kotlin.idea.caches
import com.intellij.ide.highlighter.JavaClassFileType import com.intellij.ide.highlighter.JavaClassFileType
import com.intellij.openapi.components.Service
import com.intellij.openapi.components.ServiceManager import com.intellij.openapi.components.ServiceManager
import com.intellij.openapi.components.service import com.intellij.openapi.components.service
import com.intellij.openapi.util.Key import com.intellij.openapi.util.Key
@@ -30,7 +29,6 @@ import org.jetbrains.kotlin.load.kotlin.header.KotlinClassHeader
import org.jetbrains.kotlin.metadata.jvm.deserialization.JvmMetadataVersion import org.jetbrains.kotlin.metadata.jvm.deserialization.JvmMetadataVersion
import org.jetbrains.kotlin.name.ClassId import org.jetbrains.kotlin.name.ClassId
@Service
class IDEKotlinBinaryClassCache { class IDEKotlinBinaryClassCache {
class KotlinBinaryClassHeaderData( class KotlinBinaryClassHeaderData(
val classId: ClassId, val classId: ClassId,
@@ -138,5 +136,18 @@ class IDEKotlinBinaryClassCache {
companion object { companion object {
fun getInstance(): IDEKotlinBinaryClassCache = service() fun getInstance(): IDEKotlinBinaryClassCache = service()
// @JvmStatic @Volatile
// private var instance: IDEKotlinBinaryClassCache? = null
//
// fun getInstance(): IDEKotlinBinaryClassCache {
// if (instance == null) {
// synchronized(IDEKotlinBinaryClassCache::class.java) {
// if (instance == null) {
// instance = IDEKotlinBinaryClassCache()
// }
// }
// }
// return instance!!
// }
} }
} }
+11 -3
View File
@@ -251,12 +251,20 @@
<applicationService serviceInterface="org.jetbrains.kotlin.idea.KotlinPluginUpdater" <applicationService serviceInterface="org.jetbrains.kotlin.idea.KotlinPluginUpdater"
serviceImplementation="org.jetbrains.kotlin.idea.KotlinPluginUpdater"/> serviceImplementation="org.jetbrains.kotlin.idea.KotlinPluginUpdater"/>
<projectService serviceInterface="org.jetbrains.kotlin.idea.util.ImportInsertHelper"
serviceImplementation="org.jetbrains.kotlin.idea.util.ImportInsertHelperImpl"/>
<applicationService serviceInterface="org.jetbrains.kotlin.psi.KotlinDeclarationNavigationPolicy" <applicationService serviceInterface="org.jetbrains.kotlin.psi.KotlinDeclarationNavigationPolicy"
serviceImplementation="org.jetbrains.kotlin.idea.decompiler.navigation.KotlinDeclarationNavigationPolicyImpl"/> serviceImplementation="org.jetbrains.kotlin.idea.decompiler.navigation.KotlinDeclarationNavigationPolicyImpl"/>
<!-- since 192 use light service @Service instead of this declaration -->
<applicationService serviceInterface="org.jetbrains.kotlin.idea.caches.IDEKotlinBinaryClassCache"
serviceImplementation="org.jetbrains.kotlin.idea.caches.IDEKotlinBinaryClassCache"/>
<!-- since 192 use light service @Service instead of this declaration -->
<applicationService serviceInterface="org.jetbrains.kotlin.idea.core.formatter.KotlinCodeStyleSettings$KotlinCodeStyleSettingsHolder"
serviceImplementation="org.jetbrains.kotlin.idea.core.formatter.KotlinCodeStyleSettings$KotlinCodeStyleSettingsHolder"/>
<projectService serviceInterface="org.jetbrains.kotlin.idea.util.ImportInsertHelper"
serviceImplementation="org.jetbrains.kotlin.idea.util.ImportInsertHelperImpl"/>
<projectService serviceInterface="org.jetbrains.kotlin.analyzer.KotlinModificationTrackerService" <projectService serviceInterface="org.jetbrains.kotlin.analyzer.KotlinModificationTrackerService"
serviceImplementation="org.jetbrains.kotlin.idea.caches.trackers.KotlinIDEModificationTrackerService"/> serviceImplementation="org.jetbrains.kotlin.idea.caches.trackers.KotlinIDEModificationTrackerService"/>