"Remove braces from 'if' statement": do not suggest when lambda is directly under 'if'

#KT-35994 Fixed

idea/src/org/jetbrains/kotlin/idea/intentions/RemoveBracesIntention.kt

@@ -38,6 +38,7 @@ class RemoveBracesIntention : SelfTargetingIntention<KtElement>(KtElement::class
     override fun isApplicableTo(element: KtElement, caretOffset: Int): Boolean {
         val block = element.findChildBlock() ?: return false
         val singleStatement = block.statements.singleOrNull() ?: return false
+        if (singleStatement is KtLambdaExpression && singleStatement.functionLiteral.arrow == null) return false
         when (val container = block.parent) {
             is KtContainerNode -> {
                 if (singleStatement is KtIfExpression) {
@@ -52,12 +53,12 @@ class RemoveBracesIntention : SelfTargetingIntention<KtElement>(KtElement::class
             is KtWhenEntry -> {
                 text = KotlinBundle.message("remove.braces.from.when.entry")
                 return singleStatement !is KtNamedDeclaration
-                        && !(singleStatement is KtLambdaExpression && singleStatement.functionLiteral.arrow == null)
             }
             else -> return false
         }
     }
 
+
     override fun applyTo(element: KtElement, editor: Editor?) {
         val block = element.findChildBlock() ?: return
         val factory = KtPsiFactory(element)

idea/testData/intentions/removeBraces/elseLambda.kt

@@ -0,0 +1,9 @@
+// IS_APPLICABLE: false
+fun test(i: Int) {
+    val predicate: () -> Boolean =
+        if (i == 1) {
+            { true }
+        } else {
+            <caret>{ false }
+        }
+}

idea/testData/intentions/removeBraces/elseLambda2.kt

@@ -0,0 +1,8 @@
+fun test(i: Int) {
+    val predicate: () -> Boolean =
+        if (i == 1) {
+            { true }
+        } else {
+            <caret>{ -> false }
+        }
+}

idea/testData/intentions/removeBraces/elseLambda2.kt.after

@@ -0,0 +1,6 @@
+fun test(i: Int) {
+    val predicate: () -> Boolean =
+        if (i == 1) {
+            { true }
+        } else { -> false }
+}

idea/testData/intentions/removeBraces/ifLambda.kt

@@ -0,0 +1,9 @@
+// IS_APPLICABLE: false
+fun test(i: Int) {
+    val predicate: () -> Boolean =
+        if (i == 1) {
+            <caret>{ true }
+        } else {
+            { false }
+        }
+}

idea/testData/intentions/removeBraces/ifLambda2.kt

@@ -0,0 +1,8 @@
+fun test(i: Int) {
+    val predicate: () -> Boolean =
+        if (i == 1) {
+            <caret>{ -> true }
+        } else {
+            { false }
+        }
+}

idea/testData/intentions/removeBraces/ifLambda2.kt.after

@@ -0,0 +1,6 @@
+fun test(i: Int) {
+    val predicate: () -> Boolean =
+        if (i == 1) { -> true } else {
+            { false }
+        }
+}

idea/tests/org/jetbrains/kotlin/idea/intentions/IntentionTestGenerated.java

@@ -13024,6 +13024,16 @@ public class IntentionTestGenerated extends AbstractIntentionTest {
             runTest("idea/testData/intentions/removeBraces/elseInPlusAssignExpression.kt");
         }
 
+        @TestMetadata("elseLambda.kt")
+        public void testElseLambda() throws Exception {
+            runTest("idea/testData/intentions/removeBraces/elseLambda.kt");
+        }
+
+        @TestMetadata("elseLambda2.kt")
+        public void testElseLambda2() throws Exception {
+            runTest("idea/testData/intentions/removeBraces/elseLambda2.kt");
+        }
+
         @TestMetadata("for.kt")
         public void testFor() throws Exception {
             runTest("idea/testData/intentions/removeBraces/for.kt");
@@ -13079,6 +13089,16 @@ public class IntentionTestGenerated extends AbstractIntentionTest {
             runTest("idea/testData/intentions/removeBraces/ifInsideIf7.kt");
         }
 
+        @TestMetadata("ifLambda.kt")
+        public void testIfLambda() throws Exception {
+            runTest("idea/testData/intentions/removeBraces/ifLambda.kt");
+        }
+
+        @TestMetadata("ifLambda2.kt")
+        public void testIfLambda2() throws Exception {
+            runTest("idea/testData/intentions/removeBraces/ifLambda2.kt");
+        }
+
         @TestMetadata("ifWithComment.kt")
         public void testIfWithComment() throws Exception {
             runTest("idea/testData/intentions/removeBraces/ifWithComment.kt");