azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] Verify diagnostic messages don't reference non-existent parameters

Browse Source
This commit is contained in:
Kirill Rakhman
2023-04-26 16:19:27 +02:00
committed by Space Team
parent c956b4aeae
commit a818c543a9
5 changed files with 39 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/frontend.common/src/org/jetbrains/kotlin/diagnostics/KtDiagnosticRenderer.kt
+4 -2
View File
@@ -5,17 +5,19 @@
package org.jetbrains.kotlin.diagnostics
import com.google.common.annotations.VisibleForTesting
import org.jetbrains.kotlin.diagnostics.rendering.DiagnosticParameterRenderer
import org.jetbrains.kotlin.diagnostics.rendering.RenderingContext
import org.jetbrains.kotlin.diagnostics.rendering.renderParameter
import java.text.MessageFormat
sealed interface KtDiagnosticRenderer {
@VisibleForTesting val message: String
fun render(diagnostic: KtDiagnostic): String
fun renderParameters(diagnostic: KtDiagnostic): Array<out Any?>
}
class SimpleKtDiagnosticRenderer(private val message: String) : KtDiagnosticRenderer {
class SimpleKtDiagnosticRenderer(override val message: String) : KtDiagnosticRenderer {
override fun render(diagnostic: KtDiagnostic): String {
require(diagnostic is KtSimpleDiagnostic)
return message
@@ -28,7 +30,7 @@ class SimpleKtDiagnosticRenderer(private val message: String) : KtDiagnosticRend
}
sealed class AbstractKtDiagnosticWithParametersRenderer(
protected val message: String
final override val message: String
) : KtDiagnosticRenderer {
private val messageFormat = MessageFormat(message)