azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FirFunctionParameterChecker: use reportOnWithSuppression

Browse Source
This commit is contained in:
Mikhail Glukhikh
2021-03-17 10:48:11 +03:00
parent 94de193993
commit a6d11b8914
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/declaration/FirFunctionParameterChecker.kt
+6 -6
View File
@@ -10,7 +10,7 @@ import org.jetbrains.kotlin.fir.analysis.checkers.context.CheckerContext
import org.jetbrains.kotlin.fir.analysis.checkers.isInline import org.jetbrains.kotlin.fir.analysis.checkers.isInline
import org.jetbrains.kotlin.fir.analysis.diagnostics.DiagnosticReporter import org.jetbrains.kotlin.fir.analysis.diagnostics.DiagnosticReporter
import org.jetbrains.kotlin.fir.analysis.diagnostics.FirErrors import org.jetbrains.kotlin.fir.analysis.diagnostics.FirErrors
import org.jetbrains.kotlin.fir.analysis.diagnostics.reportOn import org.jetbrains.kotlin.fir.analysis.diagnostics.reportOnWithSuppression
import org.jetbrains.kotlin.fir.declarations.FirFunction import org.jetbrains.kotlin.fir.declarations.FirFunction
import org.jetbrains.kotlin.fir.diagnostics.ConeSimpleDiagnostic import org.jetbrains.kotlin.fir.diagnostics.ConeSimpleDiagnostic
import org.jetbrains.kotlin.fir.diagnostics.DiagnosticKind import org.jetbrains.kotlin.fir.diagnostics.DiagnosticKind
@@ -36,8 +36,8 @@ object FirFunctionParameterChecker : FirFunctionChecker() {
val diagnostic = returnTypeRef.diagnostic val diagnostic = returnTypeRef.diagnostic
if (diagnostic is ConeSimpleDiagnostic && diagnostic.kind == DiagnosticKind.ValueParameterWithNoTypeAnnotation) { if (diagnostic is ConeSimpleDiagnostic && diagnostic.kind == DiagnosticKind.ValueParameterWithNoTypeAnnotation) {
reporter.reportOn( reporter.reportOnWithSuppression(
valueParameter.source, valueParameter,
FirErrors.VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION, FirErrors.VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION,
context context
) )
@@ -49,7 +49,7 @@ object FirFunctionParameterChecker : FirFunctionChecker() {
val varargParameters = function.valueParameters.filter { it.isVararg } val varargParameters = function.valueParameters.filter { it.isVararg }
if (varargParameters.size > 1) { if (varargParameters.size > 1) {
for (parameter in varargParameters) { for (parameter in varargParameters) {
reporter.reportOn(parameter.source ?: continue, FirErrors.MULTIPLE_VARARG_PARAMETERS, context) reporter.reportOnWithSuppression(parameter, FirErrors.MULTIPLE_VARARG_PARAMETERS, context)
} }
} }
@@ -61,8 +61,8 @@ object FirFunctionParameterChecker : FirFunctionChecker() {
// Note: comparing with FE1.0, we skip checking if the type is not primitive because primitive types are not inline. That // Note: comparing with FE1.0, we skip checking if the type is not primitive because primitive types are not inline. That
// is any primitive values are already allowed by the inline check. // is any primitive values are already allowed by the inline check.
) { ) {
reporter.reportOn( reporter.reportOnWithSuppression(
varargParameter.source ?: continue, varargParameter,
FirErrors.FORBIDDEN_VARARG_PARAMETER_TYPE, FirErrors.FORBIDDEN_VARARG_PARAMETER_TYPE,
varargParameterType, varargParameterType,
context context