azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] Remove the applicability filtering when reporting diagnostics

Browse Source 
In case we don't want to introduce any new
abstractions like "user relevance for
applicability", we can just remove the
filtering.

^KT-62541 Fixed
This commit is contained in:
Nikolay Lunyak
2023-10-13 16:23:49 +03:00
committed by Space Team
parent fedadfb8db
commit a68a2409d3
22 changed files with 32 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/assign-plugin/testData/diagnostics/otherOperators.fir.diag.txt
Vendored
+4
View File
@@ -22,10 +22,14 @@
/otherOperators.fir.kt:(1057,1066): error: No 'set' operator method providing array access.
/otherOperators.fir.kt:(1117,1130): error: 'operator' modifier is required on 'FirNamedFunctionSymbol /StringProperty.get' in 'get'.
/otherOperators.fir.kt:(1128,1129): error: Too many arguments for 'public final fun /StringProperty.get(): kotlin/String'.
/otherOperators.fir.kt:(1131,1133): error: Unresolved reference '+='.
/otherOperators.fir.kt:(1161,1179): error: 'operator' modifier is required on 'FirNamedFunctionSymbol /StringProperty.get' in 'get'.
/otherOperators.fir.kt:(1177,1178): error: Too many arguments for 'public final fun /StringProperty.get(): kotlin/String'.
/otherOperators.fir.kt:(1180,1182): error: Unresolved reference '+='.
plugins/assign-plugin/testData/diagnostics/otherOperators.fir.kt
Vendored
+2 -2
View File
@@ -42,8 +42,8 @@ fun `should not effect error reporting for other operators`() {
nullTask?.input<!NO_SET_METHOD!>[0, 0, 0]<!> = StringProperty("Fail")
// a?.b[c] += d
task.input[<!TOO_MANY_ARGUMENTS!>0<!>] <!UNRESOLVED_REFERENCE!>+=<!> StringProperty("Fail")
nullTask?.input[<!TOO_MANY_ARGUMENTS!>0<!>] <!UNRESOLVED_REFERENCE!>+=<!> StringProperty("Fail")
<!OPERATOR_MODIFIER_REQUIRED!>task.input[<!TOO_MANY_ARGUMENTS!>0<!>]<!> <!UNRESOLVED_REFERENCE!>+=<!> StringProperty("Fail")
<!OPERATOR_MODIFIER_REQUIRED!>nullTask?.input[<!TOO_MANY_ARGUMENTS!>0<!>]<!> <!UNRESOLVED_REFERENCE!>+=<!> StringProperty("Fail")
// a[i] = b should not be translated to a.get(i).assign(b)
operator fun Task.get(i: Int) = this.input