Mpp: KT-23457, fix importing common classes into common modules

Add test for KT-23457
NOTE: fixes 'importClassInCommon' test
Other test cases added to increase coverage

 #KT-23457 Fixed

idea/src/org/jetbrains/kotlin/idea/quickfix/ImportFix.kt

@@ -625,13 +625,12 @@ internal object ImportForMissingOperatorFactory : ImportFixBase.Factory() {
 
 
 private fun KotlinIndicesHelper.getClassesByName(expressionForPlatform: KtExpression, name: String) =
-        when (TargetPlatformDetector.getPlatform(expressionForPlatform.containingKtFile)) {
+    when (TargetPlatformDetector.getPlatform(expressionForPlatform.containingKtFile)) {
-            JsPlatform -> getKotlinClasses({ it == name },
+        JvmPlatform -> getJvmClassesByName(name)
-                    // Enum entries should be contributes with members import fix
+        else -> getKotlinClasses({ it == name },
-                                           psiFilter = { ktDeclaration -> ktDeclaration !is KtEnumEntry },
+            // Enum entries should be contributes with members import fix
-                                           kindFilter = { kind -> kind != ClassKind.ENUM_ENTRY })
+                                 psiFilter = { ktDeclaration -> ktDeclaration !is KtEnumEntry },
-            JvmPlatform -> getJvmClassesByName(name)
+                                 kindFilter = { kind -> kind != ClassKind.ENUM_ENTRY })
-            else -> emptyList()
+    }
-        }
 
 private fun CallTypeAndReceiver<*, *>.toFilter() = { descriptor: DeclarationDescriptor -> this.callType.descriptorKindFilter.accepts(descriptor) }

idea/testData/multiModuleQuickFix/importClassInCommon/common/a.kt

@@ -0,0 +1,3 @@
+package foo
+
+class Foo

idea/testData/multiModuleQuickFix/importClassInCommon/common/a.kt.after

@@ -0,0 +1,3 @@
+package foo
+
+class Foo

idea/testData/multiModuleQuickFix/importClassInCommon/common/b.kt

@@ -0,0 +1,7 @@
+// "Import" "true"
+// ERROR: Unresolved reference: Foo
+package bar
+
+fun use(f: <caret>Foo) {
+
+}

idea/testData/multiModuleQuickFix/importClassInCommon/common/b.kt.after

@@ -0,0 +1,9 @@
+// "Import" "true"
+// ERROR: Unresolved reference: Foo
+package bar
+
+import foo.Foo
+
+fun use(f: Foo) {
+
+}

idea/testData/multiModuleQuickFix/importClassInFromProductionInCommonTests/a_common/a.kt

@@ -0,0 +1,3 @@
+package foo
+
+class Foo

idea/testData/multiModuleQuickFix/importClassInFromProductionInCommonTests/a_common/a.kt.after

@@ -0,0 +1,3 @@
+package foo
+
+class Foo

idea/testData/multiModuleQuickFix/importClassInFromProductionInCommonTests/a_common_test/b.kt

@@ -0,0 +1,7 @@
+// "Import" "true"
+// ERROR: Unresolved reference: Foo
+package bar
+
+fun use(f: <caret>Foo) {
+
+}

idea/testData/multiModuleQuickFix/importClassInFromProductionInCommonTests/a_common_test/b.kt.after

@@ -0,0 +1,9 @@
+// "Import" "true"
+// ERROR: Unresolved reference: Foo
+package bar
+
+import foo.Foo
+
+fun use(f: Foo) {
+
+}

idea/testData/multiModuleQuickFix/importCommonClassInJs/common/a.kt

@@ -0,0 +1,3 @@
+package foo
+
+class Foo

idea/testData/multiModuleQuickFix/importCommonClassInJs/js/b.kt

@@ -0,0 +1,7 @@
+// "Import" "true"
+// ERROR: Unresolved reference: Foo
+package bar
+
+fun use(f: <caret>Foo) {
+
+}

idea/testData/multiModuleQuickFix/importCommonClassInJs/js/b.kt.after

@@ -0,0 +1,9 @@
+// "Import" "true"
+// ERROR: Unresolved reference: Foo
+package bar
+
+import foo.Foo
+
+fun use(f: Foo) {
+
+}

idea/testData/multiModuleQuickFix/importCommonClassInJvm/common/a.kt

@@ -0,0 +1,3 @@
+package foo
+
+class Foo

idea/testData/multiModuleQuickFix/importCommonClassInJvm/jvm/b.kt

@@ -0,0 +1,7 @@
+// "Import" "true"
+// ERROR: Unresolved reference: Foo
+package bar
+
+fun use(f: <caret>Foo) {
+
+}

idea/testData/multiModuleQuickFix/importCommonClassInJvm/jvm/b.kt.after

@@ -0,0 +1,9 @@
+// "Import" "true"
+// ERROR: Unresolved reference: Foo
+package bar
+
+import foo.Foo
+
+fun use(f: Foo) {
+
+}

idea/testData/multiModuleQuickFix/importCommonFunInJvm/common/a.kt

@@ -0,0 +1,6 @@
+
+package foo
+
+fun foo() {
+
+}

idea/testData/multiModuleQuickFix/importCommonFunInJvm/jvm/b.kt

@@ -0,0 +1,7 @@
+// "Import" "true"
+// ERROR: Unresolved reference: foo
+package bar
+
+fun use() {
+    <caret>foo()
+}

idea/testData/multiModuleQuickFix/importCommonFunInJvm/jvm/b.kt.after

@@ -0,0 +1,9 @@
+// "Import" "true"
+// ERROR: Unresolved reference: foo
+package bar
+
+import foo.foo
+
+fun use() {
+    foo()
+}

idea/testData/multiModuleQuickFix/importExpectClassWithActualInJvm/common/a.kt

@@ -0,0 +1,3 @@
+package foo
+
+expect class Foo

idea/testData/multiModuleQuickFix/importExpectClassWithActualInJvm/jvm/a_jvm.kt

@@ -0,0 +1,3 @@
+package foo
+
+actual class Foo

idea/testData/multiModuleQuickFix/importExpectClassWithActualInJvm/jvm/b.kt

@@ -0,0 +1,7 @@
+// "Import" "true"
+// ERROR: Unresolved reference: Foo
+package bar
+
+fun use(f: <caret>Foo) {
+
+}

idea/testData/multiModuleQuickFix/importExpectClassWithActualInJvm/jvm/b.kt.after

@@ -0,0 +1,9 @@
+// "Import" "true"
+// ERROR: Unresolved reference: Foo
+package bar
+
+import foo.Foo
+
+fun use(f: Foo) {
+
+}

idea/testData/multiModuleQuickFix/importExpectClassWithoutActualInJvm/common/a.kt

@@ -0,0 +1,3 @@
+package foo
+
+expect class Foo

idea/testData/multiModuleQuickFix/importExpectClassWithoutActualInJvm/jvm/b.kt

@@ -0,0 +1,13 @@
+// "Import" "false"
+// ACTION: Create annotation 'Foo'
+// ACTION: Create class 'Foo'
+// ACTION: Create enum 'Foo'
+// ACTION: Create interface 'Foo'
+// ACTION: Create type alias 'Foo'
+// ACTION: Create type parameter 'Foo' in function 'use'
+// ERROR: Unresolved reference: Foo
+package bar
+
+fun use(f: <caret>Foo) {
+
+}

idea/testData/multiModuleQuickFix/importExpectClassWithoutActualInJvm/jvm/b.kt.after

@@ -0,0 +1,13 @@
+// "Import" "false"
+// ACTION: Create annotation 'Foo'
+// ACTION: Create class 'Foo'
+// ACTION: Create enum 'Foo'
+// ACTION: Create interface 'Foo'
+// ACTION: Create type alias 'Foo'
+// ACTION: Create type parameter 'Foo' in function 'use'
+// ERROR: Unresolved reference: Foo
+package bar
+
+fun use(f: Foo) {
+
+}

idea/testData/multiModuleQuickFix/importFunInCommon/common/a.kt

@@ -0,0 +1,6 @@
+
+package foo
+
+fun foo() {
+
+}

idea/testData/multiModuleQuickFix/importFunInCommon/common/b.kt

@@ -0,0 +1,7 @@
+// "Import" "true"
+// ERROR: Unresolved reference: foo
+package bar
+
+fun use() {
+    <caret>foo()
+}

idea/testData/multiModuleQuickFix/importFunInCommon/common/b.kt.after

@@ -0,0 +1,9 @@
+// "Import" "true"
+// ERROR: Unresolved reference: foo
+package bar
+
+import foo.foo
+
+fun use() {
+    foo()
+}

idea/tests/org/jetbrains/kotlin/idea/quickfix/QuickFixMultiModuleTestGenerated.java

@@ -184,6 +184,46 @@ public class QuickFixMultiModuleTestGenerated extends AbstractQuickFixMultiModul
         runTest("idea/testData/multiModuleQuickFix/implementMembersInImplClassNonImplInheritor/");
     }
 
+    @TestMetadata("importClassInCommon")
+    public void testImportClassInCommon() throws Exception {
+        runTest("idea/testData/multiModuleQuickFix/importClassInCommon/");
+    }
+
+    @TestMetadata("importClassInFromProductionInCommonTests")
+    public void testImportClassInFromProductionInCommonTests() throws Exception {
+        runTest("idea/testData/multiModuleQuickFix/importClassInFromProductionInCommonTests/");
+    }
+
+    @TestMetadata("importCommonClassInJs")
+    public void testImportCommonClassInJs() throws Exception {
+        runTest("idea/testData/multiModuleQuickFix/importCommonClassInJs/");
+    }
+
+    @TestMetadata("importCommonClassInJvm")
+    public void testImportCommonClassInJvm() throws Exception {
+        runTest("idea/testData/multiModuleQuickFix/importCommonClassInJvm/");
+    }
+
+    @TestMetadata("importCommonFunInJvm")
+    public void testImportCommonFunInJvm() throws Exception {
+        runTest("idea/testData/multiModuleQuickFix/importCommonFunInJvm/");
+    }
+
+    @TestMetadata("importExpectClassWithActualInJvm")
+    public void testImportExpectClassWithActualInJvm() throws Exception {
+        runTest("idea/testData/multiModuleQuickFix/importExpectClassWithActualInJvm/");
+    }
+
+    @TestMetadata("importExpectClassWithoutActualInJvm")
+    public void testImportExpectClassWithoutActualInJvm() throws Exception {
+        runTest("idea/testData/multiModuleQuickFix/importExpectClassWithoutActualInJvm/");
+    }
+
+    @TestMetadata("importFunInCommon")
+    public void testImportFunInCommon() throws Exception {
+        runTest("idea/testData/multiModuleQuickFix/importFunInCommon/");
+    }
+
     @TestMetadata("interface")
     public void testInterface() throws Exception {
         runTest("idea/testData/multiModuleQuickFix/interface/");