From a4b62868fa579780c7cfa997ca05661ccf92a2d7 Mon Sep 17 00:00:00 2001
From: Stepan Koltsov <stepan.koltsov@jetbrains.com>
Date: Thu, 10 Nov 2011 20:00:34 +0400
Subject: [PATCH] KT-424 also check overloads in namespaces

---
 .../FunctionSignatureDiagnosticFactory.java   |  4 +-
 .../jet/lang/resolve/OverloadResolver.java    | 42 ++++++++++++++++---
 .../quick/ConflictingOverloads.jet            | 28 +++++++++++++
 3 files changed, 67 insertions(+), 7 deletions(-)

diff --git a/compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/FunctionSignatureDiagnosticFactory.java b/compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/FunctionSignatureDiagnosticFactory.java
index cea7b7f3f4c..4f5e64a5288 100644
--- a/compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/FunctionSignatureDiagnosticFactory.java
+++ b/compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/FunctionSignatureDiagnosticFactory.java
@@ -18,14 +18,14 @@ public class FunctionSignatureDiagnosticFactory extends DiagnosticFactoryWithMes
 
     @NotNull
     public Diagnostic on(@NotNull JetNamedFunction functionElement, @NotNull FunctionDescriptor functionDescriptor,
-                         @NotNull JetClassOrObject jetClassOrObject)
+                         @NotNull String functionContainer)
     {
         TextRange rangeToMark = new TextRange(
                 functionElement.getStartOfSignatureElement().getTextRange().getStartOffset(),
                 functionElement.getEndOfSignatureElement().getTextRange().getEndOffset()
             );
         String message = messageFormat.format(new Object[]{
-                jetClassOrObject.getName(),
+                functionContainer,
                 DescriptorRenderer.TEXT.render(functionDescriptor)});
         return new GenericDiagnostic(this, severity, message, functionElement.getContainingFile(), rangeToMark);
     }
diff --git a/compiler/frontend/src/org/jetbrains/jet/lang/resolve/OverloadResolver.java b/compiler/frontend/src/org/jetbrains/jet/lang/resolve/OverloadResolver.java
index 08a4e044179..de621ebf5d0 100644
--- a/compiler/frontend/src/org/jetbrains/jet/lang/resolve/OverloadResolver.java
+++ b/compiler/frontend/src/org/jetbrains/jet/lang/resolve/OverloadResolver.java
@@ -1,10 +1,11 @@
 package org.jetbrains.jet.lang.resolve;
 
+import com.intellij.openapi.util.Pair;
 import com.intellij.psi.PsiElement;
 import com.intellij.util.containers.MultiMap;
 import org.jetbrains.annotations.NotNull;
-import org.jetbrains.jet.lang.descriptors.FunctionDescriptor;
-import org.jetbrains.jet.lang.descriptors.MutableClassDescriptor;
+import org.jetbrains.annotations.Nullable;
+import org.jetbrains.jet.lang.descriptors.*;
 import org.jetbrains.jet.lang.diagnostics.Errors;
 import org.jetbrains.jet.lang.psi.*;
 
@@ -36,6 +37,37 @@ public class OverloadResolver {
         for (Map.Entry<JetObjectDeclaration, MutableClassDescriptor> entry : context.getObjects().entrySet()) {
             checkOverloadsInAClass(entry.getValue(), entry.getKey());
         }
+        checkOverloadsInANamespace();
+    }
+
+    private void checkOverloadsInANamespace() {
+        class Key extends Pair<String, String> {
+            Key(String namespace, String name) {
+                super(namespace, name);
+            }
+            
+            public String getNamespace() {
+                return first;
+            }
+            
+            public String getFunctionName() {
+                return second;
+            }
+        }
+
+        MultiMap<Key, FunctionDescriptor> functionsByName = MultiMap.create();
+
+        for (FunctionDescriptorImpl function : context.getFunctions().values()) {
+            DeclarationDescriptor containingDeclaration = function.getContainingDeclaration();
+            if (containingDeclaration instanceof NamespaceDescriptor) {
+                NamespaceDescriptor namespaceDescriptor = (NamespaceDescriptor) containingDeclaration;
+                functionsByName.putValue(new Key(namespaceDescriptor.getName(), function.getName()), function);
+            }
+        }
+
+        for (Map.Entry<Key, Collection<FunctionDescriptor>> e : functionsByName.entrySet()) {
+            checkOverloadsWithSameName(e.getKey().getFunctionName(), e.getValue(), e.getKey().getNamespace());
+        }
     }
 
     private void checkOverloadsInAClass(MutableClassDescriptor classDescriptor, JetClassOrObject klass) {
@@ -46,7 +78,7 @@ public class OverloadResolver {
         }
         
         for (Map.Entry<String, Collection<FunctionDescriptor>> e : functionsByName.entrySet()) {
-            checkOverloadsWithSameName(e.getKey(), e.getValue(), klass);
+            checkOverloadsWithSameName(e.getKey(), e.getValue(), klass.getName());
         }
 
         // properties are checked elsewhere
@@ -55,7 +87,7 @@ public class OverloadResolver {
 
     }
     
-    private void checkOverloadsWithSameName(String name, Collection<FunctionDescriptor> functions, JetClassOrObject klass) {
+    private void checkOverloadsWithSameName(String name, Collection<FunctionDescriptor> functions, String functionContainer) {
         if (functions.size() == 1) {
             // microoptimization
             return;
@@ -75,7 +107,7 @@ public class OverloadResolver {
                         return;
                     }
 
-                    context.getTrace().report(Errors.CONFLICTING_OVERLOADS.on(member, function, klass));
+                    context.getTrace().report(Errors.CONFLICTING_OVERLOADS.on(member, function, functionContainer));
                 }
             }
         }
diff --git a/compiler/testData/checkerWithErrorTypes/quick/ConflictingOverloads.jet b/compiler/testData/checkerWithErrorTypes/quick/ConflictingOverloads.jet
index 84260a7cbd0..ab9380427fb 100644
--- a/compiler/testData/checkerWithErrorTypes/quick/ConflictingOverloads.jet
+++ b/compiler/testData/checkerWithErrorTypes/quick/ConflictingOverloads.jet
@@ -12,3 +12,31 @@ class A {
     <!CONFLICTING_OVERLOADS!>fun b()<!> {
     }
 }
+
+namespace deepSpace {
+    <!CONFLICTING_OVERLOADS!>fun c(s: String)<!> {
+    }
+
+    <!CONFLICTING_OVERLOADS!>fun c(s: String)<!> {
+    }
+
+    class B {
+        <!CONFLICTING_OVERLOADS!>fun d(s: String)<!> {
+        }
+
+        <!CONFLICTING_OVERLOADS!>fun d(s: String)<!> {
+        }
+    }
+}
+
+
+// check no error in overload in different namespaces
+
+namespace ns1 {
+    fun e() = 1
+}
+
+namespace ns2 {
+    fun e() = 1
+}
+