Do not retain proxy-based components for compiler plugin settings in project model (again) (KT-24444)

The previous approach didn't work because Gradle wraps the copy() result, and the leakage didn't go away.

plugins/allopen/allopen-ide/src/AllOpenModelBuilderService.kt

@@ -17,13 +17,11 @@
 package org.jetbrains.kotlin.allopen.ide
 
 import com.intellij.openapi.util.Key
-import org.jetbrains.kotlin.annotation.plugin.ide.AnnotationBasedPluginModel
+import org.jetbrains.kotlin.annotation.plugin.ide.*
-import org.jetbrains.kotlin.annotation.plugin.ide.AnnotationBasedPluginModelBuilderService
-import org.jetbrains.kotlin.annotation.plugin.ide.AnnotationBasedPluginProjectResolverExtension
 
 interface AllOpenModel : AnnotationBasedPluginModel {
-    override fun copy(): AllOpenModel {
+    override fun dump(): DumpedPluginModel {
-        return AllOpenModelImpl(annotations.toList(), presets.toList())
+        return DumpedPluginModelImpl(AllOpenModelImpl::class.java, annotations.toList(), presets.toList())
     }
 }
 

plugins/annotation-based-compiler-plugins-ide-support/src/AnnotationBasedPluginProjectResolverExtension.kt

@@ -29,11 +29,32 @@ import org.jetbrains.plugins.gradle.tooling.ErrorMessageBuilder
 import java.io.Serializable
 import java.lang.Exception
 
+interface DumpedPluginModel {
+    val className: String
+
+    // May contain primitives, Strings and collections of primitives/Strings
+    val args: Array<*>
+
+    operator fun component1() = className
+    operator fun component2() = args
+}
+
+class DumpedPluginModelImpl(
+    override val className: String,
+    override val args: Array<*>
+) : DumpedPluginModel, Serializable {
+    constructor(clazz: Class<*>, vararg args: Any?) : this(clazz.canonicalName, args)
+}
+
 interface AnnotationBasedPluginModel : Serializable {
     val annotations: List<String>
     val presets: List<String>
 
-    fun copy(): AnnotationBasedPluginModel
+    /*
+        Objects returned from Gradle importer are implicitly wrapped in a proxy that can potentially leak internal Gradle structures.
+        So we need a way to safely serialize the arbitrary annotation plugin model.
+     */
+    fun dump(): DumpedPluginModel
 
     val isEnabled get() = annotations.isNotEmpty() || presets.isNotEmpty()
 }
@@ -58,7 +79,12 @@ abstract class AnnotationBasedPluginProjectResolverExtension<T : AnnotationBased
         val model = resolverCtx.getExtraProject(gradleModule, modelClass)
 
         if (model != null) {
-            ideModule.putCopyableUserData(userDataKey, model.copy() as T)
+            val (className, args) = model.dump()
+
+            @Suppress("UNCHECKED_CAST")
+            val refurbishedModel = Class.forName(className).constructors.single().newInstance(*args) as T
+
+            ideModule.putCopyableUserData(userDataKey, refurbishedModel)
         }
 
         super.populateModuleExtraModels(gradleModule, ideModule)

plugins/noarg/noarg-ide/src/NoArgModelBuilderService.kt

@@ -17,15 +17,13 @@
 package org.jetbrains.kotlin.noarg.ide
 
 import com.intellij.openapi.util.Key
-import org.jetbrains.kotlin.annotation.plugin.ide.AnnotationBasedPluginModel
+import org.jetbrains.kotlin.annotation.plugin.ide.*
-import org.jetbrains.kotlin.annotation.plugin.ide.AnnotationBasedPluginModelBuilderService
-import org.jetbrains.kotlin.annotation.plugin.ide.AnnotationBasedPluginProjectResolverExtension
 
 interface NoArgModel : AnnotationBasedPluginModel {
     val invokeInitializers: Boolean
 
-    override fun copy(): NoArgModel {
+    override fun dump(): DumpedPluginModel {
-        return NoArgModelImpl(annotations.toList(), presets.toList(), invokeInitializers)
+        return DumpedPluginModelImpl(NoArgModelImpl::class.java, annotations.toList(), presets.toList(), invokeInitializers)
     }
 }
 

plugins/sam-with-receiver/sam-with-receiver-ide/src/SamWithReceiverModelBuilderService.kt

@@ -17,13 +17,11 @@
 package org.jetbrains.kotlin.samWithReceiver.ide
 
 import com.intellij.openapi.util.Key
-import org.jetbrains.kotlin.annotation.plugin.ide.AnnotationBasedPluginModel
+import org.jetbrains.kotlin.annotation.plugin.ide.*
-import org.jetbrains.kotlin.annotation.plugin.ide.AnnotationBasedPluginModelBuilderService
-import org.jetbrains.kotlin.annotation.plugin.ide.AnnotationBasedPluginProjectResolverExtension
 
 interface SamWithReceiverModel : AnnotationBasedPluginModel {
-    override fun copy(): SamWithReceiverModel {
+    override fun dump(): DumpedPluginModel {
-        return SamWithReceiverModelImpl(annotations.toList(), presets.toList())
+        return DumpedPluginModelImpl(SamWithReceiverModelImpl::class.java, annotations.toList(), presets.toList())
     }
 }