From a421f74ef0274bcbeb036a01fe97d747d5743064 Mon Sep 17 00:00:00 2001 From: Yan Zhulanow Date: Tue, 2 Jun 2020 00:16:31 +0900 Subject: [PATCH] Revert "Minor: extract new line allowance check" This reverts commit e2f0b76e --- .../kotlin/idea/inspections/TrailingCommaInspection.kt | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/idea/src/org/jetbrains/kotlin/idea/inspections/TrailingCommaInspection.kt b/idea/src/org/jetbrains/kotlin/idea/inspections/TrailingCommaInspection.kt index ba676b58b56..9e0355427a7 100644 --- a/idea/src/org/jetbrains/kotlin/idea/inspections/TrailingCommaInspection.kt +++ b/idea/src/org/jetbrains/kotlin/idea/inspections/TrailingCommaInspection.kt @@ -63,8 +63,9 @@ class TrailingCommaInspection( } val last = TrailingCommaHelper.elementAfterLastElement(commaOwner) - - if (last?.prevLeaf(true)?.isLineBreak() == false && !allowMissingLineBreak(commaOwner)) { + val whenEntryWithoutTrailingComma = + commaOwner is KtWhenEntry && TrailingCommaHelper.trailingCommaOrLastElement(commaOwner)?.isComma != true + if (last?.prevLeaf(true)?.isLineBreak() == false && !whenEntryWithoutTrailingComma) { registerProblemForLineBreak( commaOwner, last, @@ -73,11 +74,6 @@ class TrailingCommaInspection( } } - private fun allowMissingLineBreak(commaOwner: KtElement): Boolean { - return commaOwner is KtWhenEntry - && TrailingCommaHelper.trailingCommaOrLastElement(commaOwner)?.isComma != true - } - private fun checkCommaPosition(commaOwner: KtElement) { for (invalidComma in TrailingCommaHelper.findInvalidCommas(commaOwner)) { reportProblem(