azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not use ThreadLocalRandom on Android until upcoming SDK 34.

Browse Source 
On Android devices starting SDK 25, ThreadLocalRandom accidentally
started out from the same seed on all application starts. This
means that the same sequence of numbers is returned whenever the
application is started.

This will be fixed in SDK 34. We should avoid using
ThreadLocalRandom until then.

^KT-52618 Fixed
This commit is contained in:
Mads Ager
2022-06-10 09:07:08 +02:00
committed by Space
parent 194a1d1c6a
commit a2e8ed0032
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/stdlib/jdk8/src/kotlin/internal/jdk8/JDK8PlatformImplementations.kt
+5 -2
View File
@@ -51,7 +51,10 @@ internal open class JDK8PlatformImplementations : JDK7PlatformImplementations()
override fun defaultPlatformRandom(): Random =
// while ThreadLocalRandom is available since SDK 21 (as documented), it has bugs in the implementation,
// so we don't use it for the same reasons as why we don't use it in JDK7.
if (sdkIsNullOrAtLeast(24)) PlatformThreadLocalRandom() else super.defaultPlatformRandom()
// so we don't use it for the same reasons as why we don't use it in JDK7. ThreadLocalRandom worked on
// SDK 24, but starting SDK 25 it had bugs in seeding so that it would return the same sequence of values
// for all application starts. That will be fixed in SDK 34. Therefore, do not use ThreadLocalRandom until
// then.
if (sdkIsNullOrAtLeast(34)) PlatformThreadLocalRandom() else super.defaultPlatformRandom()
}