From a1e6f566f6bf58371a17ccc4c9766eff955694ea Mon Sep 17 00:00:00 2001 From: Ilya Goncharov Date: Thu, 23 Jan 2020 17:31:36 +0300 Subject: [PATCH] [Gradle, JS] Add disambiguation classifier for MPP --- .../kotlin/gradle/targets/js/KotlinJsTargetPreset.kt | 11 +++++++++++ .../gradle/targets/js/ir/KotlinJsIrTargetPreset.kt | 3 +++ 2 files changed, 14 insertions(+) diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/KotlinJsTargetPreset.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/KotlinJsTargetPreset.kt index b47628923a6..4dce75eeb6b 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/KotlinJsTargetPreset.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/KotlinJsTargetPreset.kt @@ -15,6 +15,7 @@ import org.jetbrains.kotlin.gradle.targets.js.KotlinJsTargetConfigurator import org.jetbrains.kotlin.gradle.targets.js.ir.KotlinJsIrSingleTargetPreset import org.jetbrains.kotlin.gradle.targets.js.ir.KotlinJsIrTargetConfigurator import org.jetbrains.kotlin.gradle.targets.js.ir.KotlinJsIrTargetPreset +import org.jetbrains.kotlin.gradle.utils.lowerCamelCaseName open class KotlinJsTargetPreset( project: Project, @@ -40,6 +41,16 @@ open class KotlinJsTargetPreset( } } + override fun provideTargetDisambiguationClassifier(target: KotlinOnlyTarget): String? = + if (irPreset == null) { + super.provideTargetDisambiguationClassifier(target) + } else { + lowerCamelCaseName( + LEGACY_DISAMBIGUATION_CLASSIFIER, + super.provideTargetDisambiguationClassifier(target) + ) + } + override fun createKotlinTargetConfigurator() = KotlinJsTargetConfigurator( kotlinPluginVersion, irPreset?.let { KotlinJsIrTargetConfigurator(kotlinPluginVersion) } diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/ir/KotlinJsIrTargetPreset.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/ir/KotlinJsIrTargetPreset.kt index 19588664661..19039098a2f 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/ir/KotlinJsIrTargetPreset.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/ir/KotlinJsIrTargetPreset.kt @@ -26,6 +26,9 @@ open class KotlinJsIrTargetPreset( return project.objects.newInstance(KotlinJsIrTarget::class.java, project, platformType) } + // TODO Remove when IR and Legacy targets swap + override fun provideTargetDisambiguationClassifier(target: KotlinOnlyTarget): String? = "js" + override fun createKotlinTargetConfigurator(): KotlinOnlyTargetConfigurator = KotlinJsIrTargetConfigurator(kotlinPluginVersion)