azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimization: don't check when there's nothing to check or report

Browse Source
This commit is contained in:
Andrey Breslav
2013-11-01 18:43:26 +04:00
parent ce496c4512
commit a0b09ae590
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/resolver/PsiBasedMethodSignatureChecker.java
+3
View File
@@ -171,6 +171,9 @@ public class PsiBasedMethodSignatureChecker implements MethodSignatureChecker {
@NotNull List<String> signatureErrors, @NotNull List<String> signatureErrors,
@NotNull List<FunctionDescriptor> superFunctions @NotNull List<FunctionDescriptor> superFunctions
) { ) {
// This optimization speed things up because hasRawTypesInHierarchicalSignature() is very expensive
if (superFunctions.isEmpty() && (signatureErrors.isEmpty() || !reportSignatureErrors)) return;
JavaMethodImpl methodWithPsi = (JavaMethodImpl) method; JavaMethodImpl methodWithPsi = (JavaMethodImpl) method;
if (!RawTypesCheck.hasRawTypesInHierarchicalSignature(methodWithPsi) && if (!RawTypesCheck.hasRawTypesInHierarchicalSignature(methodWithPsi) &&
isMethodReturnTypeCompatible(methodWithPsi) && isMethodReturnTypeCompatible(methodWithPsi) &&