Optimization: don't check when there's nothing to check or report

This commit is contained in:
Andrey Breslav
2013-11-01 18:43:26 +04:00
parent ce496c4512
commit a0b09ae590
@@ -171,6 +171,9 @@ public class PsiBasedMethodSignatureChecker implements MethodSignatureChecker {
@NotNull List<String> signatureErrors,
@NotNull List<FunctionDescriptor> superFunctions
) {
// This optimization speed things up because hasRawTypesInHierarchicalSignature() is very expensive
if (superFunctions.isEmpty() && (signatureErrors.isEmpty() || !reportSignatureErrors)) return;
JavaMethodImpl methodWithPsi = (JavaMethodImpl) method;
if (!RawTypesCheck.hasRawTypesInHierarchicalSignature(methodWithPsi) &&
isMethodReturnTypeCompatible(methodWithPsi) &&