KT-8843 When typing in lambda parameters' names, smart completion kicks in and makes it impossible to type names

#KT-8843 Fixed

idea/idea-completion/src/org/jetbrains/kotlin/idea/completion/BasicCompletionSession.kt

@@ -145,17 +145,15 @@ class BasicCompletionSession(configuration: CompletionSessionConfiguration,
     }
 
     private fun shouldCompleteParameterNameAndType(): Boolean {
-        when (completionKind) {
+        if (completionKind != CompletionKind.PARAMETER_NAME && completionKind != CompletionKind.ANNOTATION_TYPES_OR_PARAMETER_NAME) return false
-            CompletionKind.PARAMETER_NAME, CompletionKind.ANNOTATION_TYPES_OR_PARAMETER_NAME -> {
-                val parameter = position.getNonStrictParentOfType<JetParameter>()!!
-                val list = parameter.getParent() as? JetParameterList ?: return false
-                val owner = list.getParent()
-                return owner !is JetCatchClause &&
-                       owner !is JetPropertyAccessor &&
-                       !((owner as? JetPrimaryConstructor)?.getContainingClassOrObject()?.isAnnotation() ?: false)
-            }
 
-            else -> return false
+        val parameter = position.getNonStrictParentOfType<JetParameter>()!!
+        val list = parameter.parent as? JetParameterList ?: return false
+        val owner = list.parent
+        return when (owner) {
+            is JetCatchClause, is JetPropertyAccessor, is JetFunctionLiteral -> false
+            is JetPrimaryConstructor -> !owner.getContainingClassOrObject().isAnnotation()
+            else -> true
         }
     }
 

idea/idea-completion/testData/basic/common/parameterNameAndType/NotForLambdaParameter2.kt

@@ -0,0 +1,9 @@
+class AAA
+
+fun foo(p: (Int, String) -> Unit) { }
+
+fun bar() {
+    foo { a<caret>, b -> }
+}
+
+// NUMBER: 0

idea/idea-completion/testData/basic/common/parameterNameAndType/NotForLambdaParameter3.kt

@@ -0,0 +1,9 @@
+class BBB
+
+fun foo(p: (Int, String) -> Unit) { }
+
+fun bar() {
+    foo { a, b<caret> }
+}
+
+// NUMBER: 0

idea/idea-completion/tests/org/jetbrains/kotlin/idea/completion/test/JSBasicCompletionTestGenerated.java

@@ -1584,9 +1584,21 @@ public class JSBasicCompletionTestGenerated extends AbstractJSBasicCompletionTes
                 doTest(fileName);
             }
 
-            @TestMetadata("NotForLambdaParameter.kt")
+            @TestMetadata("NotForLambdaParameter1.kt")
-            public void testNotForLambdaParameter() throws Exception {
+            public void testNotForLambdaParameter1() throws Exception {
-                String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/basic/common/parameterNameAndType/NotForLambdaParameter.kt");
+                String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/basic/common/parameterNameAndType/NotForLambdaParameter1.kt");
+                doTest(fileName);
+            }
+
+            @TestMetadata("NotForLambdaParameter2.kt")
+            public void testNotForLambdaParameter2() throws Exception {
+                String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/basic/common/parameterNameAndType/NotForLambdaParameter2.kt");
+                doTest(fileName);
+            }
+
+            @TestMetadata("NotForLambdaParameter3.kt")
+            public void testNotForLambdaParameter3() throws Exception {
+                String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/basic/common/parameterNameAndType/NotForLambdaParameter3.kt");
                 doTest(fileName);
             }
 

idea/idea-completion/tests/org/jetbrains/kotlin/idea/completion/test/JvmBasicCompletionTestGenerated.java

@@ -1584,9 +1584,21 @@ public class JvmBasicCompletionTestGenerated extends AbstractJvmBasicCompletionT
                 doTest(fileName);
             }
 
-            @TestMetadata("NotForLambdaParameter.kt")
+            @TestMetadata("NotForLambdaParameter1.kt")
-            public void testNotForLambdaParameter() throws Exception {
+            public void testNotForLambdaParameter1() throws Exception {
-                String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/basic/common/parameterNameAndType/NotForLambdaParameter.kt");
+                String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/basic/common/parameterNameAndType/NotForLambdaParameter1.kt");
+                doTest(fileName);
+            }
+
+            @TestMetadata("NotForLambdaParameter2.kt")
+            public void testNotForLambdaParameter2() throws Exception {
+                String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/basic/common/parameterNameAndType/NotForLambdaParameter2.kt");
+                doTest(fileName);
+            }
+
+            @TestMetadata("NotForLambdaParameter3.kt")
+            public void testNotForLambdaParameter3() throws Exception {
+                String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/basic/common/parameterNameAndType/NotForLambdaParameter3.kt");
                 doTest(fileName);
             }