azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve diagnostics on header/impl classes when scopes don't match

Browse Source 
Try to report most of the errors on the actual members of the impl
class. In many cases, there's a 1:1 mapping of header to impl class
members, so the error "some members are not implemented" on the class
declaration itself is redundant. Exceptions include functions/properties
from supertypes (there may be no other place to report a signature
mismatch error in this case), functions/properties not marked with
'impl' (the checker is only run for declarations explicitly marked with
'impl') and default constructors (the checker is not run for them)

 #KT-18447 Fixed
This commit is contained in:
Alexander Udalov
2017-07-18 17:28:33 +03:00
parent 74ba0080b1
commit 9ecd04f628
17 changed files with 207 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/multiplatform/classScopes/missingFunction/output.txt
Vendored
+1 -4
View File
@@ -5,10 +5,7 @@ Output:
-- JVM --
Exit code: COMPILATION_ERROR
Output:
compiler/testData/multiplatform/classScopes/missingFunction/jvm.kt:1:12: error: 'impl' class 'Foo' has no corresponding 'header' declaration
The following declaration is incompatible because some members are not implemented:
public final header class Foo
No implementations are found for members listed below:
compiler/testData/multiplatform/classScopes/missingFunction/jvm.kt:1:12: error: 'impl' class 'Foo' has no implementation of 'header' class members:
public final header fun function(s: String): Unit