Refactoring: "simplify assert not null" is now an inspection

idea/testData/inspectionsLocal/simplifyAssertNotNull/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.SimplifyAssertNotNullInspection

idea/testData/inspectionsLocal/simplifyAssertNotNull/comments.kt

@@ -0,0 +1,8 @@
+// FIX: "Replace with '?: error(...)'"
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v = p[0]
+    // now let's check it for null
+    <caret>assert(v != null /* null */, /* lazy message */ { "Should be not null" }) // 'v' should not be null
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/comments.kt.after

@@ -0,0 +1,8 @@
+// FIX: "Replace with '?: error(...)'"
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v = p[0] ?: error(/* null */ /* lazy message */"Should be not null")
+    // now let's check it for null
+    // 'v' should not be null
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/commentsNoMessage.kt

@@ -0,0 +1,8 @@
+// FIX: "Replace with '!!' operator"
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v = p[0]
+    // now let's check it for null
+    <caret>assert(v != null /* null */) // 'v' should not be null
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/commentsNoMessage.kt.after

@@ -0,0 +1,9 @@
+// FIX: "Replace with '!!' operator"
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    /* null */
+    val v = p[0]!!
+    // now let's check it for null
+    // 'v' should not be null
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/complicatedMessageLambda.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v = p[0]
+    <caret>assert(v != null, { val t = 1; "Should be not null: $t" })
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/eqNull.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v = p[0]
+    <caret>assert(v == null)
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/errorFunctionInContext.kt

@@ -0,0 +1,11 @@
+// FIX: "Replace with '?: error(...)'"
+// WITH_RUNTIME
+
+class C {
+    fun error(message: String) { }
+
+    fun foo(p: Array<String?>) {
+        val v = p[0]
+        <caret>assert(v != null) { "message" }
+    }
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/errorFunctionInContext.kt.after

@@ -0,0 +1,10 @@
+// FIX: "Replace with '?: error(...)'"
+// WITH_RUNTIME
+
+class C {
+    fun error(message: String) { }
+
+    fun foo(p: Array<String?>) {
+        val v = p[0] <caret>?: kotlin.error("message")
+    }
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/falseAssert.kt

@@ -0,0 +1,11 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+class C {
+    fun assert(b: Boolean) { }
+
+    fun foo(p: Array<String?>) {
+        val v = p[0]
+        <caret>assert(v != null)
+    }
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/noMessage.kt

@@ -0,0 +1,7 @@
+// FIX: "Replace with '!!' operator"
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v = p[0]
+    <caret>assert(v != null)
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/noMessage.kt.after

@@ -0,0 +1,6 @@
+// FIX: "Replace with '!!' operator"
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v = p[0]!!<caret>
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/otherVariable.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v1 = p[0]
+    val v2 = p[1]
+    <caret>assert(v1 != null)
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/qualifiedAccess.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+class C(val v: String?) {
+    fun foo(p: Array<String?>) {
+        val v = p[0]
+        <caret>assert(this.v != null)
+    }
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/withMessage.kt

@@ -0,0 +1,7 @@
+// FIX: "Replace with '?: error(...)'"
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v = p[0]
+    <caret>assert(v != null, { "Should be not null" })
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/withMessage.kt.after

@@ -0,0 +1,6 @@
+// FIX: "Replace with '?: error(...)'"
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v = p[0] <caret>?: error("Should be not null")
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/withMessageLambdaOutside.kt

@@ -0,0 +1,7 @@
+// FIX: "Replace with '?: error(...)'"
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v = p[0]
+    <caret>assert(v != null) { "Should be not null" }
+}

idea/testData/inspectionsLocal/simplifyAssertNotNull/withMessageLambdaOutside.kt.after

@@ -0,0 +1,6 @@
+// FIX: "Replace with '?: error(...)'"
+// WITH_RUNTIME
+
+fun foo(p: Array<String?>) {
+    val v = p[0] <caret>?: error("Should be not null")
+}