Rename ExternalSignatureResolver -> SignaturePropagator

This commit is contained in:
Alexander Udalov
2015-11-27 16:17:17 +03:00
parent 57e75a1b28
commit 9e7e75de12
7 changed files with 17 additions and 17 deletions
@@ -56,7 +56,7 @@ public fun StorageComponentContainer.configureJavaTopDownAnalysis(moduleContentS
useInstance(JvmVirtualFileFinderFactory.SERVICE.getInstance(project).create(moduleContentScope)) useInstance(JvmVirtualFileFinderFactory.SERVICE.getInstance(project).create(moduleContentScope))
useImpl<JavaClassFinderImpl>() useImpl<JavaClassFinderImpl>()
useImpl<TraceBasedExternalSignatureResolver>() useImpl<SignaturePropagatorImpl>()
useImpl<LazyResolveBasedCache>() useImpl<LazyResolveBasedCache>()
useImpl<TraceBasedErrorReporter>() useImpl<TraceBasedErrorReporter>()
useImpl<PsiBasedExternalAnnotationResolver>() useImpl<PsiBasedExternalAnnotationResolver>()
@@ -30,16 +30,16 @@ import org.jetbrains.kotlin.types.KotlinType;
import java.util.List; import java.util.List;
public class TraceBasedExternalSignatureResolver implements ExternalSignatureResolver { public class SignaturePropagatorImpl implements SignaturePropagator {
private final BindingTrace trace; private final BindingTrace trace;
public TraceBasedExternalSignatureResolver(@NotNull BindingTrace trace) { public SignaturePropagatorImpl(@NotNull BindingTrace trace) {
this.trace = trace; this.trace = trace;
} }
@Override @Override
@NotNull @NotNull
public AlternativeMethodSignature resolvePropagatedSignature( public PropagatedSignature resolvePropagatedSignature(
@NotNull JavaMethod method, @NotNull JavaMethod method,
@NotNull ClassDescriptor owner, @NotNull ClassDescriptor owner,
@NotNull KotlinType returnType, @NotNull KotlinType returnType,
@@ -49,7 +49,7 @@ public class TraceBasedExternalSignatureResolver implements ExternalSignatureRes
) { ) {
SignaturesPropagationData data = SignaturesPropagationData data =
new SignaturesPropagationData(owner, returnType, receiverType, valueParameters, typeParameters, method); new SignaturesPropagationData(owner, returnType, receiverType, valueParameters, typeParameters, method);
return new AlternativeMethodSignature( return new PropagatedSignature(
returnType, data.getModifiedReceiverType(), data.getModifiedValueParameters(), returnType, data.getModifiedReceiverType(), data.getModifiedValueParameters(),
typeParameters, data.getSignatureErrors(), data.getModifiedHasStableParameterNames() typeParameters, data.getSignatureErrors(), data.getModifiedHasStableParameterNames()
); );
@@ -28,11 +28,11 @@ import org.jetbrains.kotlin.types.KotlinType;
import java.util.Collections; import java.util.Collections;
import java.util.List; import java.util.List;
public interface ExternalSignatureResolver { public interface SignaturePropagator {
ExternalSignatureResolver DO_NOTHING = new ExternalSignatureResolver() { SignaturePropagator DO_NOTHING = new SignaturePropagator() {
@NotNull @NotNull
@Override @Override
public AlternativeMethodSignature resolvePropagatedSignature( public PropagatedSignature resolvePropagatedSignature(
@NotNull JavaMethod method, @NotNull JavaMethod method,
@NotNull ClassDescriptor owner, @NotNull ClassDescriptor owner,
@NotNull KotlinType returnType, @NotNull KotlinType returnType,
@@ -40,7 +40,7 @@ public interface ExternalSignatureResolver {
@NotNull List<ValueParameterDescriptor> valueParameters, @NotNull List<ValueParameterDescriptor> valueParameters,
@NotNull List<TypeParameterDescriptor> typeParameters @NotNull List<TypeParameterDescriptor> typeParameters
) { ) {
return new AlternativeMethodSignature( return new PropagatedSignature(
returnType, receiverType, valueParameters, typeParameters, Collections.<String>emptyList(), false returnType, receiverType, valueParameters, typeParameters, Collections.<String>emptyList(), false
); );
} }
@@ -51,7 +51,7 @@ public interface ExternalSignatureResolver {
} }
}; };
class AlternativeMethodSignature { class PropagatedSignature {
private final KotlinType returnType; private final KotlinType returnType;
private final KotlinType receiverType; private final KotlinType receiverType;
private final List<ValueParameterDescriptor> valueParameters; private final List<ValueParameterDescriptor> valueParameters;
@@ -59,7 +59,7 @@ public interface ExternalSignatureResolver {
private final List<String> signatureErrors; private final List<String> signatureErrors;
private final boolean hasStableParameterNames; private final boolean hasStableParameterNames;
public AlternativeMethodSignature( public PropagatedSignature(
@NotNull KotlinType returnType, @NotNull KotlinType returnType,
@Nullable KotlinType receiverType, @Nullable KotlinType receiverType,
@NotNull List<ValueParameterDescriptor> valueParameters, @NotNull List<ValueParameterDescriptor> valueParameters,
@@ -106,7 +106,7 @@ public interface ExternalSignatureResolver {
} }
@NotNull @NotNull
AlternativeMethodSignature resolvePropagatedSignature( PropagatedSignature resolvePropagatedSignature(
@NotNull JavaMethod method, @NotNull JavaMethod method,
@NotNull ClassDescriptor owner, @NotNull ClassDescriptor owner,
@NotNull KotlinType returnType, @NotNull KotlinType returnType,
@@ -24,7 +24,7 @@ import org.jetbrains.kotlin.descriptors.SupertypeLoopChecker
import org.jetbrains.kotlin.incremental.components.LookupTracker import org.jetbrains.kotlin.incremental.components.LookupTracker
import org.jetbrains.kotlin.load.java.JavaClassFinder import org.jetbrains.kotlin.load.java.JavaClassFinder
import org.jetbrains.kotlin.load.java.components.ExternalAnnotationResolver import org.jetbrains.kotlin.load.java.components.ExternalAnnotationResolver
import org.jetbrains.kotlin.load.java.components.ExternalSignatureResolver import org.jetbrains.kotlin.load.java.components.SignaturePropagator
import org.jetbrains.kotlin.load.java.components.JavaResolverCache import org.jetbrains.kotlin.load.java.components.JavaResolverCache
import org.jetbrains.kotlin.load.java.components.SamConversionResolver import org.jetbrains.kotlin.load.java.components.SamConversionResolver
import org.jetbrains.kotlin.load.java.lazy.types.LazyJavaTypeResolver import org.jetbrains.kotlin.load.java.lazy.types.LazyJavaTypeResolver
@@ -42,7 +42,7 @@ class JavaResolverComponents(
val kotlinClassFinder: KotlinClassFinder, val kotlinClassFinder: KotlinClassFinder,
val deserializedDescriptorResolver: DeserializedDescriptorResolver, val deserializedDescriptorResolver: DeserializedDescriptorResolver,
val externalAnnotationResolver: ExternalAnnotationResolver, val externalAnnotationResolver: ExternalAnnotationResolver,
val externalSignatureResolver: ExternalSignatureResolver, val signaturePropagator: SignaturePropagator,
val errorReporter: ErrorReporter, val errorReporter: ErrorReporter,
val javaResolverCache: JavaResolverCache, val javaResolverCache: JavaResolverCache,
val javaPropertyInitializerEvaluator: JavaPropertyInitializerEvaluator, val javaPropertyInitializerEvaluator: JavaPropertyInitializerEvaluator,
@@ -422,7 +422,7 @@ public class LazyJavaClassMemberScope(
method: JavaMethod, methodTypeParameters: List<TypeParameterDescriptor>, returnType: KotlinType, method: JavaMethod, methodTypeParameters: List<TypeParameterDescriptor>, returnType: KotlinType,
valueParameters: List<ValueParameterDescriptor> valueParameters: List<ValueParameterDescriptor>
): LazyJavaScope.MethodSignatureData { ): LazyJavaScope.MethodSignatureData {
val propagated = c.components.externalSignatureResolver.resolvePropagatedSignature( val propagated = c.components.signaturePropagator.resolvePropagatedSignature(
method, ownerDescriptor, returnType, null, valueParameters, methodTypeParameters method, ownerDescriptor, returnType, null, valueParameters, methodTypeParameters
) )
return LazyJavaScope.MethodSignatureData( return LazyJavaScope.MethodSignatureData(
@@ -138,7 +138,7 @@ public abstract class LazyJavaScope(protected val c: LazyJavaResolverContext) :
functionDescriptorImpl.setParameterNamesStatus(effectiveSignature.hasStableParameterNames, valueParameters.hasSynthesizedNames) functionDescriptorImpl.setParameterNamesStatus(effectiveSignature.hasStableParameterNames, valueParameters.hasSynthesizedNames)
if (effectiveSignature.errors.isNotEmpty()) { if (effectiveSignature.errors.isNotEmpty()) {
c.components.externalSignatureResolver.reportSignatureErrors(functionDescriptorImpl, effectiveSignature.errors) c.components.signaturePropagator.reportSignatureErrors(functionDescriptorImpl, effectiveSignature.errors)
} }
return functionDescriptorImpl return functionDescriptorImpl
@@ -57,7 +57,7 @@ public class RuntimeModuleData private constructor(public val deserialization: D
val runtimePackageFacadeProvider = RuntimePackagePartProvider(classLoader) val runtimePackageFacadeProvider = RuntimePackagePartProvider(classLoader)
val globalJavaResolverContext = JavaResolverComponents( val globalJavaResolverContext = JavaResolverComponents(
storageManager, ReflectJavaClassFinder(classLoader), reflectKotlinClassFinder, deserializedDescriptorResolver, storageManager, ReflectJavaClassFinder(classLoader), reflectKotlinClassFinder, deserializedDescriptorResolver,
ExternalAnnotationResolver.EMPTY, ExternalSignatureResolver.DO_NOTHING, RuntimeErrorReporter, JavaResolverCache.EMPTY, ExternalAnnotationResolver.EMPTY, SignaturePropagator.DO_NOTHING, RuntimeErrorReporter, JavaResolverCache.EMPTY,
JavaPropertyInitializerEvaluator.DoNothing, SamConversionResolver, RuntimeSourceElementFactory, singleModuleClassResolver, JavaPropertyInitializerEvaluator.DoNothing, SamConversionResolver, RuntimeSourceElementFactory, singleModuleClassResolver,
runtimePackageFacadeProvider, SupertypeLoopChecker.EMPTY, LookupTracker.DO_NOTHING runtimePackageFacadeProvider, SupertypeLoopChecker.EMPTY, LookupTracker.DO_NOTHING
) )