From 9e38e6d051eabe51ae272f1d2a41d69d1f2d8773 Mon Sep 17 00:00:00 2001
From: Mikhail Glukhikh <mikhail.glukhikh@jetbrains.com>
Date: Wed, 2 Sep 2020 10:18:54 +0300
Subject: [PATCH] [FIR2IR] Intercept exceptions in convertToIrCall to provide
 more info

---
 .../fir/backend/Fir2IrConversionScope.kt      |   2 +
 .../generators/CallAndReferenceGenerator.kt   | 125 +++++++++---------
 2 files changed, 67 insertions(+), 60 deletions(-)

diff --git a/compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/Fir2IrConversionScope.kt b/compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/Fir2IrConversionScope.kt
index fcbc1683453..7b70e9a056f 100644
--- a/compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/Fir2IrConversionScope.kt
+++ b/compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/Fir2IrConversionScope.kt
@@ -24,6 +24,8 @@ class Fir2IrConversionScope {
         return parent
     }
 
+    fun containingFileIfAny(): IrFile? = parentStack.getOrNull(0) as? IrFile
+
     fun withContainingFirClass(containingFirClass: FirClass<*>, f: () -> Unit) {
         containingFirClassStack += containingFirClass
         f()
diff --git a/compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/generators/CallAndReferenceGenerator.kt b/compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/generators/CallAndReferenceGenerator.kt
index fa0924aa541..ba02bded66f 100644
--- a/compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/generators/CallAndReferenceGenerator.kt
+++ b/compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/generators/CallAndReferenceGenerator.kt
@@ -460,69 +460,74 @@ class CallAndReferenceGenerator(
         explicitReceiverExpression: IrExpression?,
         annotationMode: Boolean = false
     ): IrExpression {
-        val type = typeRef.toIrType()
-        val samConstructorCall = qualifiedAccess.tryConvertToSamConstructorCall(type)
-        if (samConstructorCall != null) return samConstructorCall
+        try {
+            val type = typeRef.toIrType()
+            val samConstructorCall = qualifiedAccess.tryConvertToSamConstructorCall(type)
+            if (samConstructorCall != null) return samConstructorCall
 
-        val symbol = qualifiedAccess.calleeReference.toSymbol(
-            session,
-            classifierStorage,
-            declarationStorage,
-            conversionScope
-        )
-        return qualifiedAccess.convertWithOffsets { startOffset, endOffset ->
-            val dispatchReceiver = qualifiedAccess.dispatchReceiver
-            if (qualifiedAccess.calleeReference is FirSuperReference) {
-                if (dispatchReceiver !is FirNoReceiverExpression) {
-                    return@convertWithOffsets visitor.convertToIrExpression(dispatchReceiver)
-                }
-            }
-            when (symbol) {
-                is IrConstructorSymbol -> IrConstructorCallImpl.fromSymbolOwner(startOffset, endOffset, type, symbol)
-                is IrSimpleFunctionSymbol -> {
-                    IrCallImpl(
-                        startOffset, endOffset, type, symbol,
-                        typeArgumentsCount = symbol.owner.typeParameters.size,
-                        valueArgumentsCount = symbol.owner.valueParameters.size,
-                        origin = qualifiedAccess.calleeReference.statementOrigin(),
-                        superQualifierSymbol = dispatchReceiver.superQualifierSymbol(symbol)
-                    )
-                }
-                is IrPropertySymbol -> {
-                    val getter = symbol.owner.getter
-                    val backingField = symbol.owner.backingField
-                    when {
-                        getter != null -> IrCallImpl(
-                            startOffset, endOffset, type, getter.symbol,
-                            typeArgumentsCount = getter.typeParameters.size,
-                            valueArgumentsCount = 0,
-                            origin = IrStatementOrigin.GET_PROPERTY,
-                            superQualifierSymbol = dispatchReceiver.superQualifierSymbol(symbol)
-                        )
-                        backingField != null -> IrGetFieldImpl(
-                            startOffset, endOffset, backingField.symbol, type,
-                            superQualifierSymbol = dispatchReceiver.superQualifierSymbol(symbol)
-                        )
-                        else -> IrErrorCallExpressionImpl(
-                            startOffset, endOffset, type,
-                            description = "No getter or backing field found for ${qualifiedAccess.calleeReference.render()}"
-                        )
+            val symbol = qualifiedAccess.calleeReference.toSymbol(
+                session,
+                classifierStorage,
+                declarationStorage,
+                conversionScope
+            )
+            return qualifiedAccess.convertWithOffsets { startOffset, endOffset ->
+                val dispatchReceiver = qualifiedAccess.dispatchReceiver
+                if (qualifiedAccess.calleeReference is FirSuperReference) {
+                    if (dispatchReceiver !is FirNoReceiverExpression) {
+                        return@convertWithOffsets visitor.convertToIrExpression(dispatchReceiver)
                     }
                 }
-                is IrFieldSymbol -> IrGetFieldImpl(
-                    startOffset, endOffset, symbol, type,
-                    origin = IrStatementOrigin.GET_PROPERTY.takeIf { qualifiedAccess.calleeReference !is FirDelegateFieldReference },
-                    superQualifierSymbol = dispatchReceiver.superQualifierSymbol(symbol)
-                )
-                is IrValueSymbol -> IrGetValueImpl(
-                    startOffset, endOffset, type, symbol,
-                    origin = qualifiedAccess.calleeReference.statementOrigin()
-                )
-                is IrEnumEntrySymbol -> IrGetEnumValueImpl(startOffset, endOffset, type, symbol)
-                else -> generateErrorCallExpression(startOffset, endOffset, qualifiedAccess.calleeReference, type)
-            }
-        }.applyCallArguments(qualifiedAccess as? FirCall, annotationMode)
-            .applyTypeArguments(qualifiedAccess).applyReceivers(qualifiedAccess, explicitReceiverExpression)
+                when (symbol) {
+                    is IrConstructorSymbol -> IrConstructorCallImpl.fromSymbolOwner(startOffset, endOffset, type, symbol)
+                    is IrSimpleFunctionSymbol -> {
+                        IrCallImpl(
+                            startOffset, endOffset, type, symbol,
+                            typeArgumentsCount = symbol.owner.typeParameters.size,
+                            valueArgumentsCount = symbol.owner.valueParameters.size,
+                            origin = qualifiedAccess.calleeReference.statementOrigin(),
+                            superQualifierSymbol = dispatchReceiver.superQualifierSymbol(symbol)
+                        )
+                    }
+                    is IrPropertySymbol -> {
+                        val getter = symbol.owner.getter
+                        val backingField = symbol.owner.backingField
+                        when {
+                            getter != null -> IrCallImpl(
+                                startOffset, endOffset, type, getter.symbol,
+                                typeArgumentsCount = getter.typeParameters.size,
+                                valueArgumentsCount = 0,
+                                origin = IrStatementOrigin.GET_PROPERTY,
+                                superQualifierSymbol = dispatchReceiver.superQualifierSymbol(symbol)
+                            )
+                            backingField != null -> IrGetFieldImpl(
+                                startOffset, endOffset, backingField.symbol, type,
+                                superQualifierSymbol = dispatchReceiver.superQualifierSymbol(symbol)
+                            )
+                            else -> IrErrorCallExpressionImpl(
+                                startOffset, endOffset, type,
+                                description = "No getter or backing field found for ${qualifiedAccess.calleeReference.render()}"
+                            )
+                        }
+                    }
+                    is IrFieldSymbol -> IrGetFieldImpl(
+                        startOffset, endOffset, symbol, type,
+                        origin = IrStatementOrigin.GET_PROPERTY.takeIf { qualifiedAccess.calleeReference !is FirDelegateFieldReference },
+                        superQualifierSymbol = dispatchReceiver.superQualifierSymbol(symbol)
+                    )
+                    is IrValueSymbol -> IrGetValueImpl(
+                        startOffset, endOffset, type, symbol,
+                        origin = qualifiedAccess.calleeReference.statementOrigin()
+                    )
+                    is IrEnumEntrySymbol -> IrGetEnumValueImpl(startOffset, endOffset, type, symbol)
+                    else -> generateErrorCallExpression(startOffset, endOffset, qualifiedAccess.calleeReference, type)
+                }
+            }.applyCallArguments(qualifiedAccess as? FirCall, annotationMode)
+                .applyTypeArguments(qualifiedAccess).applyReceivers(qualifiedAccess, explicitReceiverExpression)
+        } catch (e: Throwable) {
+            throw IllegalStateException("Error while translating ${qualifiedAccess.render()} " +
+                                                "from file ${conversionScope.containingFileIfAny()?.name ?: "???"} to BE IR", e)
+        }
     }
 
     fun convertToIrSetCall(variableAssignment: FirVariableAssignment, explicitReceiverExpression: IrExpression?): IrExpression {