Prohibit local objects and enum classes

#KT-5402 Fixed
  #KT-4838 Fixed

Resolve type of object inside local object as special, not supertype('Any').
Changed visibility of constructor of anonymous object to 'internal' to be able to resolve the following:
fun box(): String {
    var foo = object {
        val bar = object {
            val baz = "ok"
        }
    }
    return foo.bar.baz
}
The containing declaration of property initializers is constructor, so 'baz' was invisible inside private constructor.

compiler/backend/src/org/jetbrains/jet/codegen/AsmUtil.java

@@ -291,23 +291,19 @@ public class AsmUtil {
         if (isEnumEntry(memberDescriptor)) {
             return NO_FLAG_PACKAGE_PRIVATE;
         }
+        if (memberDescriptor instanceof ConstructorDescriptor && isAnonymousObject(memberDescriptor.getContainingDeclaration())) {
+            return NO_FLAG_PACKAGE_PRIVATE;
+        }
         if (memberVisibility != Visibilities.PRIVATE) {
             return null;
         }
         // the following code is only for PRIVATE visibility of member
         if (memberDescriptor instanceof ConstructorDescriptor) {
-            if (isAnonymousObject(containingDeclaration)) {
-                return NO_FLAG_PACKAGE_PRIVATE;
-            }
-
             ClassKind kind = ((ClassDescriptor) containingDeclaration).getKind();
-            if (kind == ClassKind.OBJECT) {
+            if (kind == ClassKind.OBJECT || kind == ClassKind.ENUM_ENTRY) {
                 return NO_FLAG_PACKAGE_PRIVATE;
             }
-            else if (kind == ClassKind.ENUM_ENTRY) {
-                return NO_FLAG_PACKAGE_PRIVATE;
-            }
-            else if (kind == ClassKind.ENUM_CLASS) {
+            if (kind == ClassKind.ENUM_CLASS) {
                 //TODO: should be ACC_PRIVATE
                 // see http://youtrack.jetbrains.com/issue/KT-2680
                 return ACC_PROTECTED;

compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/Errors.java

@@ -180,12 +180,17 @@ public interface Errors {
 
     DiagnosticFactory1<JetClass, ClassDescriptor> ENUM_ENTRY_SHOULD_BE_INITIALIZED = DiagnosticFactory1.create(ERROR, NAME_IDENTIFIER);
     DiagnosticFactory1<JetTypeReference, ClassDescriptor> ENUM_ENTRY_ILLEGAL_TYPE = DiagnosticFactory1.create(ERROR);
+    DiagnosticFactory1<JetClass, ClassDescriptor> LOCAL_ENUM_NOT_ALLOWED = DiagnosticFactory1.create(ERROR, NAME_IDENTIFIER);
 
     // Class objects
 
     DiagnosticFactory0<JetClassObject> MANY_CLASS_OBJECTS = DiagnosticFactory0.create(ERROR);
     DiagnosticFactory0<JetClassObject> CLASS_OBJECT_NOT_ALLOWED = DiagnosticFactory0.create(ERROR);
 
+    // Objects
+
+    DiagnosticFactory1<JetObjectDeclaration, ClassDescriptor> LOCAL_OBJECT_NOT_ALLOWED = DiagnosticFactory1.create(ERROR, NAME_IDENTIFIER);
+
     // Type parameter declarations
 
     DiagnosticFactory1<JetTypeReference, JetType> FINAL_UPPER_BOUND = DiagnosticFactory1.create(WARNING);

compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/rendering/DefaultErrorMessages.java

@@ -216,6 +216,8 @@ public class DefaultErrorMessages {
 
         MAP.put(MANY_CLASS_OBJECTS, "Only one class object is allowed per class");
         MAP.put(CLASS_OBJECT_NOT_ALLOWED, "A class object is not allowed here");
+        MAP.put(LOCAL_OBJECT_NOT_ALLOWED, "Named object ''{0}'' is a singleton and cannot be local. Try to use anonymous object instead", NAME);
+        MAP.put(LOCAL_ENUM_NOT_ALLOWED, "Enum class ''{0}'' cannot be local", NAME);
         MAP.put(DELEGATION_IN_TRAIT, "Traits cannot use delegation");
         MAP.put(DELEGATION_NOT_TO_TRAIT, "Only traits can be delegated to");
         MAP.put(UNMET_TRAIT_REQUIREMENT, "Super trait ''{0}'' requires subclasses to extend ''{1}''", NAME, NAME);

compiler/frontend/src/org/jetbrains/jet/lang/psi/JetPsiUtil.java

@@ -835,6 +835,7 @@ public class JetPsiUtil {
                 JetBlockExpression.class, JetClassInitializer.class, JetProperty.class, JetFunction.class, JetParameter.class
         );
         if (container == null) return null;
+        if (container.getParent() instanceof JetScript) return null;
 
         return (container instanceof JetClassInitializer) ? ((JetClassInitializer) container).getBody() : container;
     }

compiler/frontend/src/org/jetbrains/jet/lang/resolve/DeclarationResolver.java

@@ -182,7 +182,8 @@ public class DeclarationResolver {
                             scopeForPropertyInitializers,
                             property,
                             trace,
-                            c.getOuterDataFlowInfo());
+                            c.getOuterDataFlowInfo()
+                    );
                     packageLike.addPropertyDescriptor(propertyDescriptor);
                     c.getProperties().put(property, propertyDescriptor);
                     c.registerDeclaringScope(property, scopeForPropertyInitializers);

compiler/frontend/src/org/jetbrains/jet/lang/resolve/DeclarationsChecker.java

@@ -76,7 +76,7 @@ public class DeclarationsChecker {
                         jetClass, classDescriptor, classDescriptor.getScopeForClassHeaderResolution(), trace);
             }
             else if (classOrObject instanceof JetObjectDeclaration) {
-                checkObject((JetObjectDeclaration) classOrObject);
+                checkObject((JetObjectDeclaration) classOrObject, classDescriptor);
             }
 
             modifiersChecker.checkModifiersForDeclaration(classOrObject, classDescriptor);
@@ -245,8 +245,11 @@ public class DeclarationsChecker {
         public abstract boolean removeNeeded(JetType subject, JetType other);
     }
 
-    private void checkObject(JetObjectDeclaration declaration) {
+    private void checkObject(JetObjectDeclaration declaration, ClassDescriptor classDescriptor) {
         reportErrorIfHasIllegalModifier(declaration);
+        if  (declaration.isLocal() && !declaration.isClassObject() && !declaration.isObjectLiteral()) {
+            trace.report(LOCAL_OBJECT_NOT_ALLOWED.on(declaration, classDescriptor));
+        }
     }
 
     private void checkClass(BodiesResolveContext c, JetClass aClass, ClassDescriptorWithResolutionScopes classDescriptor) {
@@ -264,6 +267,9 @@ public class DeclarationsChecker {
         }
         else if (aClass.isEnum()) {
             checkEnumModifiers(aClass);
+            if (aClass.isLocal()) {
+                trace.report(LOCAL_ENUM_NOT_ALLOWED.on(aClass, classDescriptor));
+            }
         }
         else if (aClass instanceof JetEnumEntry) {
             checkEnumEntry((JetEnumEntry) aClass, classDescriptor);

compiler/frontend/src/org/jetbrains/jet/lang/resolve/ModifiersChecker.java

@@ -37,9 +37,7 @@ import java.util.Collection;
 import java.util.Collections;
 import java.util.Map;
 
-import static org.jetbrains.jet.lang.diagnostics.Errors.ILLEGAL_MODIFIER;
-import static org.jetbrains.jet.lang.diagnostics.Errors.ILLEGAL_PLATFORM_NAME;
-import static org.jetbrains.jet.lang.diagnostics.Errors.INAPPLICABLE_ANNOTATION;
+import static org.jetbrains.jet.lang.diagnostics.Errors.*;
 import static org.jetbrains.jet.lexer.JetTokens.*;
 
 public class ModifiersChecker {
@@ -121,16 +119,17 @@ public class ModifiersChecker {
     }
 
     private void checkInnerModifier(@NotNull JetModifierListOwner modifierListOwner, @NotNull DeclarationDescriptor descriptor) {
-        JetModifierList modifierList = modifierListOwner.getModifierList();
-
-        if (modifierList != null && modifierList.hasModifier(INNER_KEYWORD)) {
+        if (modifierListOwner.hasModifier(INNER_KEYWORD)) {
             if (isIllegalInner(descriptor)) {
-                checkIllegalInThisContextModifiers(modifierList, Collections.singletonList(INNER_KEYWORD));
+                checkIllegalInThisContextModifiers(modifierListOwner.getModifierList(), Collections.singletonList(INNER_KEYWORD));
             }
+            return;
         }
-        else {
-            if (modifierListOwner instanceof JetClass && !(modifierListOwner instanceof JetEnumEntry) && isIllegalNestedClass(descriptor)) {
-                trace.report(Errors.NESTED_CLASS_NOT_ALLOWED.on((JetClass) modifierListOwner));
+        if (modifierListOwner instanceof JetClass && !(modifierListOwner instanceof JetEnumEntry)) {
+            JetClass aClass = (JetClass) modifierListOwner;
+            boolean localEnumError = aClass.isLocal() && aClass.isEnum();
+            if (!localEnumError && isIllegalNestedClass(descriptor)) {
+                trace.report(NESTED_CLASS_NOT_ALLOWED.on(aClass));
             }
         }
     }

compiler/frontend/src/org/jetbrains/jet/lang/resolve/extension/InlineAnalyzerExtension.java

@@ -61,15 +61,6 @@ public class InlineAnalyzerExtension implements FunctionAnalyzerExtension.Analyz
                 trace.report(Errors.NOT_YET_SUPPORTED_IN_INLINE.on(klass, klass, descriptor));
             }
 
-            @Override
-            public void visitObjectDeclaration(@NotNull JetObjectDeclaration declaration) {
-                if (declaration.getParent() instanceof JetObjectLiteralExpression) {
-                    super.visitObjectDeclaration(declaration);
-                } else {
-                    trace.report(Errors.NOT_YET_SUPPORTED_IN_INLINE.on(declaration, declaration, descriptor));
-                }
-            }
-
             @Override
             public void visitNamedFunction(@NotNull JetNamedFunction function) {
                 if (function.getParent().getParent() instanceof JetObjectDeclaration) {

compiler/frontend/src/org/jetbrains/jet/lang/resolve/lazy/descriptors/AbstractLazyMemberScope.java

@@ -181,7 +181,8 @@ public abstract class AbstractLazyMemberScope<D extends DeclarationDescriptor, D
                            trace,
                            // this relies on the assumption that a lazily resolved declaration is not a local one,
                            // thus doesn't have a surrounding data flow
-                           DataFlowInfo.EMPTY);
+                           DataFlowInfo.EMPTY
+                    );
             result.add(propertyDescriptor);
             AnnotationResolver.resolveAnnotationsArguments(propertyDescriptor, trace);
         }

compiler/testData/codegen/box/enum/inFunction.kt

@@ -1,11 +0,0 @@
-// KT-2948 Assertion fails on a local enum
-
-fun foo(): String {
-   enum class E {
-       OK
-   }
-
-   return E.OK.toString()
-}
-
-fun box(): String = foo()

compiler/testData/codegen/box/enum/kt2673.kt

@@ -1,8 +0,0 @@
-fun box(): String {
-    enum class K {
-        O
-        K
-    }
-
-    return K.O.toString() + K.K.toString()
-}

compiler/testData/codegen/box/localClasses/enum.kt

@@ -1,8 +0,0 @@
-fun box(): String {
-    enum class K {
-        O
-        K
-    }
-
-    return K.O.toString() + K.K.toString()
-}

compiler/testData/codegen/box/localClasses/localClassInInitializer.kt

@@ -6,11 +6,11 @@ class A {
             open fun s() : String = "O"
         }
 
-        object O: B() {
+        val o = object : B() {
             override fun s(): String = "K"
         }
 
-        a = B().s() + O.s()
+        a = B().s() + o.s()
     }
 }
 

compiler/testData/codegen/box/localClasses/localClassInParameterInitializer.kt

@@ -4,11 +4,11 @@ class A(
                 open fun s() : String = "O"
             }
 
-            object O: B() {
+            val o = object : B() {
                 override fun s(): String = "K"
             }
 
-            B().s() + O.s()
+            B().s() + o.s()
         }()
 )
 

compiler/testData/codegen/box/localClasses/object.kt

@@ -1,7 +1,7 @@
 fun box(): String {
-    object K {
+    val k = object {
         val ok = "OK"
     }
 
-    return K.ok
+    return k.ok
 }

compiler/testData/codegen/box/objects/objectInLocalAnonymousObject.kt

@@ -0,0 +1,10 @@
+fun box(): String {
+    var boo = "OK"
+    var foo = object {
+        val bar = object {
+            val baz = boo
+        }
+    }
+
+    return foo.bar.baz
+}

compiler/testData/codegen/boxWithStdlib/callableReference/function/local/enumExtendsTrait.kt

@@ -1,11 +1,11 @@
-fun box(): String {
-    trait Named {
-        fun name(): String
-    }
-    
-    enum class E : Named {
-        OK
-    }
+trait Named {
+    fun name(): String
+}
 
+enum class E : Named {
+    OK
+}
+
+fun box(): String {
     return E.OK.(Named::name)()
 }

compiler/testData/diagnostics/tests/FunctionReturnTypes.kt

@@ -193,7 +193,7 @@ fun testFunctionLiterals() {
     val <!UNUSED_VARIABLE!>endsWithObjectDeclaration<!> : () -> Int = {
         var <!ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE!>x<!> = 1
         x = <!UNUSED_VALUE!>333<!>
-        <!EXPECTED_TYPE_MISMATCH!>object A {}<!>
+        <!EXPECTED_TYPE_MISMATCH!><!LOCAL_OBJECT_NOT_ALLOWED!>object A<!> {}<!>
     }
 
     val <!UNUSED_VARIABLE!>expectedUnitReturnType1<!> = { () : Unit ->
@@ -202,7 +202,7 @@ fun testFunctionLiterals() {
 
     val <!UNUSED_VARIABLE!>expectedUnitReturnType2<!> = { () : Unit ->
         fun meow() : Unit {}
-        object A {}
+        <!LOCAL_OBJECT_NOT_ALLOWED!>object A<!> {}
     }
 
-}
+}

compiler/testData/diagnostics/tests/enum/localEnums.kt

@@ -0,0 +1,18 @@
+// !DIAGNOSTICS: -UNUSED_VARIABLE
+
+fun foo() {
+    <!LOCAL_ENUM_NOT_ALLOWED!>enum class A<!> {
+        FOO
+        BAR
+    }
+    val foo = A.FOO
+    val b = object {
+        <!LOCAL_ENUM_NOT_ALLOWED!>enum class B<!> {}
+    }
+    class C {
+        <!LOCAL_ENUM_NOT_ALLOWED!>enum class D<!> {}
+    }
+    val f = {
+        <!LOCAL_ENUM_NOT_ALLOWED!>enum class E<!> {}
+    }
+}

compiler/testData/diagnostics/tests/inline/unsupportedConstruction.kt

@@ -8,9 +8,9 @@ inline fun unsupported() {
         }
     }<!>
 
-    <!NOT_YET_SUPPORTED_IN_INLINE!>object B{
-        object BInner {}
-    }<!>
+    <!LOCAL_OBJECT_NOT_ALLOWED!>object B<!>{
+        <!LOCAL_OBJECT_NOT_ALLOWED!>object BInner<!> {}
+    }
 
     <!NOT_YET_SUPPORTED_IN_INLINE!>fun local() {
         fun localInner() {}

compiler/testData/diagnostics/tests/inner/referenceToSelfInLocal.kt

@@ -11,7 +11,7 @@ fun f() {
         }
     }
 
-    object MyObject {
+    <!LOCAL_OBJECT_NOT_ALLOWED!>object MyObject<!> {
         {
             val <!UNUSED_VARIABLE!>obj<!>: MyObject = MyObject
         }

compiler/testData/diagnostics/tests/objects/ObjectsLocal.kt

@@ -14,7 +14,7 @@ fun test() {
     }
     b.foo()
 
-    object B {
+    <!LOCAL_OBJECT_NOT_ALLOWED!>object B<!> {
         fun foo() {}
     }
     B.foo()

compiler/testData/diagnostics/tests/objects/localObjects.kt

@@ -0,0 +1,15 @@
+// !DIAGNOSTICS: -UNUSED_VARIABLE
+
+fun foo() {
+    <!LOCAL_OBJECT_NOT_ALLOWED!>object a<!> {}
+    val b = object {
+        <!LOCAL_OBJECT_NOT_ALLOWED!>object c<!> {}
+    }
+    b.<!NESTED_CLASS_ACCESSED_VIA_INSTANCE_REFERENCE!>c<!>
+    class A {
+        <!LOCAL_OBJECT_NOT_ALLOWED!>object d<!> {}
+    }
+    val f = {
+        <!LOCAL_OBJECT_NOT_ALLOWED!>object e<!> {}
+    }
+}

compiler/testData/repl/objects/localObject.repl

@@ -0,0 +1,5 @@
+>>> fun foo() {
+...   object Bar {
+...   }
+... }
+ERROR: /line4.kts: (2, 1) Named object 'Bar' is a singleton and cannot be local. Try to use anonymous object instead

compiler/tests/org/jetbrains/jet/checkers/JetDiagnosticsTestGenerated.java

@@ -3194,6 +3194,11 @@ public class JetDiagnosticsTestGenerated extends AbstractJetDiagnosticsTest {
                 doTest("compiler/testData/diagnostics/tests/enum/kt2834.kt");
             }
             
+            @TestMetadata("localEnums.kt")
+            public void testLocalEnums() throws Exception {
+                doTest("compiler/testData/diagnostics/tests/enum/localEnums.kt");
+            }
+            
             @TestMetadata("starImportNestedClassAndEntries.kt")
             public void testStarImportNestedClassAndEntries() throws Exception {
                 doTest("compiler/testData/diagnostics/tests/enum/starImportNestedClassAndEntries.kt");
@@ -5921,6 +5926,11 @@ public class JetDiagnosticsTestGenerated extends AbstractJetDiagnosticsTest {
                 doTest("compiler/testData/diagnostics/tests/objects/localObjectInsideObject.kt");
             }
             
+            @TestMetadata("localObjects.kt")
+            public void testLocalObjects() throws Exception {
+                doTest("compiler/testData/diagnostics/tests/objects/localObjects.kt");
+            }
+            
             @TestMetadata("objectLiteralExpressionTypeMismatch.kt")
             public void testObjectLiteralExpressionTypeMismatch() throws Exception {
                 doTest("compiler/testData/diagnostics/tests/objects/objectLiteralExpressionTypeMismatch.kt");

compiler/tests/org/jetbrains/jet/codegen/generated/BlackBoxCodegenTestGenerated.java

@@ -2114,11 +2114,6 @@ public class BlackBoxCodegenTestGenerated extends AbstractBlackBoxCodegenTest {
             doTest("compiler/testData/codegen/box/enum/entrywithinner.kt");
         }
         
-        @TestMetadata("inFunction.kt")
-        public void testInFunction() throws Exception {
-            doTest("compiler/testData/codegen/box/enum/inFunction.kt");
-        }
-        
         @TestMetadata("inPackage.kt")
         public void testInPackage() throws Exception {
             doTest("compiler/testData/codegen/box/enum/inPackage.kt");
@@ -2149,11 +2144,6 @@ public class BlackBoxCodegenTestGenerated extends AbstractBlackBoxCodegenTest {
             doTest("compiler/testData/codegen/box/enum/kt2350.kt");
         }
         
-        @TestMetadata("kt2673.kt")
-        public void testKt2673() throws Exception {
-            doTest("compiler/testData/codegen/box/enum/kt2673.kt");
-        }
-        
         @TestMetadata("name.kt")
         public void testName() throws Exception {
             doTest("compiler/testData/codegen/box/enum/name.kt");
@@ -3336,11 +3326,6 @@ public class BlackBoxCodegenTestGenerated extends AbstractBlackBoxCodegenTest {
             doTest("compiler/testData/codegen/box/localClasses/anonymousObjectInParameterInitializer.kt");
         }
         
-        @TestMetadata("enum.kt")
-        public void testEnum() throws Exception {
-            doTest("compiler/testData/codegen/box/localClasses/enum.kt");
-        }
-        
         @TestMetadata("inExtensionFunction.kt")
         public void testInExtensionFunction() throws Exception {
             doTest("compiler/testData/codegen/box/localClasses/inExtensionFunction.kt");
@@ -4059,6 +4044,11 @@ public class BlackBoxCodegenTestGenerated extends AbstractBlackBoxCodegenTest {
             doTest("compiler/testData/codegen/box/objects/nestedObjectWithSuperclass.kt");
         }
         
+        @TestMetadata("objectInLocalAnonymousObject.kt")
+        public void testObjectInLocalAnonymousObject() throws Exception {
+            doTest("compiler/testData/codegen/box/objects/objectInLocalAnonymousObject.kt");
+        }
+        
         @TestMetadata("objectLiteral.kt")
         public void testObjectLiteral() throws Exception {
             doTest("compiler/testData/codegen/box/objects/objectLiteral.kt");

compiler/tests/org/jetbrains/jet/repl/ReplInterpreterTestGenerated.java

@@ -186,6 +186,11 @@ public class ReplInterpreterTestGenerated extends AbstractReplInterpreterTest {
             doTest("compiler/testData/repl/objects/emptyObject.repl");
         }
         
+        @TestMetadata("localObject.repl")
+        public void testLocalObject() throws Exception {
+            doTest("compiler/testData/repl/objects/localObject.repl");
+        }
+        
         @TestMetadata("simpleObjectDeclaration.repl")
         public void testSimpleObjectDeclaration() throws Exception {
             doTest("compiler/testData/repl/objects/simpleObjectDeclaration.repl");

compiler/tests/org/jetbrains/jet/types/JetDefaultModalityModifiersTest.java

@@ -134,8 +134,8 @@ public class JetDefaultModalityModifiersTest extends JetLiteFixture {
 
             List<JetDeclaration> declarations = aClass.getDeclarations();
             JetProperty property = (JetProperty) declarations.get(0);
-            PropertyDescriptor propertyDescriptor = descriptorResolver.resolvePropertyDescriptor(classDescriptor, scope, property,
-                                                                                                 JetTestUtils.DUMMY_TRACE, DataFlowInfo.EMPTY);
+            PropertyDescriptor propertyDescriptor = descriptorResolver.resolvePropertyDescriptor(
+                    classDescriptor, scope, property, JetTestUtils.DUMMY_TRACE, DataFlowInfo.EMPTY);
 
             assertEquals(expectedPropertyModality, propertyDescriptor.getModality());
         }
@@ -147,8 +147,8 @@ public class JetDefaultModalityModifiersTest extends JetLiteFixture {
 
             List<JetDeclaration> declarations = aClass.getDeclarations();
             JetProperty property = (JetProperty) declarations.get(0);
-            PropertyDescriptor propertyDescriptor = descriptorResolver.resolvePropertyDescriptor(classDescriptor, scope, property,
-                                                                                                 JetTestUtils.DUMMY_TRACE, DataFlowInfo.EMPTY);
+            PropertyDescriptor propertyDescriptor = descriptorResolver.resolvePropertyDescriptor(
+                    classDescriptor, scope, property, JetTestUtils.DUMMY_TRACE, DataFlowInfo.EMPTY);
             PropertyAccessorDescriptor propertyAccessor = isGetter
                                                           ? propertyDescriptor.getGetter()
                                                           : propertyDescriptor.getSetter();