diff --git a/js/js.tests/test/org/jetbrains/kotlin/js/test/SingleFileTranslationTest.java b/js/js.tests/test/org/jetbrains/kotlin/js/test/SingleFileTranslationTest.java index ed048fc47f7..13135855652 100644 --- a/js/js.tests/test/org/jetbrains/kotlin/js/test/SingleFileTranslationTest.java +++ b/js/js.tests/test/org/jetbrains/kotlin/js/test/SingleFileTranslationTest.java @@ -50,7 +50,7 @@ public abstract class SingleFileTranslationTest extends BasicTest { runFunctionOutputTestByPath(ecmaVersions, getInputFilePath(kotlinFilename), packageName, functionName, expectedResult); } - protected void runFunctionOutputTestByPath( + private void runFunctionOutputTestByPath( @NotNull Iterable ecmaVersions, @NotNull String kotlinFilePath, @NotNull String packageName, @@ -73,14 +73,6 @@ public abstract class SingleFileTranslationTest extends BasicTest { checkFooBoxIsTrue(getTestName(true) + ".kt", DEFAULT_ECMA_VERSIONS); } - protected void fooBoxIsValue(Object expected) throws Exception { - runFunctionOutputTest(DEFAULT_ECMA_VERSIONS, getTestName(true) + ".kt", TEST_PACKAGE, TEST_FUNCTION, expected); - } - - protected void fooBoxTest(@NotNull Iterable ecmaVersions) throws Exception { - checkFooBoxIsTrue(getTestName(true) + ".kt", ecmaVersions); - } - protected void checkFooBoxIsOk() throws Exception { checkFooBoxIsOk(getTestName(true) + ".kt"); } diff --git a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/DollarParameterTest.java b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/DollarParameterTest.java index e024732ed8d..cd1f1953121 100644 --- a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/DollarParameterTest.java +++ b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/DollarParameterTest.java @@ -23,6 +23,6 @@ public final class DollarParameterTest extends AbstractExpressionTest { } public void testDollarParameter() throws Exception { - fooBoxIsValue("Hello world!"); + checkFooBoxIsOk(); } } diff --git a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/InvokeConventionTest.java b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/InvokeConventionTest.java index 2c010d27514..756f205e142 100644 --- a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/InvokeConventionTest.java +++ b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/InvokeConventionTest.java @@ -23,7 +23,7 @@ public final class InvokeConventionTest extends AbstractExpressionTest { } public void testInvokeMethod() throws Exception { - fooBoxIsValue("hello world!"); + checkFooBoxIsOk(); } public void testExplicitInvokeLambda() throws Exception { diff --git a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/MiscTest.java b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/MiscTest.java index 1f892bc20a5..751e027f320 100644 --- a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/MiscTest.java +++ b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/MiscTest.java @@ -149,7 +149,7 @@ public final class MiscTest extends AbstractExpressionTest { } public void testPackageLevelVarInPackage() throws Exception { - fooBoxIsValue("OK"); + checkFooBoxIsOk(); } public void testPackageLevelVarInRoot() throws Exception { @@ -161,7 +161,7 @@ public final class MiscTest extends AbstractExpressionTest { } public void testLocalVarAsFunction() throws Exception { - fooBoxIsValue("OK"); + checkFooBoxIsOk(); } public void testExclExclThrows() throws Exception { diff --git a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/NumberTest.java b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/NumberTest.java index aa3367012ac..c86347d8a7a 100644 --- a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/NumberTest.java +++ b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/NumberTest.java @@ -42,7 +42,7 @@ public final class NumberTest extends SingleFileTranslationTest { } public void testDivision() throws Exception { - fooBoxIsValue("SUCCESS"); + checkFooBoxIsOk(); } // KT-2342 Type mismatch on Int division (JavaScript back-end) diff --git a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/PropertyAccessTest.java b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/PropertyAccessTest.java index 7a0b1c3f6f8..4fca9c12afb 100644 --- a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/PropertyAccessTest.java +++ b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/PropertyAccessTest.java @@ -43,7 +43,7 @@ public final class PropertyAccessTest extends SingleFileTranslationTest { } public void testSetter() throws Exception { - fooBoxIsValue(99.0); + checkFooBoxIsOk(); } diff --git a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/StringTemplatesTest.java b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/StringTemplatesTest.java index 498e9c12f50..d5047f11ba3 100644 --- a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/StringTemplatesTest.java +++ b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/StringTemplatesTest.java @@ -23,7 +23,7 @@ public final class StringTemplatesTest extends AbstractExpressionTest { } public void testObjectWithToString() throws Exception { - fooBoxIsValue("a = abcS, b = defS"); + checkFooBoxIsOk(); } public void testStringValues() throws Exception { diff --git a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/StringTest.java b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/StringTest.java index e97f210602c..cf68410b062 100644 --- a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/StringTest.java +++ b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/StringTest.java @@ -59,7 +59,7 @@ public final class StringTest extends AbstractExpressionTest { } public void testNumbersInTemplate() throws Exception { - fooBoxIsValue("2354"); + checkFooBoxIsOk(); } public void testStringSplit() throws Exception { diff --git a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/WhenTest.java b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/WhenTest.java index 302e731925c..a6d76fc34cc 100644 --- a/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/WhenTest.java +++ b/js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/WhenTest.java @@ -53,7 +53,7 @@ public final class WhenTest extends AbstractExpressionTest { } public void testMultipleCases() throws Exception { - fooBoxIsValue(2.0); + checkFooBoxIsOk(); } public void testMatchNullableType() throws Exception { diff --git a/js/js.translator/testData/expression/dollarParameter/cases/dollarParameter.kt b/js/js.translator/testData/expression/dollarParameter/cases/dollarParameter.kt index d69cf733a60..57dd70af5a3 100644 --- a/js/js.translator/testData/expression/dollarParameter/cases/dollarParameter.kt +++ b/js/js.translator/testData/expression/dollarParameter/cases/dollarParameter.kt @@ -5,5 +5,6 @@ fun MyController(`$scope`: String): String { } fun box(): String { - return MyController("world") -} \ No newline at end of file + assertEquals("Hello world!", MyController("world")) + return "OK" +} diff --git a/js/js.translator/testData/expression/invoke/cases/invokeMethod.kt b/js/js.translator/testData/expression/invoke/cases/invokeMethod.kt index 30466eb98f9..afe8921e969 100644 --- a/js/js.translator/testData/expression/invoke/cases/invokeMethod.kt +++ b/js/js.translator/testData/expression/invoke/cases/invokeMethod.kt @@ -8,5 +8,6 @@ class Foo(val postfix: String) { fun box(): String { val a = Foo(" world!") - return a("hello") -} \ No newline at end of file + assertEquals("hello world!", a("hello")) + return "OK" +} diff --git a/js/js.translator/testData/expression/string/cases/numbersInTemplate.kt b/js/js.translator/testData/expression/string/cases/numbersInTemplate.kt index 8f47b0eee0d..8e58308eb84 100644 --- a/js/js.translator/testData/expression/string/cases/numbersInTemplate.kt +++ b/js/js.translator/testData/expression/string/cases/numbersInTemplate.kt @@ -4,6 +4,7 @@ fun box(): String { val number = 3 val s1 = "${number - 1}${number}" val s2 = "${5}${4}" - return "${s1}${s2}" + assertEquals("2354", "${s1}${s2}") + return "OK" } diff --git a/js/js.translator/testData/expression/stringTemplates/cases/objectWithToString.kt b/js/js.translator/testData/expression/stringTemplates/cases/objectWithToString.kt index 020ba81bdd9..bf8df5c3922 100644 --- a/js/js.translator/testData/expression/stringTemplates/cases/objectWithToString.kt +++ b/js/js.translator/testData/expression/stringTemplates/cases/objectWithToString.kt @@ -10,5 +10,6 @@ fun box(): String { val a = Foo("abc") val b = Foo("def") val message = "a = $a, b = $b" - return message -} \ No newline at end of file + assertEquals("a = abcS, b = defS", message) + return "OK" +} diff --git a/js/js.translator/testData/expression/when/cases/multipleCases.kt b/js/js.translator/testData/expression/when/cases/multipleCases.kt index c98defa288f..db160000b3e 100644 --- a/js/js.translator/testData/expression/when/cases/multipleCases.kt +++ b/js/js.translator/testData/expression/when/cases/multipleCases.kt @@ -1,6 +1,6 @@ package foo -fun box(): Int { +fun box(): String { val c = 3 val d = 5 var z = 0 @@ -17,5 +17,6 @@ fun box(): Int { z = -1000; } } - return z -} \ No newline at end of file + assertEquals(2, z) + return "OK" +} diff --git a/js/js.translator/testData/number/cases/division.kt b/js/js.translator/testData/number/cases/division.kt index 88db0e4fec5..4095a08c275 100644 --- a/js/js.translator/testData/number/cases/division.kt +++ b/js/js.translator/testData/number/cases/division.kt @@ -40,5 +40,5 @@ fun box(): Any? { if ((f3 / f4 - 2.5.toFloat()) > 0.01) { return "9" } - return "SUCCESS" -} \ No newline at end of file + return "OK" +} diff --git a/js/js.translator/testData/propertyAccess/cases/setter.kt b/js/js.translator/testData/propertyAccess/cases/setter.kt index b4e1432eaa2..75e059fe047 100644 --- a/js/js.translator/testData/propertyAccess/cases/setter.kt +++ b/js/js.translator/testData/propertyAccess/cases/setter.kt @@ -4,9 +4,10 @@ class Test() { var a: Int = 1 } -fun box(): Int { - var a = Test() +fun box(): String { var b = Test() + assertEquals(1, b.a) b.a = 100 - return (b.a - a.a) -} \ No newline at end of file + assertEquals(100, b.a) + return "OK" +}