azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: rename method and remove FIXME comment.

Browse Source
This commit is contained in:
Artem Kobzar
2022-04-19 12:45:33 +02:00
committed by teamcity
parent 93dcc48512
commit 9d0c7a55b1
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/ir/backend.js/src/org/jetbrains/kotlin/ir/backend/js/lower/AutoboxingTransformer.kt
+2 -4
View File
@@ -18,8 +18,6 @@ import org.jetbrains.kotlin.ir.types.*
import org.jetbrains.kotlin.ir.util.isPrimitiveArray import org.jetbrains.kotlin.ir.util.isPrimitiveArray
import org.jetbrains.kotlin.ir.util.patchDeclarationParents import org.jetbrains.kotlin.ir.util.patchDeclarationParents
import org.jetbrains.kotlin.ir.util.render import org.jetbrains.kotlin.ir.util.render
import org.jetbrains.kotlin.ir.visitors.IrElementVisitorVoid
import org.jetbrains.kotlin.ir.visitors.acceptChildrenVoid
// Copied and adapted from Kotlin/Native // Copied and adapted from Kotlin/Native
@@ -195,14 +193,14 @@ class AutoboxingTransformer(context: JsCommonBackendContext) : AbstractValueUsag
} }
override fun visitCall(expression: IrCall): IrExpression { override fun visitCall(expression: IrCall): IrExpression {
if (expression.symbol == irBuiltIns.eqeqeqSymbol && expression.isAllArgumentsHaveType(irBuiltIns.charType)) { if (expression.symbol == irBuiltIns.eqeqeqSymbol && expression.allArgumentsHaveType(irBuiltIns.charType)) {
return expression.apply { transformChildrenVoid() } return expression.apply { transformChildrenVoid() }
} else { } else {
return super.visitCall(expression) return super.visitCall(expression)
} }
} }
private fun IrCall.isAllArgumentsHaveType(type: IrType): Boolean { private fun IrCall.allArgumentsHaveType(type: IrType): Boolean {
for (i in 0 until valueArgumentsCount) { for (i in 0 until valueArgumentsCount) {
if (getValueArgument(i)?.type != type) { if (getValueArgument(i)?.type != type) {
return false return false
js/js.translator/testData/box/char/charEquals.kt
Vendored
-1
View File
@@ -7,7 +7,6 @@ fun box(): String {
assertEquals(false, 'A' == 'B') assertEquals(false, 'A' == 'B')
assertEquals(false, ('A' as Any) == (65 as Any)) assertEquals(false, ('A' as Any) == (65 as Any))
// FIXME(KT-50157)
assertEquals(true, 'A' === 'A') assertEquals(true, 'A' === 'A')
assertEquals(false, 'A' === 'B') assertEquals(false, 'A' === 'B')
assertEquals(false, ('A' as Any) === (65 as Any)) assertEquals(false, ('A' as Any) === (65 as Any))