From 9bf91e95d069b3c5a318fdc89893b08d7e37daf4 Mon Sep 17 00:00:00 2001 From: Alexander Udalov Date: Tue, 5 Jul 2016 15:31:27 +0300 Subject: [PATCH] Change default visibility for TypeAlias from 'internal' to 'public' Since public type aliases will supposedly be more common than internal ones, it makes sense to save on writing flags for the former rather than the latter --- .../kotlin/serialization/DebugProtoBuf.java | 26 +++++++++---------- core/deserialization/src/descriptors.proto | 2 +- .../kotlin/serialization/ProtoBuf.java | 24 ++++++++--------- 3 files changed, 26 insertions(+), 26 deletions(-) diff --git a/build-common/test/org/jetbrains/kotlin/serialization/DebugProtoBuf.java b/build-common/test/org/jetbrains/kotlin/serialization/DebugProtoBuf.java index 5390fc8e15b..4d84337dfb8 100644 --- a/build-common/test/org/jetbrains/kotlin/serialization/DebugProtoBuf.java +++ b/build-common/test/org/jetbrains/kotlin/serialization/DebugProtoBuf.java @@ -22172,7 +22172,7 @@ public final class DebugProtoBuf { ExtendableMessageOrBuilder { /** - * optional int32 flags = 1 [default = 0]; + * optional int32 flags = 1 [default = 6]; * *
      *hasAnnotations
@@ -22181,7 +22181,7 @@ public final class DebugProtoBuf {
      */
     boolean hasFlags();
     /**
-     * optional int32 flags = 1 [default = 0];
+     * optional int32 flags = 1 [default = 6];
      *
      * 
      *hasAnnotations
@@ -22455,7 +22455,7 @@ public final class DebugProtoBuf {
     public static final int FLAGS_FIELD_NUMBER = 1;
     private int flags_;
     /**
-     * optional int32 flags = 1 [default = 0];
+     * optional int32 flags = 1 [default = 6];
      *
      * 
      *hasAnnotations
@@ -22466,7 +22466,7 @@ public final class DebugProtoBuf {
       return ((bitField0_ & 0x00000001) == 0x00000001);
     }
     /**
-     * optional int32 flags = 1 [default = 0];
+     * optional int32 flags = 1 [default = 6];
      *
      * 
      *hasAnnotations
@@ -22635,7 +22635,7 @@ public final class DebugProtoBuf {
     }
 
     private void initFields() {
-      flags_ = 0;
+      flags_ = 6;
       name_ = 0;
       typeParameter_ = java.util.Collections.emptyList();
       underlyingType_ = org.jetbrains.kotlin.serialization.DebugProtoBuf.Type.getDefaultInstance();
@@ -22881,7 +22881,7 @@ public final class DebugProtoBuf {
 
       public Builder clear() {
         super.clear();
-        flags_ = 0;
+        flags_ = 6;
         bitField0_ = (bitField0_ & ~0x00000001);
         name_ = 0;
         bitField0_ = (bitField0_ & ~0x00000002);
@@ -23137,9 +23137,9 @@ public final class DebugProtoBuf {
       }
       private int bitField0_;
 
-      private int flags_ ;
+      private int flags_ = 6;
       /**
-       * optional int32 flags = 1 [default = 0];
+       * optional int32 flags = 1 [default = 6];
        *
        * 
        *hasAnnotations
@@ -23150,7 +23150,7 @@ public final class DebugProtoBuf {
         return ((bitField0_ & 0x00000001) == 0x00000001);
       }
       /**
-       * optional int32 flags = 1 [default = 0];
+       * optional int32 flags = 1 [default = 6];
        *
        * 
        *hasAnnotations
@@ -23161,7 +23161,7 @@ public final class DebugProtoBuf {
         return flags_;
       }
       /**
-       * optional int32 flags = 1 [default = 0];
+       * optional int32 flags = 1 [default = 6];
        *
        * 
        *hasAnnotations
@@ -23175,7 +23175,7 @@ public final class DebugProtoBuf {
         return this;
       }
       /**
-       * optional int32 flags = 1 [default = 0];
+       * optional int32 flags = 1 [default = 6];
        *
        * 
        *hasAnnotations
@@ -23184,7 +23184,7 @@ public final class DebugProtoBuf {
        */
       public Builder clearFlags() {
         bitField0_ = (bitField0_ & ~0x00000001);
-        flags_ = 0;
+        flags_ = 6;
         onChanged();
         return this;
       }
@@ -24642,7 +24642,7 @@ public final class DebugProtoBuf {
       "ararg_element_type\030\004 \001(\0132(.org.jetbrains" +
       ".kotlin.serialization.Type\022\036\n\026vararg_ele",
       "ment_type_id\030\006 \001(\005*\005\010d\020\310\001\"\201\003\n\tTypeAlias\022" +
-      "\020\n\005flags\030\001 \001(\005:\0010\022\022\n\004name\030\002 \002(\005B\004\210\265\030\001\022I\n" +
+      "\020\n\005flags\030\001 \001(\005:\0016\022\022\n\004name\030\002 \002(\005B\004\210\265\030\001\022I\n" +
       "\016type_parameter\030\003 \003(\01321.org.jetbrains.ko" +
       "tlin.serialization.TypeParameter\022A\n\017unde" +
       "rlying_type\030\004 \001(\0132(.org.jetbrains.kotlin" +
diff --git a/core/deserialization/src/descriptors.proto b/core/deserialization/src/descriptors.proto
index 3ed5fa3536c..d4b0fda1cea 100644
--- a/core/deserialization/src/descriptors.proto
+++ b/core/deserialization/src/descriptors.proto
@@ -336,7 +336,7 @@ message TypeAlias {
     hasAnnotations
     Visibility
   */
-  optional int32 flags = 1 [default = 0];
+  optional int32 flags = 1 [default = 6 /* public, no annotations */];
 
   required int32 name = 2 [(name_id_in_table) = true];
 
diff --git a/core/deserialization/src/org/jetbrains/kotlin/serialization/ProtoBuf.java b/core/deserialization/src/org/jetbrains/kotlin/serialization/ProtoBuf.java
index 7255e23f183..14dd31e4ea1 100644
--- a/core/deserialization/src/org/jetbrains/kotlin/serialization/ProtoBuf.java
+++ b/core/deserialization/src/org/jetbrains/kotlin/serialization/ProtoBuf.java
@@ -17012,7 +17012,7 @@ public final class ProtoBuf {
             ExtendableMessageOrBuilder {
 
     /**
-     * optional int32 flags = 1 [default = 0];
+     * optional int32 flags = 1 [default = 6];
      *
      * 
      *hasAnnotations
@@ -17021,7 +17021,7 @@ public final class ProtoBuf {
      */
     boolean hasFlags();
     /**
-     * optional int32 flags = 1 [default = 0];
+     * optional int32 flags = 1 [default = 6];
      *
      * 
      *hasAnnotations
@@ -17259,7 +17259,7 @@ public final class ProtoBuf {
     public static final int FLAGS_FIELD_NUMBER = 1;
     private int flags_;
     /**
-     * optional int32 flags = 1 [default = 0];
+     * optional int32 flags = 1 [default = 6];
      *
      * 
      *hasAnnotations
@@ -17270,7 +17270,7 @@ public final class ProtoBuf {
       return ((bitField0_ & 0x00000001) == 0x00000001);
     }
     /**
-     * optional int32 flags = 1 [default = 0];
+     * optional int32 flags = 1 [default = 6];
      *
      * 
      *hasAnnotations
@@ -17427,7 +17427,7 @@ public final class ProtoBuf {
     }
 
     private void initFields() {
-      flags_ = 0;
+      flags_ = 6;
       name_ = 0;
       typeParameter_ = java.util.Collections.emptyList();
       underlyingType_ = org.jetbrains.kotlin.serialization.ProtoBuf.Type.getDefaultInstance();
@@ -17644,7 +17644,7 @@ public final class ProtoBuf {
 
       public Builder clear() {
         super.clear();
-        flags_ = 0;
+        flags_ = 6;
         bitField0_ = (bitField0_ & ~0x00000001);
         name_ = 0;
         bitField0_ = (bitField0_ & ~0x00000002);
@@ -17822,9 +17822,9 @@ public final class ProtoBuf {
       }
       private int bitField0_;
 
-      private int flags_ ;
+      private int flags_ = 6;
       /**
-       * optional int32 flags = 1 [default = 0];
+       * optional int32 flags = 1 [default = 6];
        *
        * 
        *hasAnnotations
@@ -17835,7 +17835,7 @@ public final class ProtoBuf {
         return ((bitField0_ & 0x00000001) == 0x00000001);
       }
       /**
-       * optional int32 flags = 1 [default = 0];
+       * optional int32 flags = 1 [default = 6];
        *
        * 
        *hasAnnotations
@@ -17846,7 +17846,7 @@ public final class ProtoBuf {
         return flags_;
       }
       /**
-       * optional int32 flags = 1 [default = 0];
+       * optional int32 flags = 1 [default = 6];
        *
        * 
        *hasAnnotations
@@ -17860,7 +17860,7 @@ public final class ProtoBuf {
         return this;
       }
       /**
-       * optional int32 flags = 1 [default = 0];
+       * optional int32 flags = 1 [default = 6];
        *
        * 
        *hasAnnotations
@@ -17869,7 +17869,7 @@ public final class ProtoBuf {
        */
       public Builder clearFlags() {
         bitField0_ = (bitField0_ & ~0x00000001);
-        flags_ = 0;
+        flags_ = 6;
         
         return this;
       }